[Bug 8381] New: Paging broken in OPAC search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 Priority: P1 - high Change sponsored?: --- Bug ID: 8381 Assignee: oleonard@myacpl.org Summary: Paging broken in OPAC search results Severity: critical Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha The paging in the OPAC search results is now very broken: if you use the next link instead of choosing specific pages, you will be unable to get past page 2, and end up with a query string like this: /cgi-bin/koha/opac-search.pl?q=smith&offset=20&offset=40&offset=40 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This is also an issue in 3.8.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Problem caused by commit b20ffe15bb365a14fbe20956f038670fe77044ae, Bug 5981 - OPAC: Add limits to search history -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Commit is reverted out of 3.8.x now, thanks for the catch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Assignee|oleonard@myacpl.org |alex.arnaud@biblibre.com --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Alex, I'm assigning this bug to you, because you're author of the patch that caused it, see bug 5981. I confirm that the following lines are the origin of the problem: + my $path_info = $cgi->url(-path_info=>1); + $query_cgi = $cgi->url(-query=>1); + $query_cgi =~ s/^$path_info\?//; + $query_cgi =~ s/;/&/g; + $query_desc .= ", $limit_desc"; I've commented them, and the problem described here is gone. Uncommenting them, the problem is back. I can't reproduce Katrin problem described on http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981#c28, but thi one 8381 is a bug, for sure As your original bugfix contained an updatedatabase, I won't revert it, that would mean creating a "hole" in DB revision numbers, but please fix the problem quickly ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 --- Comment #5 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 10809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10809&action=edit Bug 8381 - Paging broken in OPAC search results Fix also freezing for some browser when performing a search query. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10809|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10836&action=edit [SIGNED-OFF] Bug 8381 - Paging broken in OPAC search results Fix also freezing for some browser when performing a search query. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Checked paging (previous, next and navigating to page numbers) works. Browser performance is fixed too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 10837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10837&action=edit Bug 8381: Fix adding limits to search history for logged in users Due to renaming of some variables the limits were only working for 'anonymous' users. This patch fixes some variables, so limits are also added to history when the user is logged in. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Alex's patch works nicely, but I found a small problem and I would like to see a second sign off on this, because my symptoms were different from what other testers experienced. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10837|0 |1 is obsolete| | --- Comment #9 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 10867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10867&action=edit [Signed-off] Bug 8381: Fix adding limits to search history for logged in users Due to renaming of some variables the limits were only working for 'anonymous' users. This patch fixes some variables, so limits are also added to history when the user is logged in. Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #6)
Created attachment 10836 [details] [SIGNED-OFF] Bug 8381 - Paging broken in OPAC search results
Fix also freezing for some browser when performing a search query.
what browser? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #10)
(In reply to comment #6)
Created attachment 10836 [details] [SIGNED-OFF] Bug 8381 - Paging broken in OPAC search results
Fix also freezing for some browser when performing a search query.
what browser?
works fine for me in safari, opera, firefox and chrome passes all QA tests. i'm marking this as 'Passed QA' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 Blocks| |5981 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- I made a lot of tests (logged-in and not logged-in), and could not find anything wrong. chris_c, you can push bug 5981 and this one on 3.8.x branch I think -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion Version|rel_3_8 |master --- Comment #13 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Either this patch or the patch to bug 5981 has broken the OPAC search in Chrome. With EnableOPACSearchHistory enabled, Chrome crashes on a regular keyword search (q=smith), and hangs on searches using idx=kw&q=smith. Disabling EnableOPACSearchHistory fixes the problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Holding off pushing until the problem with chrome is fixed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Jared, is this still a problem in chrome? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 --- Comment #16 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #15)
Jared, is this still a problem in chrome?
It doesn't seem to be. I don't have time to do a git bisect, but in between July 17 and now, EnableOPACSearchHistory stopped causing Chrome to hang (this time around Chrome did not crash for me). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #17 from Magnus Enger <magnus@enger.priv.no> --- I tested searching in Chromium "20.0.1132.47 Ubuntu 12.04 (144678)", with and without EnableOPACSearchHistory, and did not see any problems. Someone with access to Chrome should probably test too, before we close this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8381 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #18 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Closing because the bug is no longer reproducible on master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org