https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- +1 -- It could be interesting to have enabled/disabled options as well. Sure, in theory, you can always just comment out the code you want to disable, but depending on how you've done your code comments this can actually be a bit of a pain. Having an easy way to turn these on/off could potentially be handy. -- This is a bit of a tangent, but this could also allow us to enhance the UserJS feature. For instance, if we could toggle on 'type="module"', then we'd be able to add support for user-defined ES6 modules. (I'm curious how ES6 module imports from external URLs work with Content-Security-Policy...) That said, I don't know how much of a value add this really would be. It just popped into my mind, as I was writing some ES6 modules last week, which made it easy to share code around my codebase without interfering/polluting the global namespace. Anyway, just food for thought. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- +1 I think it would make sense to do the same for UserCSS? And have one smippet go to either the OPAC or staff, or both? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #5)

(In reply to Magnus Enger from comment #3)

...

+1 I think it would make sense to do the same for UserCSS? And have one smippet go to either the OPAC or staff, or both?

This would be a problem when we implement Content-Security-Policy. Each individual snippet will need its own type indicated.

I might be misinterpreting what you're saying though. Overall, yes for doing it for UserCSS as well. Just so long as the snippets are clearly marked as CSS or Javascript. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to David Cook from comment #7)

(In reply to Andrew Fuerste-Henry from comment #4)

...

I also like the idea of giving the user the choice of where to apply those snippets. I suppose we'd want to cover all the varieties of those sysprefs,

There's also the question of branch-level CSS and Javascript and how that fits into this...

True! I forgot that OPAC CSS and JS had been added to branches. In the structure we're ideating here it would make sense to pull that out of the branches setup and instead let each snippet be limited to one or more branches. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand@biblibre.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 hacheng@pymblelc.nsw.edu.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hacheng@pymblelc.nsw.edu.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 Steve, OSLRI, USA <sspohn@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bywater@oslri.net, | |sspohn@oslri.net -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- With snippets, I wonder if we'd want a way to specify "type" so that we could make it a ES6 module or not. Of course, with inline Javascript, there's limited utility with an anonymous module, since you can't import/export it. The main benefit would be importing other ES modules and having a stricter context (ie not polluting the global context). it could be interesting trying to implement the snippets as .js files, so rather than displaying it as an inline <script> tag, it would be <script src="/path/to/perl/endpoint_for_serving_static_javascript">. In fact... that gets extra interesting because if we did "Staff interface and OPAC" like with the "News", you could actually define 1 set of functions/modules and then re-use them across the interfaces. Of course, that might have limited utility as well. Anyway, just some blue sky thinking there... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 --- Comment #14 from Christopher Brannon <cbrannon@cdalibrary.org> --- I could see some potential pitfalls if IDs and classes are not consistent between the two. Not everything has been consistent. It's getting better, I think, but I've seen enough differences where I've had to target things differently from one side to the other. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lisette@bywatersolutions.co |ity.org |m --- Comment #16 from Lisette Scheer <lisette@bywatersolutions.com> --- A few notes about the scope of this bug + some things I'd like to do as followups after: -New table (or as part of additional contents, unsure at this point) for snippets -Interface for editing, including codemirror (subset of additional contents interface) -Initial upgrade will make one big snippet -Set up a delimter-based snippet splitter so users can define where they want snippets split and run it on demand. -Confirm global variables work/document how to make them work if anything special is needed - Permissions - Move the branch js into this -Separate try/catch for each snippet so one breaking doesn't break all -- Log in console which snippet is failing for troubleshooting My plan was not to have a "Both" locations option because there's too many different names/structure, but we could set it up and possibly note that there's differences in the names/classes of things sometimes. Later to do: - Multiselect for libraries/select library groups (probably for all additional contents) - Define module/specific pages for code to load on (example: lots of label renaming on patron edit screens, being able to define to only those specific ones or at least modules for those could be helpful) - Show on branches which snippets are all branches/specific to that branch? Not sure if this would be helpful, but large systems might find it helpful to be able to see all additional contents that are shown on a particular branch? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 --- Comment #18 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Mathieu Saby from comment #17)

In my library we have just 1 line in the UserJS, a call to a _big_ js file (with $.getScript) located in public/js We are happy with that because it allows us to version the js code outside Koha. Same thing with the CSS...

I am not sure to understand well what you're planning, but would our way of doing things still be possible?

That should still work, you'd just have one snippet with the current line. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40293 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40293 [Bug 40293] Additional content codemirror mode initializes as xml -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39538 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39538 [Bug 39538] Replace UserCSS system preference with snippets -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38706 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.