[Bug 15981] New: Serials frequencies can be deleted without warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Bug ID: 15981 Summary: Serials frequencies can be deleted without warning Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/subscription-frequencies.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Serials Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com There is some code in the serials frequencies template for triggering a JavaScript alert to confirm deletion of a frequency, but it is incomplete. You only get a warning about deleting a frequency which is in use by an existing subscription. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48699&action=edit Bug 15981 - Serials frequencies can be deleted without warning A JavaScript alert should ask the user to confirm deletion of a serial frequency. This patch adds this to the template. To test, apply the patch and go to Serials -> Manage frequencies - In the list of frequencies, click any "Delete" link. - Verify that a JavaScript alert is triggered. - Test that cancelling the alert cancels the deletion operation. - Test that confirming the alert allows the deletion to complete. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48699|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 48817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48817&action=edit Bug 15981 - Serials frequencies can be deleted without warning A JavaScript alert should ask the user to confirm deletion of a serial frequency. This patch adds this to the template. To test, apply the patch and go to Serials -> Manage frequencies - In the list of frequencies, click any "Delete" link. - Verify that a JavaScript alert is triggered. - Test that cancelling the alert cancels the deletion operation. - Test that confirming the alert allows the deletion to complete. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48817|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48842&action=edit Bug 15981 - Serials frequencies can be deleted without warning A JavaScript alert should ask the user to confirm deletion of a serial frequency. This patch adds this to the template. To test, apply the patch and go to Serials -> Manage frequencies - In the list of frequencies, click any "Delete" link. - Verify that a JavaScript alert is triggered. - Test that cancelling the alert cancels the deletion operation. - Test that confirming the alert allows the deletion to complete. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.10. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org