[Bug 15697] New: Unnecessary comma between title and subtitle on opac-detail.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Bug ID: 15697 Summary: Unnecessary comma between title and subtitle on opac-detail.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To reproduce: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping Field name: subtitle MARC field: 245 MARC subfield: b (or 200$e I think for UNIMARC) 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 47410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47410&action=edit Bug 15697 - Unnecessary comma between title and subtitle on opac-detail.pl To test: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping (or ensure it exists) Field name: subtitle MARC field: 245 MARC subfield: b 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record" 5 - Apply patch 6 - View the record again and note the comma is no longer present. Note: this patch removes the comma only for MARC21 where subtitle is not repeatable. UNIMARC seems to be repeatable and does not include punctuation so I believe this may be needed there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|enhancement |trivial Assignee|oleonard@myacpl.org |nick@bywatersolutions.com CC| |nick@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47410|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 47517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47517&action=edit Bug 15697 - Unnecessary comma between title and subtitle on opac-detail.pl To test: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping (or ensure it exists) Field name: subtitle MARC field: 245 MARC subfield: b 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record" 5 - Apply patch 6 - View the record again and note the comma is no longer present. Note: this patch removes the comma only for MARC21 where subtitle is not repeatable. UNIMARC seems to be repeatable and does not include punctuation so I believe this may be needed there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47517|0 |1 is obsolete| | --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 47524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47524&action=edit [SIGNED-OFF]Bug 15697: Unnecessary comma between title and subtitle on opac-detail.pl To test: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping (or ensure it exists) Field name: subtitle MARC field: 245 MARC subfield: b 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record" 5 - Apply patch 6 - View the record again and note the comma is no longer present. Note: this patch removes the comma only for MARC21 where subtitle is not repeatable. UNIMARC seems to be repeatable and does not include punctuation so I believe this may be needed there. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. Comma removed from title of the window and breadcrumb section -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about NORMARC? I guess it micmics MARC21. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 47554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47554&action=edit Bug 15697 - [QA Followup] Apply change to NORMARC This patch switches from UNLESS MARC21 to IF UNIMARC - this way changes apply to MARC21 and NORMARC and UNIMARC remains unaffected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #4)
What about NORMARC? I guess it micmics MARC21.
I wasn't certain so erred on leaving as is. Updated patch to use IF UNIMARC instead of UNLESS MARC21 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47524|0 |1 is obsolete| | Attachment #47554|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47577&action=edit Bug 15697: Unnecessary comma between title and subtitle on opac-detail.pl To test: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping (or ensure it exists) Field name: subtitle MARC field: 245 MARC subfield: b 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record" 5 - Apply patch 6 - View the record again and note the comma is no longer present. Note: this patch removes the comma only for MARC21 where subtitle is not repeatable. UNIMARC seems to be repeatable and does not include punctuation so I believe this may be needed there. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. Comma removed from title of the window and breadcrumb section Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47578&action=edit Bug 15697 - [QA Followup] Apply change to NORMARC This patch switches from UNLESS MARC21 to IF UNIMARC - this way changes apply to MARC21 and NORMARC and UNIMARC remains unaffected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Joubu: magnuse: could you confirm my comment on bug 15697 comment 4 about NORMARC please? magnuse: Joubu: the qa followup looks good. and yes, marc21 and normarc are very similar in most regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47577|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 48341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48341&action=edit Bug 15697: Unnecessary comma between title and subtitle on opac-detail.pl To test: 1 - Go to Administration->Keyword to MARC mapping 2 - Add a mapping (or ensure it exists) Field name: subtitle MARC field: 245 MARC subfield: b 3 - View a record with a subtitle in the opac 4 - Note in MARC 21 you have "Title of record:, subtitle of record" 5 - Apply patch 6 - View the record again and note the comma is no longer present. Note: this patch removes the comma only for MARC21 where subtitle is not repeatable. UNIMARC seems to be repeatable and does not include punctuation so I believe this may be needed there. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. Comma removed from title of the window and breadcrumb section Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47578|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 48342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48342&action=edit Bug 15697 - [QA Followup] Apply change to NORMARC This patch switches from UNLESS MARC21 to IF UNIMARC - this way changes apply to MARC21 and NORMARC and UNIMARC remains unaffected Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master! Should be in Koha 3.24, thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #14 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.10. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org