[Bug 10687] New: Incorrect tab information for tags 86a and 86b on default MARC21 auth framework
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Bug ID: 10687 Summary: Incorrect tab information for tags 86a and 86b on default MARC21 auth framework Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: bgkriegel@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Tab information for subtags of 86a and 86b is incorrect. They are listed on tab 0, when they belong to tab 6. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 20121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20121&action=edit Bug 10687 - Incorrect tab information for tags 86a and 86b on default MARC21 auth framework This patch correct tab information for default MARC21 auth framework on tags 68a and 68b. Also added update for current installs. To test with current authorities_normal_marc21.sql loaded 1) run on database select distinct tagfield from auth_subfield_structure where cast(substr(tagfield,1,1) as unsigned) <> tab; 68a and 68b should be listed 2) apply the patch 3a) delete all auth frameworks and reload file ... OR ... 3b) run updatedatabase.pl 4) repeat step 1, no tags should be listed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Bernardo: Could you provide a link to LOC for the description of these fields? I was looking for 68a History note, but I can't find it. Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Please note also that your commit message and title also refer to 86? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Incorrect tab information |Incorrect tab information |for tags 86a and 86b on |for tags 68a and 68b on |default MARC21 auth |default MARC21 auth |framework |framework -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20121|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 20584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20584&action=edit Bug 10687 - Incorrect tab information for tags 68a and 68b on default MARC21 auth framework This patch correct tab information for default MARC21 auth framework on tags 68a and 68b. Also added update for current installs. To test with current authorities_normal_marc21.sql loaded 1) run on database select distinct tagfield from auth_subfield_structure where cast(substr(tagfield,1,1) as unsigned) <> tab; 68a and 68b should be listed 2) apply the patch 3a) delete all auth frameworks and reload file ... OR ... 3b) run updatedatabase.pl 4) repeat step 1, no tags should be listed. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to M. de Rooy from comment #3)
Please note also that your commit message and title also refer to 86? Ooops! Fixed commit message and description.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to M. de Rooy from comment #2)
Bernardo: Could you provide a link to LOC for the description of these fields? I was looking for 68a History note, but I can't find it. Thanks.
Marcel: Sorry but I can't, I couldn't find any information about those tags. They are in the framework since Nov 8 2007, a patch by thd I think that they could be removed, but the policy is not to remove anything. Perhaps they are a typo, or are a strange and old set of tags, really don't know. Regards -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Bernardo Gonzalez Kriegel from comment #6)
Marcel: Sorry but I can't, I couldn't find any information about those tags. They are in the framework since Nov 8 2007, a patch by thd I think that they could be removed, but the policy is not to remove anything.
Perhaps they are a typo, or are a strange and old set of tags, really don't know.
Thanks, Bernardo. In this case I would still go for removing them and bypassing the 'policy'. Wrong tags should not be kept in the framework for historical reasons imo; the policy apparently is there to prevent deletion of old tags. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Incorrect tab information |Delete erroneous tags 68a |for tags 68a and 68b on |and 68b on default MARC21 |default MARC21 auth |auth framework |framework | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20584|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21149&action=edit Bug 10687 - Delete erroneous tags 68a and 68b on default MARC21 auth framework Ammended patch to delete tags 68a and 68b This patch deletes information for default MARC21 auth framework on tags 68a and 68b. Also added update for current installs. To test with current authorities_normal_marc21.sql loaded 1) apply the patch 2) run updatedatabase 3) check on database that there are no more references to tags 86a and 86b To test for new installs 1) remove auth frameworks 2) load authorities_normal_marc21.sql 3) check that load without problem 4) check on database that there are no more references to tags 86a and 86b -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Marcel, I changed the patch and description. Now, it removes 86a and 86b. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #9)
Marcel, I changed the patch and description. Now, it removes 86a and 86b.
Sorry again, removes 68a and 68b. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21149|0 |1 is obsolete| | --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 21372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21372&action=edit Bug 10687 - Delete erroneous tags 68a and 68b on default MARC21 auth framework Ammended patch to delete tags 68a and 68b This patch deletes information for default MARC21 auth framework on tags 68a and 68b. Also added update for current installs. To test with current authorities_normal_marc21.sql loaded 1) apply the patch 2) run updatedatabase 3) check on database that there are no more references to tags 68a and 68b To test for new installs 1) remove auth frameworks 2) load authorities_normal_marc21.sql 3) check that load without problem 4) check on database that there are no more references to tags 68a and 68b Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: With reference to earlier comments about deleting tags. Works. Looks good to me. No complaints from qa tools. Fixed some 86s left in the commit message, Bernardo :) Note that we still have 68a and 68b now in some mysql translation folders. My personal opinion on that is that we should not put the burden to keep these translated files up-to-date on the shoulders of someone improving the English files. (In that regard I started a development with using an i18n function, but until now that did not raise a lot of enthusiasm yet :) ) If the RM agrees to push this one, we could open at least another report inviting the "language maintainers" to do their share while hoping for improvements in this area.. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This was missing a sign off when it got QA'd. I am switching back to 'needs signoff' so it gets on the radar of testers. Please switch to 'passed QA' if testing is successful. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-24 last check this| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21372|0 |1 is obsolete| | CC| |paola.rossi@cineca.it --- Comment #14 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 21442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21442&action=edit Delete erroneous tags 68a and 68b on default MARC21 auth framework The patch is signed off against 3.13.00.021 master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Paola Rossi <paola.rossi@cineca.it> --- I try to pass to QA passed status -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Paola Rossi from comment #15)
I try to pass to QA passed status
You can try, but I think that is for QA team to do :) (we can change to Failed QA, but not passed QA) Thank you for signing! I revert to Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Bernardo - Paola was right in this case to set Passed QA (see comment 13) :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 --- Comment #18 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Sorry Paola and thanks Katrin. I need to read better :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Exceptions... always a bit problematic :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #20 from Galen Charlton <gmcharlt@gmail.com> --- For what it's worth, I've figured out the origin of the 68a and 68b tags -- the authority frameworks try to merge the MARC21 authority and MARC21 classification formats. The MARC21 authority format had obsolete 685 and 686 tags, overlapping fields with those tags defined in the classification format. Whoever put together the original framework SQL created the 68a and 68b tags to reconcile this, but since 68a/68b fields would never get used in real life, I can't say I see the point of it. The MARC21 classification format is primary used by libraries that actually maintain classification schemes. Since the Library of Congress is not running Koha, I think it would be reasonable to remove all of the classification format tags from the MARC21 authority frameworks, or at the very least put them in their own auth_type. That would be a topic for another bug, of course. This is a long-winded way to say that I agree that the 68a and 68b tags should be removed. Since removing them from the translations of the frameworks SQL is essentially a mechanical operation, I'll push a follow-up that does exactly that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10687 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org