[Bug 10803] New: "Make payment" in circ is not easily translatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803 Bug ID: 10803 Summary: "Make payment" in circ is not easily translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org To test: - Choose a patron account - Add a fine to it - Switch to the checkout tab of the patron account - Check for the "Make payment" link. Make is not a link, but payment is. In translation this string is divided into: . %s Make payment Because of this it's difficult to translate it grammatically. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20726&action=edit Bug 10803: "Make payment" in circ is hard to translate in circulation To test: - Choose a patron account - Add a fine to it - Switch to the checkout tab of the patron account - Check for the "Make payment" link. Make is not a link, but payment is. - Apply patch - Check again, now both words are linked. In translation this string is divided into: . %s Make payment Because of this it's difficult to translate it grammatically. The patch moves 'Make' into the link text, so that both words will show up together in translation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20726|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21299&action=edit [SIGNED-OFF] Bug 10803: "Make payment" in circ is hard to translate in circulation To test: - Choose a patron account - Add a fine to it - Switch to the checkout tab of the patron account - Check for the "Make payment" link. Make is not a link, but payment is. - Apply patch - Check again, now both words are linked. In translation this string is divided into: . %s Make payment Because of this it's difficult to translate it grammatically. The patch moves 'Make' into the link text, so that both words will show up together in translation. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No koha-qa errors. Not only improves translatability, also corrects capitalization. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21299|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21415&action=edit Bug 10803: "Make payment" in circ is hard to translate in circulation To test: - Choose a patron account - Add a fine to it - Switch to the checkout tab of the patron account - Check for the "Make payment" link. Make is not a link, but payment is. - Apply patch - Check again, now both words are linked. In translation this string is divided into: . %s Make payment Because of this it's difficult to translate it grammatically. The patch moves 'Make' into the link text, so that both words will show up together in translation. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works as described. No koha-qa errors. Not only improves translatability, also corrects capitalization. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10803 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org