[Bug 12411] New: Encoding broken in the syspref template plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Bug ID: 12411 Summary: Encoding broken in the syspref template plugin Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org This will fix the encoding issues existing in 3.14 and 3.16. The issue still appear in master but is fixed by bug 11944. If you try to add non latin characters in a pref like OPACMySummaryNote or NoLoginInstructions, the display is broken. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28824&action=edit Bug 12411: Preferences values should be utf8 encoded Test plan: Fill OPACMySummaryNote or NoLoginInstructions with something like "éàç" and verify the display is broken. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi@cineca.it --- Comment #2 from Paola Rossi <paola.rossi@cineca.it> --- On master 3.17.00.007, without applying 12411 [and without applying 11944] the display is not broken. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Which sysprefs did you test? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 --- Comment #4 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Jonathan Druart from comment #3)
Which sysprefs did you test?
I've tested OPACMySummaryNote and NoLoginInstructions -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Without this patch, I filled "NoLoginInstructions" with "Hello éàç". Go on opac-user.pl and I see "Hello ���" Template 'en' and bootstrap theme. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Jonathan Druart from comment #5)
Without this patch, I filled "NoLoginInstructions" with "Hello éàç". Go on opac-user.pl and I see "Hello ���"
Template 'en' and bootstrap theme.
Today I've made some tests on master 3.17.00.008 without applying the patch. The cases I made were on both the two prefs. With the string "Something éàç", the behaviour of master was the one you said. I see: Something ��� On the contrary, with the string "Μαρωνίτης 実 éàç" I see no strange char. I see: Μαρωνίτης 実 éàç -------------------------------------------------------------------- éàç are all in [128:255], whilest the other chars are [256:+). -------------------------------------------------------------------- Afterwards I've applied the patch. Both the two cases were OK. So I've passed the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28824|0 |1 is obsolete| | --- Comment #7 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 29058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29058&action=edit Bug 12411: Preferences values should be utf8 encoded -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29058|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29112&action=edit Bug 12411 - Encoding broken in the syspref template plugin -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29112|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29113&action=edit Bug 12411 - Encoding broken in the syspref template plugin -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Jacek Ablewicz <abl@biblos.pk.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12683 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m, gmcharlt@gmail.com --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch should not be pushed to master (unless bug 11944 is not pushed until the 3.18 release). I cc Galen and Fridolin, RM for 3.16 and 3.14. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12052 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz, | |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #0)
This will fix the encoding issues existing in 3.14 and 3.16. The issue still appear in master but is fixed by bug 11944.
If you try to add non latin characters in a pref like OPACMySummaryNote or NoLoginInstructions, the display is broken.
(In reply to Jonathan Druart from comment #10)
This patch should not be pushed to master (unless bug 11944 is not pushed until the 3.18 release). I cc Galen and Fridolin, RM for 3.16 and 3.14.
Pushed to 3.16.x, will be in 3.16.13 Fridolin, you might want to add this to 3.14.x? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|liz@catalyst.net.nz | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14584 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12411 --- Comment #13 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org