[Bug 14524] New: Result list RSS feed broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Bug ID: 14524 Summary: Result list RSS feed broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When subscribing to a RSS feed from the OPAC result list, no results are shown for it. Tested with a dynamic bookmark in Firefox. Reason might be the use of |html instead of |url/uri as TT filter. Tested in 3.18.8 so far, but I think other versions are probably also affected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- Confirmed on current master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- ...and 3.20.1. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- I have this in the OPAC error log: [Mon Jul 13 13:07:02.090923 2015] [cgi:error] [pid 4481] [client 127.0.0.1:55102] AH01215: [Mon Jul 13 13:07:02 2015] opac-search.pl: Use of uninitialized value in split at /home/magnus/scripts/kohaclone/opac/opac-search.pl line 501. [Mon Jul 13 13:07:02.096514 2015] [cgi:error] [pid 4481] [client 127.0.0.1:55102] AH01215: [Mon Jul 13 13:07:02 2015] opac-search.pl: WARNING: query problem with ZOOM error 10014 "CCL parsing error" (addinfo: "Search word expected") from diag-set 'ZOOM' at /home/magnus/scripts/kohaclone/C4/Search.pm line 379. Not sure what is relevant. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14418 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14418 [Bug 14418] XSS Flaws in OPAC Interface -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Introduced by 14418. Since query_cgi contains something like "idx=kw&q=42", we should not use the uri filter. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 40974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40974&action=edit Bug 14524: Don't escape query_cgi with uri According to the doc, we should not escape query_cgi with the uri filter: http://www.template-toolkit.org/docs/manual/Filters.html#section_uri Since query_cgi can contains something like: "idx=kw&q=42", we should not escape the & char Test plan: 0/ Don't apply the patch 1/ Go on launch a search at the OPAC 2/ Click on the RSS icon 3/ You should arrive on opac-search.pl?idx%3Dkw%26q%3D42&count=50&sort_by=acqdate_dsc&format=rss2 The & has been escaped. 4/ Apply the patch 5/ Now you should get result and see an url correctly formatted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40974|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 40978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40978&action=edit Bug 14524: Don't escape query_cgi with uri According to the doc, we should not escape query_cgi with the uri filter: http://www.template-toolkit.org/docs/manual/Filters.html#section_uri Since query_cgi can contains something like: "idx=kw&q=42", we should not escape the & char Test plan: 0/ Don't apply the patch 1/ Go on launch a search at the OPAC 2/ Click on the RSS icon 3/ You should arrive on opac-search.pl?idx%3Dkw%26q%3D42&count=50&sort_by=acqdate_dsc&format=rss2 The & has been escaped. 4/ Apply the patch 5/ Now you should get result and see an url correctly formatted. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40978|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 41047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41047&action=edit [PASSED QA] Bug 14524: Don't escape query_cgi with uri According to the doc, we should not escape query_cgi with the uri filter: http://www.template-toolkit.org/docs/manual/Filters.html#section_uri Since query_cgi can contains something like: "idx=kw&q=42", we should not escape the & char Test plan: 0/ Don't apply the patch 1/ Go on launch a search at the OPAC 2/ Click on the RSS icon 3/ You should arrive on opac-search.pl?idx%3Dkw%26q%3D42&count=50&sort_by=acqdate_dsc&format=rss2 The & has been escaped. 4/ Apply the patch 5/ Now you should get result and see an url correctly formatted. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41047|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Attachment #41047|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #9 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.x will be in 3.18.09 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Doesn't seem to effect translations pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14524 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #11 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org