[Bug 9649] New: Replace YUI buttons on cataloging with Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9649 Bug ID: 9649 Summary: Replace YUI buttons on cataloging with Bootstrap Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/cataloguing/addbooks.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The toolbar buttons on the cataloging pages (addbooks.pl and addbiblio.pl) are constructed using YUI. They should use Bootstrap instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9649 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Replace YUI buttons on |Replace YUI buttons on |cataloging with Bootstrap |cataloging pages with | |Bootstrap -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9649 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Replace YUI buttons on |Replace YUI buttons on |cataloging pages with |cataloging home page with |Bootstrap |Bootstrap --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I thought addbooks.pl and addbiblio.pl shared a toolbar include. They do not, so I'm changing the scope of this bug to cover only addbooks.pl. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9649 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9649 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15564&action=edit Bug 9649 - Replace YUI buttons on cataloging home page with Bootstrap This patch converts the buttons on the cataloging home page to Bootstrap, replacing the YUI button and menu code with Bootstrap markup. This patch moves the functionality of cataloging-toolbar.inc into addbooks.tt since it is the only place where the include was used. cataloging-toolbar.inc is removed. To test, view the cataloging home page. Buttons and menus should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9649 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15564|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15593&action=edit [SIGNED-OFF] Bug 9649 - Replace YUI buttons on cataloging home page with Bootstrap This patch converts the buttons on the cataloging home page to Bootstrap, replacing the YUI button and menu code with Bootstrap markup. This patch moves the functionality of cataloging-toolbar.inc into addbooks.tt since it is the only place where the include was used. cataloging-toolbar.inc is removed. To test, view the cataloging home page. Buttons and menus should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Buttons look and work well. No errors. Please sign Bug 3549 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9649 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9649 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9649 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9649 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15593|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15835&action=edit [PASSED QA] Bug 9649 - Replace YUI buttons on cataloging home page with Bootstrap This patch converts the buttons on the cataloging home page to Bootstrap, replacing the YUI button and menu code with Bootstrap markup. This patch moves the functionality of cataloging-toolbar.inc into addbooks.tt since it is the only place where the include was used. cataloging-toolbar.inc is removed. To test, view the cataloging home page. Buttons and menus should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Buttons look and work well. No errors. Please sign Bug 3549 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9649 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org