[Bug 9450] New: Use DataTables in cataloging Z39.50 search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Bug ID: 9450 Summary: Use DataTables in cataloging Z39.50 search results Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The cataloging Z39.50 search results window uses the old tablesorter plugin. It should use the DataTables plugin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14761&action=edit Bug 9450 - Use DataTables in cataloging Z39.50 search results Replace the tablesorter plugin with the DataTables plugin in cataloging Z39.50 search results. Structural changes were made to the table markup to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, go to cataloging and perform a Z39.50 search. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14774&action=edit sort issue Owen, I don't know why this table is not sort correctly. Please see the screenshot. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #2)
I don't know why this table is not sort correctly.
I can't reproduce this problem. Is the problem only with that search, or with any? Is the problem only with title sort? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14761|0 |1 is obsolete| | --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 15085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15085&action=edit Bug 9450 - Use DataTables in cataloging Z39.50 search results Replace the tablesorter plugin with the DataTables plugin in cataloging Z39.50 search results. Structural changes were made to the table markup to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, go to cataloging and perform a Z39.50 search. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- I've signed off on the patch after testing. I was able to reproduce the title sorting issue that Jonathan saw (connecting to z3950.bnf.fr/TOUT, character encoding ISO 5426), but that problem also existed with the old tablesorter plugin and, in fact, has nothing to do with either jQuery plugin -- the sorting is thrown off by embedded NSB/NSE characters in the title. That's worth opening a separate bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15085|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15703&action=edit Bug 9450 [Revised] Use DataTables in cataloging Z39.50 search results Replace the tablesorter plugin with the DataTables plugin in cataloging Z39.50 search results. Structural changes were made to the table markup to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, go to cataloging and perform a Z39.50 search. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15703|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15747&action=edit [SIGNED-OFF] Bug 9450 [Revised] Use DataTables in cataloging Z39.50 search results Replace the tablesorter plugin with the DataTables plugin in cataloging Z39.50 search results. Structural changes were made to the table markup to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, go to cataloging and perform a Z39.50 search. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9747 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: I got the sort issue but as Galen said it caused by the NSB/NSE characters (\x88Les \x89). I opened a new bug (bug 9747). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15747|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15885&action=edit Bug 9450 [Revised] Use DataTables in cataloging Z39.50 search results Replace the tablesorter plugin with the DataTables plugin in cataloging Z39.50 search results. Structural changes were made to the table markup to deal with a DataTables bug which prevents it from properly parsing a <th> with a colspan. To test, go to cataloging and perform a Z39.50 search. Confirm that table sorting works correctly. In this configuration there should be no pager and no results filtering. Revision corrects template path to datatables assets. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Sorting works. No errors. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9747 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9450 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org