[Bug 24515] New: Column Configuration for pay-fines-table does not hide Account Type properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 Bug ID: 24515 Summary: Column Configuration for pay-fines-table does not hide Account Type properly Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In the Patron set of the Column Configuration under Pay-Fines-Table, checking to hide the "account type" field does not hide the "Account Type" in pay.pl. If "Account Type" and "Description" are both chosen, it will hide the "account type" in pay.pl but not the "description". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 97931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97931&action=edit Bug 24515: Column Configuration for pay-fines-table does not hide Account Type properly This patch corrects the order of the columns in the columns configuration YML file. The incorrect order was causing the wrong column to be hidden when changing the columns settings for the table in Administration. To test, apply the patch and go to Administration -> Columns settings. - Under Patrons -> pay-fines-table, test hiding the account_type and description columns, together and separately. - Verify that the correct columns are hidden on the pay fines screen (Patron -> Accounting -> Make a payment) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97931|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 97933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97933&action=edit Bug 24515: Column Configuration for pay-fines-table does not hide Account Type properly This patch corrects the order of the columns in the columns configuration YML file. The incorrect order was causing the wrong column to be hidden when changing the columns settings for the table in Administration. To test, apply the patch and go to Administration -> Columns settings. - Under Patrons -> pay-fines-table, test hiding the account_type and description columns, together and separately. - Verify that the correct columns are hidden on the pay fines screen (Patron -> Accounting -> Make a payment) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97933|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 97940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97940&action=edit Bug 24515: Column Configuration for pay-fines-table does not hide Account Type properly This patch corrects the order of the columns in the columns configuration YML file. The incorrect order was causing the wrong column to be hidden when changing the columns settings for the table in Administration. To test, apply the patch and go to Administration -> Columns settings. - Under Patrons -> pay-fines-table, test hiding the account_type and description columns, together and separately. - Verify that the correct columns are hidden on the pay fines screen (Patron -> Accounting -> Make a payment) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x. for 19.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24515 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24891 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org