[Bug 29073] New: Hold expiration added to new holds when DefaultHoldExpirationdate turned off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073 Bug ID: 29073 Summary: Hold expiration added to new holds when DefaultHoldExpirationdate turned off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: nick@bywatersolutions.com Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 26498 to recreate: - turn on DefaultHoldExpirationdate, place a hold, confirm it has an expiration date - turn off DefaultHoldExpirationdate, place a hold, confirm it still has an expirtion date we're saving "no" rather than 0, which is breaking checks further along. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 [Bug 26498] Add option to set a default expire date for holds at reservation time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125111&action=edit Bug 29073: Use 0 and 1 as values for DefaultHoldExpirationdate DefaultHldexpirationDate is set in the pref screen to 'yes/no' The code checks if the preference is 'true', 'no' is true We should instead use 1/0 To test: 0 - Have a fresh devbox 1 - With syspref disabled, place a hold 2 - Note no expiration date set 3 - Enable the preference 4 - Place a hold and note the expiration date is set, good 5 - Disable the pref 6 - Place a hold and note the expiration date is set, bad 7 - Apply patch 8 - Update database 9 - Repeat 1-8, date not set when pref disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125111|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 125113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125113&action=edit Bug 29073: Use 0 and 1 as values for DefaultHoldExpirationdate DefaultHldexpirationDate is set in the pref screen to 'yes/no' The code checks if the preference is 'true', 'no' is true We should instead use 1/0 To test: 0 - Have a fresh devbox 1 - With syspref disabled, place a hold 2 - Note no expiration date set 3 - Enable the preference 4 - Place a hold and note the expiration date is set, good 5 - Disable the pref 6 - Place a hold and note the expiration date is set, bad 7 - Apply patch 8 - Update database 9 - Repeat 1-8, date not set when pref disabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125113|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125264&action=edit Bug 29073: Use 0 and 1 as values for DefaultHoldExpirationdate DefaultHldexpirationDate is set in the pref screen to 'yes/no' The code checks if the preference is 'true', 'no' is true We should instead use 1/0 To test: 0 - Have a fresh devbox 1 - With syspref disabled, place a hold 2 - Note no expiration date set 3 - Enable the preference 4 - Place a hold and note the expiration date is set, good 5 - Disable the pref 6 - Place a hold and note the expiration date is set, bad 7 - Apply patch 8 - Update database 9 - Repeat 1-8, date not set when pref disabled Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Doh! Well spotted, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 26498 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org