https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29073 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 125111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125111&action=edit Bug 29073: Use 0 and 1 as values for DefaultHoldExpirationdate DefaultHldexpirationDate is set in the pref screen to 'yes/no' The code checks if the preference is 'true', 'no' is true We should instead use 1/0 To test: 0 - Have a fresh devbox 1 - With syspref disabled, place a hold 2 - Note no expiration date set 3 - Enable the preference 4 - Place a hold and note the expiration date is set, good 5 - Disable the pref 6 - Place a hold and note the expiration date is set, bad 7 - Apply patch 8 - Update database 9 - Repeat 1-8, date not set when pref disabled -- You are receiving this mail because: You are watching all bug changes.