[Bug 20969] New: Use modal to add and edit notes from basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Bug ID: 20969 Summary: Use modal to add and edit notes from basket Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Created attachment 76211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76211&action=edit Screenshot showing note edit form in modal When looking at orders in a basket, each order has links to add or edit vendor and internal notes. I propose that we move a copy of the notes edit form to the basket template so that a modal can be used to edit notes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76212&action=edit Bug 20969: Use modal to add and edit notes from basket This patch modifies the acquisitions basket page so that links to add or edit vendor or internal notes trigger a modal with the notes edit form instead of redirecting to a different page. This is a markup change only -- The form still submits to modordernotes.pl. To test, apply the patch and view a basket in acquisitions which has multiple orders. Test various note controls: Add internal note, Add vendor note, Edit internal note, edit vendor note. Confirm that the operations work correctly with multiple orders in the basket. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Would it be possible to put the focus in the new input field after clicking on the link? I think it would improve usability to immediately allow typing the note instead of having to click again. But I notice it's the same for the message modal on the patron record. 2) Do you plan on changing the links on the parcel.pl page too? (new bug?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76212|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76422&action=edit Bug 20969: Use modal to add and edit notes from basket This patch modifies the acquisitions basket page so that links to add or edit vendor or internal notes trigger a modal with the notes edit form instead of redirecting to a different page. This is a markup change only -- The form still submits to modordernotes.pl. To test, apply the patch and view a basket in acquisitions which has multiple orders. Test various note controls: Add internal note, Add vendor note, Edit internal note, edit vendor note. Confirm that the operations work correctly with multiple orders in the basket. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 76438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76438&action=edit Bug 20969: (follow-up) Move focus to textarea whe modal is shown This follow-up adds code to move the mouse cursor to the modal window's textarea when the modal is displayed. To test, apply the patch and test the process of adding/editing notes on an order. Confirm that the focus moves to the textarea when the note editor modal window is shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76438|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76474&action=edit Bug 20969: (follow-up) Move focus to textarea whe modal is shown This follow-up adds code to move the mouse cursor to the modal window's textarea when the modal is displayed. To test, apply the patch and test the process of adding/editing notes on an order. Confirm that the focus moves to the textarea when the note editor modal window is shown. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21004 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76422|0 |1 is obsolete| | --- Comment #7 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 76595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76595&action=edit Bug 20969: Use modal to add and edit notes from basket This patch modifies the acquisitions basket page so that links to add or edit vendor or internal notes trigger a modal with the notes edit form instead of redirecting to a different page. This is a markup change only -- The form still submits to modordernotes.pl. To test, apply the patch and view a basket in acquisitions which has multiple orders. Test various note controls: Add internal note, Add vendor note, Edit internal note, edit vendor note. Confirm that the operations work correctly with multiple orders in the basket. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76595|0 |1 is obsolete| | --- Comment #8 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 76596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76596&action=edit Bug 20969: Use modal to add and edit notes from basket This patch modifies the acquisitions basket page so that links to add or edit vendor or internal notes trigger a modal with the notes edit form instead of redirecting to a different page. This is a markup change only -- The form still submits to modordernotes.pl. To test, apply the patch and view a basket in acquisitions which has multiple orders. Test various note controls: Add internal note, Add vendor note, Edit internal note, edit vendor note. Confirm that the operations work correctly with multiple orders in the basket. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76474|0 |1 is obsolete| | --- Comment #9 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 76597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76597&action=edit Bug 20969: (follow-up) Move focus to textarea whe modal is shown This follow-up adds code to move the mouse cursor to the modal window's textarea when the modal is displayed. To test, apply the patch and test the process of adding/editing notes on an order. Confirm that the focus moves to the textarea when the note editor modal window is shown. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Charles Farmer <charles.farmer@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |charles.farmer@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Reganing my QA token with Charles' additional sign-off - switching this to PQA.off I -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, not backporting to the 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org