[Bug 20731] New: Move template JavaScript to the footer: Call number browser MARC plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20731 Bug ID: 20731 Summary: Move template JavaScript to the footer: Call number browser MARC plugin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for the call number browser plugin. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20731 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20731 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75183&action=edit Bug 20731: Move template JavaScript to the footer: Call number browser MARC plugin This patch modifies the call number browser plugin so that JavaScript is in the footer instead of the header. This patch also makes some unrelated changes: The page title has been corrected; DataTables code has been removed as it was unused. To test, apply the patch and configure a MARC framework to use cn_browser.pl as the plugin for tag 952 subfield o. Open an item for editing. The "Full call number" field should have an active "..." link next to it. Clicking this should trigger a popup window with the Call number browser. Confirm that submitting a new search from this window works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20731 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20731 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75183|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 75255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75255&action=edit Bug 20731: Move template JavaScript to the footer: Call number browser MARC plugin This patch modifies the call number browser plugin so that JavaScript is in the footer instead of the header. This patch also makes some unrelated changes: The page title has been corrected; DataTables code has been removed as it was unused. To test, apply the patch and configure a MARC framework to use cn_browser.pl as the plugin for tag 952 subfield o. Open an item for editing. The "Full call number" field should have an active "..." link next to it. Clicking this should trigger a popup window with the Call number browser. Confirm that submitting a new search from this window works correctly. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20731 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20731 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75255|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 75718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75718&action=edit Bug 20731: Move template JavaScript to the footer: Call number browser MARC plugin This patch modifies the call number browser plugin so that JavaScript is in the footer instead of the header. This patch also makes some unrelated changes: The page title has been corrected; DataTables code has been removed as it was unused. To test, apply the patch and configure a MARC framework to use cn_browser.pl as the plugin for tag 952 subfield o. Open an item for editing. The "Full call number" field should have an active "..." link next to it. Clicking this should trigger a popup window with the Call number browser. Confirm that submitting a new search from this window works correctly. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20731 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20731 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, not backporting to 18.05.x series -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org