[Bug 41569] New: Tidy kohaTable block - clubs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Bug ID: 41569 Summary: Tidy kohaTable block - clubs Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41324 Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |jonathan.druart@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 [Bug 41324] Tidy kohaTable block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191124&action=edit Bug 41569: Tidy kohaTable - clubs/patron-clubs-tab.tt Patch from commit 2ae2710 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191125&action=edit Bug 41569: Tidy kohaTable - clubs/clubs-tab.tt Patch from commit 1abd193 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191126&action=edit Bug 41569: clubs - auto tidy Patch from commit 679a79e -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39715 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39715 [Bug 39715] Do not quote DataTables options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191124|0 |1 is obsolete| | Attachment #191125|0 |1 is obsolete| | Attachment #191126|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191572&action=edit Bug 41569: Tidy kohaTable - clubs/patron-clubs-tab.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191573&action=edit Bug 41569: Tidy kohaTable - clubs/clubs-tab.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191574&action=edit Bug 41569: clubs - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191575&action=edit Bug 41569: (follow-up) Prevent variable redeclaration warnings Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191574|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191575|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194643&action=edit Bug 41569: clubs - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194644&action=edit Bug 41569: (follow-up) Prevent variable redeclaration warnings Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194643|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194644|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194649&action=edit Bug 41569: Fix conflict with 39698 Patch from commit 1ca0c52 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194650&action=edit Bug 41569: clubs - auto tidy Patch from commit 7070fee -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 194651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194651&action=edit Bug 41569: (follow-up) Prevent variable redeclaration warnings Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191572|0 |1 is obsolete| | --- Comment #13 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194683&action=edit Bug 41569: Tidy kohaTable - clubs/patron-clubs-tab.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191573|0 |1 is obsolete| | --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194684&action=edit Bug 41569: Tidy kohaTable - clubs/clubs-tab.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194649|0 |1 is obsolete| | --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194685&action=edit Bug 41569: Fix conflict with 39698 Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194650|0 |1 is obsolete| | --- Comment #16 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194686&action=edit Bug 41569: clubs - auto tidy Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194651|0 |1 is obsolete| | --- Comment #17 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194687&action=edit Bug 41569: (follow-up) Prevent variable redeclaration warnings Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 --- Comment #18 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194688&action=edit Bug 41569: (QA follow-up) Fix missing preventDefault() call - e.preventDefault was missing parentheses, so the default action was never actually prevented - The element is an <a href="#"> link, so clicking it would cause the page to scroll to top Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de Attachment #194688|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195162&action=edit Bug 41569: (follow-up) Fix conflict with 39698 Patch from commit 4b633fc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #19)
Created attachment 195162 [details] [review] Bug 41569: (follow-up) Fix conflict with 39698
Patch from commit 4b633fc
The previous patch should have had that! No idea how it got lost. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41569 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |jacob.omara@openfifth.co.uk --- Comment #22 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Enhancement, not backporting. Scream at me if you feel strongly it should be backported. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org