[Bug 41571] New: Tidy kohaTable block - labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 Bug ID: 41571 Summary: Tidy kohaTable block - labels Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41324 Status|NEW |ASSIGNED QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41324 [Bug 41324] Tidy kohaTable block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191130&action=edit Bug 41571: Tidy kohaTable - labels/label-edit-batch.tt Patch from commit c51b71b -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191131&action=edit Bug 41571: Tidy kohaTable - labels/label-manage.tt Patch from commit a302520 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191132&action=edit Bug 41571: labels - auto tidy Patch from commit 7f86593 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191130|0 |1 is obsolete| | Attachment #191131|0 |1 is obsolete| | Attachment #191132|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191407&action=edit Bug 41571: Tidy kohaTable - labels/label-edit-batch.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191408&action=edit Bug 41571: (follow-up) Remove unused function The selected_layout function is defined but never called. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 191409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191409&action=edit Bug 41571: labels - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191407|0 |1 is obsolete| | --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194704&action=edit Bug 41571: Tidy kohaTable - labels/label-edit-batch.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191408|0 |1 is obsolete| | --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194705&action=edit Bug 41571: (follow-up) Remove unused function The selected_layout function is defined but never called. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191409|0 |1 is obsolete| | --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194706&action=edit Bug 41571: labels - auto tidy Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 194707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194707&action=edit Bug 41571: (QA follow-up) Rename shadowing batch_id variables - The top-level const batch_id (from TT) is shadowed by var batch_id inside the .export and #savedesc click handlers - This works correctly now but is confusing and error-prone if the code is later refactored - Rename to export_batch_id and save_batch_id respectively to make the intent clear Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41571 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jacob.omara@openfifth.co.uk Status|Pushed to main |Needs documenting --- Comment #12 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Enhancement, not backporting. Scream at me if you feel strongly it should be backported. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org