https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165491&action=edit Bug 36694: Remove HC sticky from acqui/supplier.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165493&action=edit Bug 36694: Add JS observer to detect stuck sticky element -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165584&action=edit Bug 36694: Remove HC sticky from preferences.tt/authorities.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165680&action=edit Bug 36694: Remove HC stikcy from cataloguing/ pages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165683&action=edit Bug 36694: Remove HC sticky from remaining staff pages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36693 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36693 [Bug 36693] Improve floating toolbar in OPAC search results -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165489|0 |1 is obsolete| | --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165756&action=edit Bug 36694: Remove HC sticky from patron search searchbar -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165493|0 |1 is obsolete| | --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165758&action=edit Bug 36694: Add JS observer to detect stuck sticky element -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165582|0 |1 is obsolete| | --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165760&action=edit Bug 36694: Remove HC sticky from acqui/supplier.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165587|0 |1 is obsolete| | --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165762&action=edit Bug 36694: Remove HC sticky from catalogue/ pages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165682|0 |1 is obsolete| | --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165764&action=edit Bug 36694: Remove HC sticky from members/ pages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165684|0 |1 is obsolete| | --- Comment #26 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165766&action=edit Bug 36694: Remove HC sticky from OPAC pages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #29 from David Nind <david@davidnind.com> --- I've listed the things that didn't work as expected, or that I'm not sure of (more details below under the respective headings): 1. Patron search: landing page (without any searches) doesn't display the toolbar above the browse by last name area. 2. Patron permissions page: the wrong toolbar is displayed when scrolling (normal edit patron toolbar, instead of the permissions toolbar). 3. Patron information: when you add new patrons, or edit existing patrons, the toolbar does not stick. 4. Authority search: The only place I could see where the toolbar is sticky is when adding or editing authorities. I didn't see any sticky toolbar when searching and on the search results page. Things noted that are different or not working as expected ========================================================== 3. Patron search: with patch applied, the "Sticky" menu isn't displayed when you go to the patron landing page - it just displays Browse by last name: A, B, C, etc. Before the patch it included a toolbar with Select all, clear all, greyed out options for adding to list, merging, etc. Once there are results, this toolbar is displayed. 12. Patron permissions page: Patrons > Search (from filters to the left) > select any patron > More > Set permissions > scroll down the page. The sticky toolbar is the wrong one - it is the normal patron actions (Edit - Change password - Duplicate - etc.). Before the patch it was the permissions toolbar (Save - Cancel - Show all - etc.). 13. Patron information: . Add or edit a patron (memberentry): Patrons > + New patron > Patron > scroll down. Result: The toolbar DOES NOT STICK as you scroll down (for both add and edit). It did before the patch was applied. Things I'm not sure of ====================== 7. Authority search: Authorities > click submit button in header. Result: search results displayed. NO sticker toolbar when scrolling down the page. The only place I could find the sticky working before and after the patch was when adding or editing an authority. Worked as expected ================== 3. Patron search: Patrons > click Search. Result: all patrons listed, toolbar sticks as you scroll down. 4. Acquisitions - add a vendor: Acquisitions > + New vendor. Result: new vendor form displayed, toolbar sticks as you scroll down. 5. Acquisitions - add a basket: . Acquisitions > Mange orders section > Search. Result: list of orders for "My Vendor" displayed. . + New > Basket > add a basket name > Save. Result: Page for the basket displayed. . Scroll down the page. Result: toolbar sticks as you scroll down. 6. System preferences: Administration > System preferences > select OPAC > scroll down. Result: toolbar sticks as you scroll down. 8. Advanced search: Search (in toolbar at top) > Advanced search > scroll down. Result: toolbar sticks as you scroll down. 9. Item search: Search (in toolbar at top) > Item search > scroll down. Result: toolbar bar sticks as you scroll down. NOTE: Before the patch the toolbar didn't stick. 10. Catalog search: select 'Search catalog' in the header, enter a search term, press the submit button/arrow, and scroll down on the results page. Result: The toolbar sticks as you scroll down. 11. Add a bibliographic record, or edit one: Cataloging > + New record, and then scroll down. Result: The toolbar sticks as you scroll down. 12. Patron information: . Patron details page (moremembers): Patrons > Search > Select a patron > Details. Result: toolbar sticks as you scroll down. (Note: the toolbar did not stick for me before the patch.) . Patron check out page: Patrons > Search > Select a patron > Check out. Result: toolbar sticks as you scroll down. (Note: the toolbar did not stick for me before the patch.) . Other sections: Add some data (if required) for each of the other sections - accounting, routing lists, circulation history, holds history, modification log (if you have some entries, such as check outs and check ins, the table header stays at the top of the page), notices, statistics, purchase suggestions (something is not quite right with this screen for adding new purchase suggestions - no entry form - but I don't think it is related to this bug; if you add a purchase suggestion via acquistions, the list of suggestions displays and the normal patron menu is sticky). Result: toolbar sticks as you scroll down. 14. Place multiple holds on a record: For any record from the normal view, click 'Place hold'. Add holds for multiple patrons. Result: Under the 'Existing holds' section, the toolbar sticks as you scroll down. 15. HTML customizations: Tools > Additional tools > HTML customizations. Add a new customization (+New entry). Edit a customization - select 'Edit' under actions for an existing entry. Select pages, then + New entry. Select pages, then + New entry. Results: toolbars stick as you scroll down. 16. Cataloging > Automatic item modifications by age. Add a rule, then edit rules. The toolbar should stick. Result: toolbar sticks as you scroll down. 17. Edit a notice, expand an area (such as Email), and scroll down. The toolbar should stick. Result: toolbar sticks as you scroll down. 18. Tools > Log viewer > Submit. Under Log entries, the toolbar should stick. Result: toolbar sticks as you scroll down. 19. Lists: Create some lists and add several items to them. Toolbar should be sticky when you scroll down the items in the list. Result: toolbar sticks as you scroll down. 20. Add many items to an OPAC cart. Make sure the toolbar sticks. Result: toolbar sticks as you scroll down. 21. Try the OPAC results, the toolbar should stick. Result: toolbar sticks as you scroll down. 22. Add many items to a list, on the OPAC list display the toolbar should stick. Result: toolbar sticks as you scroll down. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #31 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Nind from comment #29)

1. Patron search: landing page (without any searches) doesn't display the toolbar above the browse by last name area.

If the toolbar displays when there are results I think this is actually the desired outcome. I think it was a bug that the toolbar displayed before results were shown.

4. Authority search: I didn't see any sticky toolbar when searching and on the search results page.

I think that's the same as in main. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165757|0 |1 is obsolete| | --- Comment #33 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166704&action=edit Bug 36694: Remove HC sticky from acqui/basket.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165759|0 |1 is obsolete| | --- Comment #35 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166706&action=edit Bug 36694: Set sticky element top to -1px -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165761|0 |1 is obsolete| | --- Comment #37 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166708&action=edit Bug 36694: Remove HC sticky from preferences.tt/authorities.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165763|0 |1 is obsolete| | --- Comment #39 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166710&action=edit Bug 36694: Remove HC stikcy from cataloguing/ pages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165765|0 |1 is obsolete| | --- Comment #41 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166712&action=edit Bug 36694: Remove HC sticky from remaining staff pages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165767|0 |1 is obsolete| | --- Comment #43 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166714&action=edit Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #46 from David Nind <david@davidnind.com> --- (In reply to Lucas Gass from comment #45)

I've addressed David's findings and have reset this to NSO.

Thanks Lucas! I just re-tested the things I noted with potential issues. With the patron permissions page: - The correct toolbar is now shown - However: . the Show all/Hide all buttons on the toolbar don't seem to be working now . the "Show details" link/button in the page doesn't expand to show the permission details -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #48 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166940&action=edit Bug 36694: (follow-up) Remove Sticky JS from member-flags.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #50 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Do we reserve enhancement severity for functional stuff. Or do refactoring that don't fix any bug are also enhancements? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Victor Grousset/tuxayo from comment #50)

Do we reserve enhancement severity for functional stuff. Or do refactoring that don't fix any bug are also enhancements?

I'd say that something not fixing a bug would be an enhancement, also refactorings might not be suitable for backporting unless needed for other patches. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement --- Comment #54 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Ok, switching severity :) (In reply to Victor Grousset/tuxayo from comment #49)

QA notes.

In koha-tmpl/opac-tmpl/bootstrap/css/src/_common.scss 88:// Sticky footer styles

It's not related to this. (took long to confirm >_<)

BTW, I meant that this is a remaining thing and that it's not a problem because it's not about HC Sticky -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166703|0 |1 is obsolete| | --- Comment #55 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 167507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167507&action=edit Bug 36694: Remove HC sticky from patron search searchbar -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166705|0 |1 is obsolete| | --- Comment #57 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 167509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167509&action=edit Bug 36694: Add JS observer to detect stuck sticky element -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166707|0 |1 is obsolete| | --- Comment #59 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 167511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167511&action=edit Bug 36694: Remove HC sticky from acqui/supplier.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166709|0 |1 is obsolete| | --- Comment #61 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 167513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167513&action=edit Bug 36694: Remove HC sticky from catalogue/ pages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166711|0 |1 is obsolete| | --- Comment #63 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 167515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167515&action=edit Bug 36694: Remove HC sticky from members/ pages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166713|0 |1 is obsolete| | --- Comment #65 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 167517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167517&action=edit Bug 36694: Remove HC sticky from OPAC pages Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166715|0 |1 is obsolete| | --- Comment #67 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 167519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167519&action=edit Bug 36694: (follow-up): fix pages where toolbar was not sticky -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #69 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Rebased. (compared the diffs with the rebased version of the conflicting commit and the original to double check that the rebase didn't introduce unwanted changes) There is still comment 49 though. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #71 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Victor Grousset/tuxayo from comment #69)

There is still comment 49 though.

I think my follow-up takes care of those, but I'm leaving this as Failed QA because of an issue I saw with acqui/basket.tt. The sticky toolbar works fine until it gets to the sticky header on the DataTable. In Firefox the result is a weird jittery effect where you can't scroll down. In Chromium there's not the jittery effect but the sticky toolbar overlaps the sticky DataTable header. I assume we'll see this issue on any page that combines a sticky toolbar and a sticky DataTable header. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau@gmail.com --- Comment #73 from Sam Lau <samalau@gmail.com> --- Tested and works for me in both Chrome and Safari. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #75 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Hey I still get the same results without the patches! :o Double checked on a sandbox. And on a 23.11 demo. And it doesn't happen in a 22.11 demo. How weird that such a specific behavior wouldn't be changed. Anyway, ready for signoff I guess. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #78 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167824&action=edit Bug 36694: Remove HC sticky from acqui/basket.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #80 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167826&action=edit Bug 36694: Set sticky element top to -1px Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #82 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167828&action=edit Bug 36694: Remove HC sticky from preferences.tt/authorities.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #84 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167830&action=edit Bug 36694: Remove HC stikcy from cataloguing/ pages Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #86 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167832&action=edit Bug 36694: Remove HC sticky from remaining staff pages Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #88 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167834&action=edit Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #90 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167836&action=edit Bug 36694: (follow-up) Remove Sticky JS from member-flags.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #92 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #71)

In Firefox the result is a weird jittery effect where you can't scroll down.

Today I observed this behavior in main so I guess that's just a thing! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167824|0 |1 is obsolete| | --- Comment #94 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 169111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169111&action=edit Bug 36694: Remove HC sticky from acqui/basket.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167826|0 |1 is obsolete| | --- Comment #96 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 169113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169113&action=edit Bug 36694: Set sticky element top to -1px Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167828|0 |1 is obsolete| | --- Comment #98 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 169115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169115&action=edit Bug 36694: Remove HC sticky from preferences.tt/authorities.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167830|0 |1 is obsolete| | --- Comment #100 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 169117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169117&action=edit Bug 36694: Remove HC stikcy from cataloguing/ pages Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167832|0 |1 is obsolete| | --- Comment #102 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 169119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169119&action=edit Bug 36694: Remove HC sticky from remaining staff pages Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167834|0 |1 is obsolete| | --- Comment #104 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 169121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169121&action=edit Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167836|0 |1 is obsolete| | --- Comment #106 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 169123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169123&action=edit Bug 36694: (follow-up) Remove Sticky JS from member-flags.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #108 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 169125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169125&action=edit Bug 36694: Remove HC sticky from js/results-list.js It got moved there by bug-36557 after the patches here were written. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #110 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick.

moremember.pl, circulation.pl => nope but neither on main Was there something about this or can this be skipped? ---- Additional testing: - marc21_field_008 cataloguing plugin - label batch content - patron card creator batch content -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #112 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171081&action=edit Bug 36694: Remove HC sticky from acqui/basket.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #114 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171083&action=edit Bug 36694: Set sticky element top to -1px Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #116 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171085&action=edit Bug 36694: Remove HC sticky from preferences.tt/authorities.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #118 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171087&action=edit Bug 36694: Remove HC stikcy from cataloguing/ pages Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #120 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171089&action=edit Bug 36694: Remove HC sticky from remaining staff pages Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #122 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171091&action=edit Bug 36694: Remove remaining HC stick assets To test: 1. Apply patch and regenrate CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) 2. You'll need to check that the 'sticky' header still sticks on each of these pages. 3. Do a patron search, the toolbar should stick as you scroll down. 4. In Acquisitions, Add a vendor. The toolbar should stick as you scroll down. 5. In Acquisitions, Add a basket. The toolbar should stick as you scroll down. 6. Search for a system pref, or go directly to the OPAC category ( http://localhost:8081/cgi-bin/koha/admin/preferences.pl?tab=opac ). The toolbar should stick as you scroll down. 7. Do an authorties search. The toolbar should stick as you scroll down. 8. Go to advanced search. Without doing a search the toolbard should stick as you scroll down. 9. Go to item search. Without doing a search the toolbard should stick as you scroll down. 10. Do a catlog search. The toolbar should stick as you scroll down. 11. Add a bibliographic record, or edit one. The toolbar should stick as you scroll down. 12. Find a patron and go to the permissions page. The toolbar should stick as you scroll down. 13. Try each of the other members pages like memberentry.pl, moremember.pl, circulation.pl. On each of the pages the toolbar should stick. 14. Place multiple holds on a record. From reserve/request.pl the toolbar underneath 'Existing holds' should stick. 15. Edit a HTML customization, new item, and page. The toolbar should stick. 16. Cataloging > Automatic item modifications by age > Edit rules. The toolbar should stick. 17. Edit a notice, the toolbar should stick. 18. Tools > Log viewer > Submit. UNder Log entries, the toolbar should stick. 19. Create some lists and make sure the toolbar sticks. OPAC: 20. Add many items to an OPAC cart. Make sure the toolbar sticks. 21. Try the OPAC results, the toolbar should stick 22. Add many items to a list, on the OPAC list display the toolbar should stick. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #124 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171093&action=edit Bug 36694: (follow-up) Remove Sticky JS from member-flags.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #126 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171095&action=edit Bug 36694: Remove HC sticky from js/results-list.js It got moved there by bug-36557 after the patches here were written. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | --- Comment #127 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I think the only remaining thing to get to passed QA is the finding in Comment 110. Whether there is still something to test in moremember.pl and circulation.pl. Or maybe there is a regression that broke the stickiness in these pages after the test plan here was written. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171080|0 |1 is obsolete| | --- Comment #129 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 171852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171852&action=edit Bug 36694: Remove HC sticky from patron search searchbar Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171082|0 |1 is obsolete| | --- Comment #131 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 171854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171854&action=edit Bug 36694: Add JS observer to detect stuck sticky element Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171084|0 |1 is obsolete| | --- Comment #133 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 171856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171856&action=edit Bug 36694: Remove HC sticky from acqui/supplier.tt Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171086|0 |1 is obsolete| | --- Comment #135 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 171858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171858&action=edit Bug 36694: Remove HC sticky from catalogue/ pages Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171088|0 |1 is obsolete| | --- Comment #137 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 171860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171860&action=edit Bug 36694: Remove HC sticky from members/ pages Signed-off-by: Owen Leonard <oleonard@myacpl.org> Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171090|0 |1 is obsolete| | --- Comment #139 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 171862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171862&action=edit Bug 36694: Remove HC sticky from OPAC pages Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171092|0 |1 is obsolete| | --- Comment #141 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 171864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171864&action=edit Bug 36694: (follow-up): fix pages where toolbar was not sticky Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171094|0 |1 is obsolete| | --- Comment #143 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 171866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171866&action=edit Bug 36694: (follow-up) Remove some missed instances This patch removes some missed HCSticky code/mentions as well as the entry on the About page. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #145 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Owen Leonard from comment #128)

Since those templates are unchanged and there have never been floating toolbars on those pages I think there is nothing to test on those pages.

Great, no issue then! :D Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #147 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

Didn't we have both the "search header" (select all, etc.) and the table header (thead) sticky at some point?

Good finding! confirmed for 22.11, 23.05, 23.11 main, 24.05 doesn't have it. opened bug 37992 since it's not caused by removal of HC Sticky -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #148 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Removes the hc-sticky.js |This enhancement removes release notes|assets from Koha which were |the hc-sticky.js assets |used to make certain HTML |from Koha which were used |elements "sticky". The |to make certain HTML |functionality is now |elements "sticky". The |accomplished using only |functionality is now |CSS. |accomplished using only | |CSS. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 --- Comment #149 from Jonathan Druart <jonathan.druart@gmail.com> --- Please follow-up on bug 37992. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36694 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38620 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38620 [Bug 38620] Non-existent hc-sticky asset included in opac-tags -- You are receiving this mail because: You are watching all bug changes.