[Bug 21821] New: We should bundle and up to date RangeMessage.xml for Business::ISBN
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 Bug ID: 21821 Summary: We should bundle and up to date RangeMessage.xml for Business::ISBN Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Business::ISBN::Data isn't especially maintained and suggests using an up to date RangeMessage.xml file from https://www.isbn-international.org/range_file_generation. We should bundle a more up to date RangeMessage file with koha and set the appropriate environment in both plack and apache to point to the bundled version. This would help with new ISBN's that are not yet in the shipped Business::ISBN::Data package. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20244 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|We should bundle and up to |We should bundle an up to |date RangeMessage.xml for |date RangeMessage.xml for |Business::ISBN |Business::ISBN -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- In a mojo app I once build I had the followup in a bootstrap routine at application startup. # Ensure we're using an up to date set of data in Business::ISBN my $ISBN_RANGE_FILE = $app->home->rel_file('lib/Business/ISBN/RangeMessage.xml'); $ENV{'ISBN_RANGE_MESSAGE'} = "$ISBN_RANGE_FILE"; We could add similar to the plack start script and a SetEnv to the apache configs based on where we chose to store the file.. To keep this file up to date, I would envisage part of the release workflow being the download and replacement of the RangeMessage file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14287 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13192 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35729 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35755 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- I can confirm that this can fix a problem where ISBNs are not handled correctly by Business::ISBN, leading to fewer coverimages being shown in the OPAC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This sounds logical, what is required for bundling the newer file exactly? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42419 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Business::ISBN::Data has been better maintained in recent times, but we don't necessarily get those updates flowing through into Debian/Ubuntu. As per bug 42419, I also found a bug in Business::ISBN::Data, which has now been patched, so packaging an upgraded version could be good. But having an updated RangeMessage.xml would be good too. Technically, if we put it in /etc/default/koha-common then we could export it in /usr/sbin/koha-plack. I suppose there are times it would be good to have it in Apache though (for CGI scripts that aren't handled by Plack at the moment) -- Actually, couldn't we just pass it from the Apache using the Koha::Middleware::SetEnv? That might be the easiest way to do it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- I had a library recently that needed an upgraded version of Business::ISBN::Data and instead of doing the ISBN_RANGE_MESSAGE, I just upgraded the module, but it would be good to do both I think... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21821 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org