[Bug 26436] New: Quick add patron will not copy over details from cities and towns pull down into patron details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 Bug ID: 26436 Summary: Quick add patron will not copy over details from cities and towns pull down into patron details Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: drigney@equinoxinitiative.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When using the quick add patron option in koha 19.11 : If a library has cities and towns pre-populated in a drop down list and has added this field into the quick add patron form this information will not copy into the full patron form after saving. This was fixed in bug 18569 for 17.11 but is not working in 19.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|19.11 |unspecified Depends on| |3766 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Confirmed in master. Certainly broken by commit 4605d76a73f9b13ba3b0259e3f480fb396051309 Bug 3766: Cities/Towns only on one address Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 [Bug 3766] Cities/Towns only on one address -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18569 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 115500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115500&action=edit Bug 26436: fix city/town pulldown This patch uses a different selector to target the inputs. 1. add some cities to /cgi-bin/koha/admin/cities.pl with city, state, zipcode, and country defined 2. On PatronQuickAddFields select all, this way we can test all the alternate city selects 3. Go to quick add patron, and select a city from the dropdown, the city/state/zip/country doesn't populate (Alternate address city doesnt work either) 4. Apply patch 5. Do 1 - 3 again, it should work 6. Try the regular patron form, make sure all city/town dropdowns still work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115500|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115552&action=edit Bug 26436: fix city/town pulldown This patch uses a different selector to target the inputs. 1. add some cities to /cgi-bin/koha/admin/cities.pl with city, state, zipcode, and country defined 2. On PatronQuickAddFields select all, this way we can test all the alternate city selects 3. Go to quick add patron, and select a city from the dropdown, the city/state/zip/country doesn't populate (Alternate address city doesnt work either) 4. Apply patch 5. Do 1 - 3 again, it should work 6. Try the regular patron form, make sure all city/town dropdowns still work Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |julian.maurice@biblibre.com --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- It doesn't populate the City field for the alternate contact address. Probably because the input's name is "altcontactaddress3" and thus doesn't end with "city". Can it be fixed ? Other than that the patch works well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115552|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 116852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116852&action=edit Bug 26436: fix city/town pulldown in all cases This patch uses a different selector to target the inputs and accounts for the fact that altcontactcity is actually called altcontactaddress3 1. add some cities to /cgi-bin/koha/admin/cities.pl with city, state, zipcode, and country defined 2. On PatronQuickAddFields select all, this way we can test all the alternate city selects 3. Go to quick add patron, and select a city from the dropdown, the city/state/zip/country doesn't populate (Alternate address city doesnt work either) 4. Apply patch 5. Do 1 - 3 again, it should work 6. Try the regular patron form, make sure all city/town dropdowns still work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Julian Maurice from comment #4)
It doesn't populate the City field for the alternate contact address. Probably because the input's name is "altcontactaddress3" and thus doesn't end with "city". Can it be fixed ? Other than that the patch works well.
Good catch. Is my new patch too much of a work around now? It's too bad that the alternate contact city field is borrowers.altcontactaddress3 in the database while state, zipcode, and country are altcontactstate, altcontactzipcode, and altcontactcountry. But fixing that seems to be out of the scope of this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Patch doesn't apply |RESOLVED --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This appears to no longer be valid. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org