[Bug 11139] New: opac-topissues does not work with CCODE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Bug ID: 11139 Summary: opac-topissues does not work with CCODE Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fridolyn.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org When OPAC most populars uses collection code, it does not work. There are never results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 22387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22387&action=edit Bug 11139 - opac-topissues does not work with CCODE See commit message -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-11-07 last check this| | --- Comment #2 from I'm just a bot <gitbot@bugs.koha-community.org> --- testing 1 commit(s) (applied to 5fa6168 'Bug 11204: make pendingreserves use d') [1;32mOK[0m opac/opac-topissues.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I can't reproduce this problem in master. I get results when either item type or collection code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #4 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to Owen Leonard from comment #3)
I can't reproduce this problem in master. I get results when either item type or collection code. Is your authorised values catégory for collection codes : ccode or CCODE ?
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Fridolyn SOMERS from comment #4)
Is your authorised values catégory for collection codes : ccode or CCODE ?
CCODE. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 24103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24103&action=edit no option to limit on ccode I don't even see an option for collection code in the opac top issue. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> ---
I don't even see an option for collection code in the opac top issue.
You have to have the AdvancedSearchTypes preference set to 'ccode' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22387|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25956&action=edit Bug 11139 - opac-topissues does not work with CCODE When OPAC most populars uses collection code, it does not work. There are never results. This patch corrects two points: - SQL query uses 'ccode' as collection code authorised values category, it is CCODE uppercase - The constraint category='CCODE' must be inside join detween items and authorised_values, in this case items.ccode may be NULL Test plan : On a catalogue where items.ccode is defined and uses CCODE authorised values : - Set syspref AdvancedSearchTypes = ccode - Go to opac-topissues.pl - If no results, select "No limit" in "of the last:" and submit => You get results - Select in results a biblio and remove items.ccode from all its items - Refresh opac-topissues.pl (check "All collections" is selected in "Limit to:") => The biblio is still in results Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this patch is incomplete - AdvancedSearchTypes is no longer a switch, but can have multiple values: loc - NOT OK, the itemtype pull down still shows, but it's empty ccode - OK, collections show itemtypes - OK, itemtypes show ccode|itemtpyes - NOT OK, pull down empty itemtypes|loc - NOT OK, pull down empty -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12136 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- One of your client still have this problem with 3.18.08 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED CC| |claire.hernandez@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Bug 14788 fixes the ccode problem, but not the "multiple values" problem. So here is a patch that try to fix it (depends on 14788): -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 43008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43008&action=edit Bug 11139: Add support for multiple values in AdvancedSearchTypes AdvancedSearchTypes syspref can be multivalued, opac-topissues.pl have to support that. AdvancedSearchTypes can have one or more of the following values: 'itemtypes', 'ccode', 'loc'. But this patch adds support only for itemtypes and ccode. AdvancedSearchTypes can still contain 'loc' but it will change nothing to the behaviour of opac-topissues.pl. This patch also removes duplicate code in template (the "Refine your search" form was written in two different places) This introduces a small behaviour change: when there is no results, instead of having the form in the center of the page, it remains in the left sidebar and we have a "No results" message in the main area. Depends on bug 14788 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14788 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 [Bug 14788] Move opac-topissues.pl code into C4::Circulation -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25956|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Nice job Julian -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #14 from Marc Véron <veron@veron.ch> --- Hi Julian and Fridolin, It might be a good idea to have a separate syspref for the behavior of the most popular list instead of the double use of 'AdvancedSearchTypes' It would make things much more clearer. What do you think? Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #15 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Marc Véron from comment #14)
Hi Julian and Fridolin,
It might be a good idea to have a separate syspref for the behavior of the most popular list instead of the double use of 'AdvancedSearchTypes'
It would make things much more clearer.
What do you think?
Marc I agree
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43008|0 |1 is obsolete| | --- Comment #16 from Marc Véron <veron@veron.ch> --- Created attachment 43416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43416&action=edit Bug 11139: Add support for multiple values in AdvancedSearchTypes AdvancedSearchTypes syspref can be multivalued, opac-topissues.pl have to support that. AdvancedSearchTypes can have one or more of the following values: 'itemtypes', 'ccode', 'loc'. But this patch adds support only for itemtypes and ccode. AdvancedSearchTypes can still contain 'loc' but it will change nothing to the behaviour of opac-topissues.pl. This patch also removes duplicate code in template (the "Refine your search" form was written in two different places) This introduces a small behaviour change: when there is no results, instead of having the form in the center of the page, it remains in the left sidebar and we have a "No results" message in the main area. Depends on bug 14788 Tested on top of 14788. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #17 from Marc Véron <veron@veron.ch> --- *** Bug 12136 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 43732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43732&action=edit [PASSED QA] Bug 11139: Add support for multiple values in AdvancedSearchTypes AdvancedSearchTypes syspref can be multivalued, opac-topissues.pl have to support that. AdvancedSearchTypes can have one or more of the following values: 'itemtypes', 'ccode', 'loc'. But this patch adds support only for itemtypes and ccode. AdvancedSearchTypes can still contain 'loc' but it will change nothing to the behaviour of opac-topissues.pl. This patch also removes duplicate code in template (the "Refine your search" form was written in two different places) This introduces a small behaviour change: when there is no results, instead of having the form in the center of the page, it remains in the left sidebar and we have a "No results" message in the main area. Depends on bug 14788 Tested on top of 14788. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43416|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Maurice! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org