http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 43651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43651&action=edit Bug 15039 - Move top language menu to include and streamline logic The language menu in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc is used at other places as well (see Bug 14776). This patch moves it to a file masthead-langmenu.inc to make it re-usable. Additionally it streamlines the logic (not all combinations of Opac sysprefs that should display the menu did so). To test: - Apply patch - Verify, that the language menu displays / does not display with combinations of: - opaclanguagedisplay (Allow) - opaclanguages ( > 1 language selected) - OpacLangSelectorMode (top or both) - Verify that sysprefs opacuserlogin and EnableOpacSearchHistory do not interfere with the lenguage menu (before, at least one of them had to be on to display the menu) - Verify that language switching works as before. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43651|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 43653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43653&action=edit Bug 15039 - Move top language menu to include and streamline logic The language menu in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc is used at other places as well (see Bug 14776). This patch moves it to a file masthead-langmenu.inc to make it re-usable. Additionally it streamlines the logic (not all combinations of Opac sysprefs that should display the menu did so). To test: - Apply patch - Verify, that the language menu displays / does not display with combinations of: - opaclanguagedisplay (Allow) - opaclanguages ( > 1 language selected) - OpacLangSelectorMode (top or both) - Verify that sysprefs opacuserlogin and EnableOpacSearchHistory do not interfere with the lenguage menu (before, at least one of them had to be on to display the menu) - Verify that language switching works as before. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Marc, why didn't you use the include into includes/opac-bottom.inc? (I didn't check line by line if it was the same piece of code) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 Chris Kirby <christopherlawrencekirby@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christopherlawrencekirby@gm | |ail.com --- Comment #5 from Chris Kirby <christopherlawrencekirby@gmail.com> --- Comment on attachment 43653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43653 Bug 15039 - Move top language menu to include and streamline logic Signed off on patch. Applied patch - Verified, that the language menu displays / does not display with combinations of: - opaclanguagedisplay (Allow) - opaclanguages ( > 1 language selected) - OpacLangSelectorMode (top or both) - Verified that sysprefs opacuserlogin and EnableOpacSearchHistory did not interfere: with the lenguage menu (before, at least one of them had to be on to display the menu) - Verified that language switching works as before. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.