http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760 --- Comment #1 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 36168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36168&action=edit Bug 13760 - Authorities merge sometimes create duplicate fields in biblio When merging two authorities the biblio records linked to those authorities are updated. It is directly done if syspref "dontmerge" is on "Do". Actually some cases create a duplicate field. For example, a biblio record as : 600 $9 11 $a Son Goku 600 $9 12 $a Vegeta If you merge the authorities id=11 and id=12 into id=11 (creating Gogeta), you actually get : 600 $9 11 $a Son Goku 600 $9 11 $a Son Goku Having two identical fields linked to the same authority is useless. The same problem is even more frequent when merging two authorities of different type. This patch corrects this behavior by searching already existing field with the link to the autority, using flag $field_to_exists. This flag is not used in case the merge is after a single authority modification. Note that this patch changes the minium of code in order to rebase it easyly. A followup will do the code formatting. Test plan : - Set syspref dontmerge to 'Do' - Create a biblio record - Link a field to an authority (the field gets a $9). For example : 600 $9 11 $a Son Goku - Link a field to another authority (the field gets a $9). For example : 600 $9 12 $a Vegeta - Save the record - Index Zebra queue - Search for autority "Vegeta" - Click on "Merge" - Search for autority "Son Goku" - Click on "Merge" - Click on "Next" - Click on "Merge" - Go to biblio record => Without the patch : you see 2 fields linked to the same authority "Son Goku" => With the patch : you see 1 field linked to the authority "Son Goku" - Test also with autoritites of different type. - Check that modifying the autority "Son Goku" impacts the biblio record -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13762 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11700 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36168|0 |1 is obsolete| | --- Comment #3 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 36846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36846&action=edit Bug 13760 - Authorities merge sometimes create duplicate fields in biblio When merging two authorities the biblio records linked to those authorities are updated. It is directly done if syspref "dontmerge" is on "Do". Actually some cases create a duplicate field. For example, a biblio record as : 600 $9 11 $a Son Goku 600 $9 12 $a Vegeta If you merge the authorities id=11 and id=12 into id=11 (creating Gogeta), you actually get : 600 $9 11 $a Son Goku 600 $9 11 $a Son Goku Having two identical fields linked to the same authority is useless. The same problem is even more frequent when merging two authorities of different type. This patch corrects this behavior by searching already existing field with the link to the autority, using flag $field_to_exists. This flag is not used in case the merge is after a single authority modification. Note that this patch changes the minium of code in order to rebase it easyly. A followup will do the code formatting. Test plan : - Set syspref dontmerge to 'Do' - Create a biblio record - Link a field to an authority (the field gets a $9). For example : 600 $9 11 $a Son Goku - Link a field to another authority (the field gets a $9). For example : 600 $9 12 $a Vegeta - Save the record - Index Zebra queue - Search for autority "Vegeta" - Click on "Merge" - Search for autority "Son Goku" - Click on "Merge" - Click on "Next" - Click on "Merge" - Go to biblio record => Without the patch : you see 2 fields linked to the same authority "Son Goku" => With the patch : you see 1 field linked to the authority "Son Goku" - Test also with autoritites of different type. - Check that modifying the autority "Son Goku" impacts the biblio record -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Here is the follow-up patch for code formatting with perltidy. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760 --- Comment #6 from Jacek Ablewicz <abl@biblos.pk.edu.pl> --- (In reply to Fridolin SOMERS from comment #0)

Actually some cases create a duplicate field. For example, a biblio record as : 600 $9 11 $a Son Goku 600 $9 12 $a Vegeta

If you merge the authorities id=11 and id=12 into id=11 (creating Gogeta), you actually get : 600 $9 11 $a Son Goku 600 $9 11 $a Son Goku

This patch seems to work fine for relativelly simple cases. But what about some more complex ones, like e.g: 700 $9 11 $a Son Goku $t Aaa Bbb 700 $9 12 $a Vegeta $t Ddd Ccc 700 $9 12 $a Vegeta $t Eee Fff after merge, result will be: 700 $9 11 $a Son Goku $t Aaa Bbb instead of 700 $9 11 $a Son Goku $t Aaa Bbb 700 $9 11 $a Son Goku $t Ddd Ccc 700 $9 11 $a Son Goku $t Eee Fff

Having two identical fields linked to the same authority is useless.

I agree, but there is no check anywhere to ensure that the suspected "duplicates" are in fact identical? While having 2+ $9 links to the same authority record from one biblio record is probably not very common (depending on the material type, local cataloguing rules etc.), AFAIK this can happen occasionally and in such cases it's not always necessarily an error and/or a duplicate. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13760 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Jacek Ablewicz from comment #6)

(In reply to Fridolin SOMERS from comment #0)

Indeed, I agree. thanks for your help -- You are receiving this mail because: You are watching all bug changes.