http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Perhaps also take a look at Log4Perl http://search.cpan.org/~mschilli/Log-Log4perl-1.37/lib/Log/Log4perl.pm -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #2)

Right now every warn in code makes patch fail QA (I know that first hand ;-) and it seems to me it's easier to just put warn instead of

C4::Logger->new->debug( "this used to be warn" );

I had a thought about this. Would it be possible to have the logging module serve dual purposes, for both debug logging and for action_logs logging? Hum, I had already this idea and I think it is not a good one :) First, it would take a lot of disk space. To process the results, we will have to grep a huge number of lines of data. Then, we oblige users to keep all of their Koha log. We will depend of an other

Just $log->debug("my debug message"); In fact, a lot of warn in Koha are not a debug message. I think each warn have to be replaced with his right level. But your are right, we can have a thought about this. (A simple method is to map into your favorite editor the string "warn" with a call to the debug method of Logger ;) (In reply to comment #3) source of data (currently, we only have the DB). Imo processing time would be very increased. (In reply to comment #4)

Perhaps also take a look at Log4Perl http://search.cpan.org/~mschilli/Log-Log4perl-1.37/lib/Log/Log4perl.pm I had a look at several perl logging modules. My conclusion is LogLite is the easier for what we need into Koha. In any case, since we have a Koha::Utils::Logger used in Koha, it is easy to replace this module with another ;)

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10996|0 |1 is obsolete| | --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Created attachment 12257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12257&action=edit Bug 8190: C4::Logger, Logging module use Koha::Utils::Logger qw/$log/; $log = Koha::Utils::Logger->new; $log->debug("This is a debug message"); $log->info("This is an information"); $log->error("This is an error !"); The Logger constructor can take an hash reference with "file" and "level" to define a filepath or a log level. For a log level >= warning, a call stack is printed. Prerequisite: - set an environment variable LOG in your virtual host: SetEnv LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #9 from Mason James <mtj@kohaaloha.com> ---

Jonathan. looks good, signing-off...

but, perlcritic errors... Koha/Utils/Logger.pm FAIL Loop iterator is not lexical at line 168, column 5. See page 108 of PBP. t/Logger.t FAIL Two-argument "open" used at line 56, column 1. See page 207 of PBP. Bareword file handle opened at line 80, column 5. See pages 202,204 of PBP. Bareword file handle opened at line 69, column 5. See pages 202,204 of PBP. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12257|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12264&action=edit Bug 8190: Koha::Utils::Logger, Logging module use Koha::Utils::Logger qw/$log/; $log = Koha::Utils::Logger->new; $log->debug("This is a debug message"); $log->info("This is an information"); $log->error("This is an error !"); The Logger constructor can take an hash reference with "file" and "level" to define a filepath or a log level. For a log level >= warning, a call stack is printed. Prerequisite: - set an environment variable KOHA_LOG in your virtual host: SetEnv KOHA_LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- First patch replace LOG with KOHA_LOG Second patch fixes perlcritic errors -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #9)

...

Jonathan. looks good, signing-off...

but, perlcritic errors...

errors fixed, signing-off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12270|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12283&action=edit Bug 8190: Followup Logger: FIX perlcritic Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #18)

Created attachment 12284 [details] Bug 8190 - Followup - Add cached logger, output messages to template

* Add C4::Context->logger * Embed logged messageds to a comment in the template html

I forget to add that I ran perltidy on Logger.pm. I think this followup could be very useful. It may be better to have it controlled by a system preference, rather than always on though. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Kyle, Thanks for your followup ! 2 small remarks about your patch: * you commited mainpage.pl unfortunately * the added block of code in Logger::write is not perltidied Else all seems good but we have to pull together on how we will use the logger. Your idea to add a global var in C4::Context is what I had at the beginning of my work. But after thinking, on this way, we canot change the loglevel for 1 script ! And it is a regression (indeed currently we can do that, changing the DEBUG var). My idea was to add use C4::Logger qw/$log/; $log = C4::Logger->new({level => C4::Context->preference("LogLevel")}); on each page. Like that we could change the log level easily. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12282|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12743&action=edit [SIGNED-OFF] Bug 8190: Koha::Utils::Logger, Logging module use Koha::Utils::Logger qw/$log/; $log = Koha::Utils::Logger->new; $log->debug("This is a debug message"); $log->info("This is an information"); $log->error("This is an error !"); The Logger constructor can take an hash reference with "file" and "level" to define a filepath or a log level. For a log level >= warning, a call stack is printed. Prerequisite: - set an environment variable KOHA_LOG in your virtual host: SetEnv KOHA_LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12287|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12745&action=edit Bug 8190 - Followup - Add cached logger, output messages to template * Add C4::Context->logger * Embed logged messageds to a comment in the template html, controlled by the system preference LogToHtmlComments\ * Add both new system preferences to sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12745|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12746&action=edit Bug 8190 - Followup - Add cached logger, output messages to template * Add C4::Context->logger * Embed logged messageds to a comment in the template html, controlled by the system preference LogToHtmlComments\ * Add both new system preferences to sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12743|0 |1 is obsolete| | Attachment #12744|0 |1 is obsolete| | Attachment #12746|0 |1 is obsolete| | --- Comment #29 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13739&action=edit Bug 8190: Koha::Utils::Logger, Logging module use Koha::Utils::Logger qw/$log/; $log = Koha::Utils::Logger->new; $log->debug("This is a debug message"); $log->info("This is an information"); $log->error("This is an error !"); The Logger constructor can take an hash reference with "file" and "level" to define a filepath or a log level. For a log level >= warning, a call stack is printed. Prerequisite: - set an environment variable KOHA_LOG in your virtual host: SetEnv KOHA_LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8190: Followup Logger: FIX perlcritic Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8190 - Followup - Add cached logger, output messages to template * Add C4::Context->logger * Embed logged messageds to a comment in the template html, controlled by the system preference LogToHtmlComments\ * Add both new system preferences to sysprefs.sql Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #31 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #30) Forget patch updated in comment 29, I forgot to squash the updatedatabase changes:

Bug 8190 follow-up moving updatedatabase part at the right place

the comment 30 patch is OK ! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13740|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13925&action=edit Bug 8190: Koha::Utils::Logger, Logging module use Koha::Utils::Logger qw/$log/; $log = Koha::Utils::Logger->new; $log->debug("This is a debug message"); $log->info("This is an information"); $log->error("This is an error !"); The Logger constructor can take an hash reference with "file" and "level" to define a filepath or a log level. For a log level >= warning, a call stack is printed. Prerequisite: - set an environment variable KOHA_LOG in your virtual host: SetEnv KOHA_LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8190: Followup Logger: FIX perlcritic Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8190 - Followup - Add cached logger, output messages to template * Add C4::Context->logger * Embed logged messageds to a comment in the template html, controlled by the system preference LogToHtmlComments\ * Add both new system preferences to sysprefs.sql Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Bug 8190 follow-up moving updatedatabase part at the right place Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have started testing this. I notice, that when you have liblog-loglite-perl not installed, Koha is unusable. And instead of giving you an error indicating what's going wrong, it explodes with: Internal Server Error The server encountered an internal error or misconfiguration and was unable to complete your request. I think this will cause a lot of questions - can we make this fail a bit more gracefully? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Often the perl error message is more helpful, indicating that there is a missing dependency. I think the way this explodes now is going to make us answer lots of questions. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #40 from Jonathan Druart <jonathan.druart@biblibre.com> --- The patch displays a specific message if the module Koha::Utils::Logger raises an error. It is not a clean way but I don't know how to do this differently. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #42 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14296&action=edit Bug 8190: FIX Unit test Set the KOHA_LOG environment variable in the test -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #44 from Jonathan Druart <jonathan.druart@biblibre.com> --- A quick start: http://wiki.koha-community.org/wiki/Logger -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #46 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- (In reply to comment #44)

A quick start: http://wiki.koha-community.org/wiki/Logger

It seems to me that ->debug calls *should* be included in code committed to Master. Isn't the entire point of the logger that it's possible to change your log level so that you can get all the debug information/all the warnings/info and errors/just errors/just critical errors? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can't get debug to show up. My LogLevel is set to the highest level 7. I verified this is also the value in the systempreferences table. I added following code to the mainpage.pl file: use Koha::Utils::Logger qw/$log/; $log = Koha::Utils::Logger->new; $log->unusable("This is an unusable thing"); $log->critical("This is critical!"); $log->error("This is an error !"); $log->warning("This is only a warning."); $log->normal("This nothing to worry about."); $log->info("This is an information"); $log->debug("This is a debug message"); With LogToHtmlComments set to Embed I can see following in the HTML source code of the main page: <!-- LOG MESSAGES [Thu Dec 27 17:54:44 2012] UNUS : This is an unusable thing [Thu Dec 27 17:54:44 2012] CRIT : This is critical! [Thu Dec 27 17:54:44 2012] ERROR : This is an error ! [Thu Dec 27 17:54:44 2012] WARN : This is only a warning. [Thu Dec 27 17:54:44 2012] NORMAL: This nothing to worry about. [Thu Dec 27 17:54:44 2012] INFO : This is an information --> My log files shows: [27/12/2012 17:54:44] UNUS : This is an unusable thing [27/12/2012 17:54:44] CRIT : This is critical! [27/12/2012 17:54:44] ERROR : This is an error ! [27/12/2012 17:54:44] WARN : This is only a warning. [27/12/2012 17:54:44] NORMAL: This nothing to worry about. [27/12/2012 17:54:44] INFO : This is an information My test plan so far was: 1) Apply patches and try to access Koha. Verify useful error message is shown. 2) Install new dependency: Log::LogLite sudo apt-get install liblog-loglite-perl 3) Run database update Verify database update works correctly 4) Run t/Logger.t Verify all tests pass 5) Do some searches in OPAC. Verify Koha does not explode and all is acting normal. Verify debug message is not showing up in HTML source. Look for <!-- LOG MESSAGES Verify nothing has changed and no messages show up. 6) Set environment variables in your Apache configuration files I added following line to the OPAC and Intranet <virtualhost> sections: SetEnv KOHA_LOG "/home/<user>/koha-dev/var/log/opac.log" SetEnv KOHA_LOG "/home/<user>/koha-dev/var/log/intranet.log" Make sure log file is writeable for your Apache user. 7) Repeat 5). Check that the searches show up in the OPAC log file. 8) Change one of the intranet files and add some messages/warns etc. to be logged. 9) Set LogToHtmlComments to 'Embed' and check output in log file and for the debug messages in the source code. Looks for <!-- LOG MESSAGES ALSO: With bug 7167 pushed, the update database part on this should be rewritten. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13925|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14294|0 |1 is obsolete| | --- Comment #52 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14320&action=edit Bug 8190: raise an error if the Log::LogLite module is not installed -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #54 from Chris Cormack <chris@bigballofwax.co.nz> --- Patches rebased so they all apply on master. Tests pass. However it is currently not plack safe, follow up to come. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #56 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 14324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14324&action=edit DO NOT USE - Partial rewrite of Logger -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #58 from Chris Cormack <chris@bigballofwax.co.nz> --- If we are going to always access the logger object via C4::Context, we could do this all without the need of a new module. if in C4::Context we added something very similar to use Log::Log4perl qw(:levels get_logger); my $layout_class = "Log::Log4perl::Layout::PatternLayout"; my $layout_pattern = "[%d] %p - %M - %m - %T%n"; my $config = <<"END"; log4perl.logger = INFO, Logfile, Screen log4perl.appender.Logfile = Log::Log4perl::Appender::File log4perl.appender.Logfile.filename = $ENV{KOHA_LOG} log4perl.appender.Logfile.mode=append log4perl.appender.Logfile.layout = $layout_class log4perl.appender.Logfile.layout.ConversionPattern=$layout_pattern log4perl.appender.Screen = Log::Log4perl::Appender::Screen log4perl.appender.Screen.layout = $layout_class log4perl.appender.Screen.layout.ConversionPattern = $layout_pattern END Log::Log4perl->init( \$config ); and then in there a sub sub logger { my $self = shift; if ( defined( $context->{"logger"} ) ) { return $context->{"logger"}; } $context->{"logger"} = Log::Log4perl->get_logger('C4::Context'); $context->{"logger"}->level(C4::Context->preference("LogLevel")); return $context->{"logger"}; } We would have a logger logging to stderr and to the file defined. We would need to change our numeric loglevels to strings, like FATAL, WARN etc but that is easily done. And if we did want our 2 extra ones, we can add these 2 lines # set up our custom log leves CRIT and NORMAL Log::Log4perl::Logger::create_custom_level( 'CRIT', 'FATAL'); Log::Log4perl::Logger::create_custom_level( 'NORMAL', 'WARN' ); Before we do the init. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #60 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #59)

(In reply to comment #58)

...

If we are going to always access the logger object via C4::Context, we could do this all without the need of a new module.

That seems reasonable to me. Is there a downside to that method of handling the logging?

Hmm I think when working with Koha you always need a context object, so that having a logging object seems good to me. If you did want to log without context (no access to db or conf) you would have to make your own object. If you want to provide a dump mechanism like the original patch you can define a filter in the configuration to do that. I may have missed something though -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #62 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #57)

There are five issues that absolutely must be fixed: 1) The ->debug() level needs to work.

It has always worked, see comment #49

2) Private variable need to be eliminated from the module level and the code made thread-safe.

Done, tested with Plack

3) The unit test must be changed to not require the database.

Done, removed the C4::Context requirement

4) The $log package variable should not be in Koha::Utils::Logger. Any static configuration should be handled entirely in C4::Context. 5) If Koha::Utils::Logger is object-oriented, it must not be an Exporter.

Done -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14320|0 |1 is obsolete| | --- Comment #63 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14703&action=edit Bug 8190: raise an error if the Log::LogLite module is not installed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14388|0 |1 is obsolete| | --- Comment #65 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14705&action=edit Bug 8190: QA Followup - Remove the private variables - Remove the use of C4::Context in the UT - Remove the Exporter Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14318|0 |1 is obsolete| | Attachment #14319|0 |1 is obsolete| | Attachment #14703|0 |1 is obsolete| | Attachment #14704|0 |1 is obsolete| | Attachment #14705|0 |1 is obsolete| | --- Comment #68 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16426&action=edit Bug 8190: Koha::Utils::Logger, Logging module use Koha::Utils::Logger qw/$log/; $log = Koha::Utils::Logger->new; $log->debug("This is a debug message"); $log->info("This is an information"); $log->error("This is an error !"); The Logger constructor can take an hash reference with "file" and "level" to define a filepath or a log level. For a log level >= warning, a call stack is printed. Prerequisite: - set an environment variable KOHA_LOG in your virtual host: SetEnv KOHA_LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8190: Followup Logger: FIX perlcritic Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8190 - Followup - Add cached logger, output messages to template * Add C4::Context->logger * Embed logged messageds to a comment in the template html, controlled by the system preference LogToHtmlComments\ * Add both new system preferences to sysprefs.sql Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Bug 8190 follow-up moving updatedatabase part at the right place Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #70 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16428&action=edit Bug 8190: raise an error if the Log::LogLite module is not installed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #72 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16430&action=edit Bug 8190: QA Followup - Remove the private variables - Remove the use of C4::Context in the UT - Remove the Exporter Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16426|0 |1 is obsolete| | Attachment #16427|0 |1 is obsolete| | Attachment #16428|0 |1 is obsolete| | Attachment #16429|0 |1 is obsolete| | Attachment #16430|0 |1 is obsolete| | --- Comment #73 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18799&action=edit Bug 8190: Koha::Utils::Logger, Logging module use Koha::Utils::Logger qw/$log/; $log = Koha::Utils::Logger->new; $log->debug("This is a debug message"); $log->info("This is an information"); $log->error("This is an error !"); The Logger constructor can take an hash reference with "file" and "level" to define a filepath or a log level. For a log level >= warning, a call stack is printed. Prerequisite: - set an environment variable KOHA_LOG in your virtual host: SetEnv KOHA_LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8190: Followup Logger: FIX perlcritic Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8190 - Followup - Add cached logger, output messages to template * Add C4::Context->logger * Embed logged messageds to a comment in the template html, controlled by the system preference LogToHtmlComments\ * Add both new system preferences to sysprefs.sql Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Bug 8190 follow-up moving updatedatabase part at the right place Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #75 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18801&action=edit Bug 8190: raise an error if the Log::LogLite module is not installed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #77 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18803&action=edit Bug 8190: QA Followup - Remove the private variables - Remove the use of C4::Context in the UT - Remove the Exporter Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #79 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Looks quite promising! Some questions on details: You (almost) follow common levels like: LOG_EMERG system is unusable LOG_ALERT action must be taken immediately LOG_CRIT critical conditions LOG_ERR error conditions LOG_WARNING warning conditions LOG_NOTICE normal, but significant, condition LOG_INFO informational message LOG_DEBUG debug-level message Why no alert level? Note that LogLite also supports 8 levels (0=unusable, 1=close to unusable) Displaying 1-Unusable is not intuitively clear (in the prefs)? If you include html comments in staff doc-head-open, why not in opac side? Note that you add a test in opac-search (info statement). Is the eval require+die for Koha::Utils::Logger in the third patch really an improvement? I am no packaging expert :) But is adding this module in install_misc/debian.packages enough? Changing status to reflect need for clarification (or adjustment). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #81 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18819&action=edit Bug 8190 - Add a logging module to Koha - Followup - Add html embedded logs to OPAC -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #83 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #81)

Created attachment 18819 [details] [review] Bug 8190 - Add a logging module to Koha - Followup - Add html embedded logs to OPAC

I understand the changes for opac and using the Koha plugin logic. But I still cannot see the log message in the opac document. (Just empty for opac-search) Are you sure that the statement Logger.get_messages works this way? I tried logger lc too without results. It seems not to work.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #85 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #84)

Did you add any logging code to an opac script to test it? I just added this to my opac-main.pl to test:

C4::Context->logger->debug("This is a debug message"); C4::Context->logger->error("This is an error !");

Found what happened: In opac-search Jonathan creates a logger object in opac-search (that's the one I was looking for). But C4/Auth also initialized a logger ALREADY. So the second logger got my message, but the template asked it to the first logger and got nothing. Still following? Will send a small followup for this. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18799|0 |1 is obsolete| | Attachment #18800|0 |1 is obsolete| | Attachment #18801|0 |1 is obsolete| | Attachment #18802|0 |1 is obsolete| | Attachment #18803|0 |1 is obsolete| | Attachment #18819|0 |1 is obsolete| | Attachment #18820|0 |1 is obsolete| | --- Comment #86 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18870&action=edit Bug 8190: Koha::Utils::Logger, Logging module use Koha::Utils::Logger qw/$log/; $log = Koha::Utils::Logger->new; $log->debug("This is a debug message"); $log->info("This is an information"); $log->error("This is an error !"); The Logger constructor can take an hash reference with "file" and "level" to define a filepath or a log level. For a log level >= warning, a call stack is printed. Prerequisite: - set an environment variable KOHA_LOG in your virtual host: SetEnv KOHA_LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8190: Followup Logger: FIX perlcritic Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Bug 8190 - Followup - Add cached logger, output messages to template * Add C4::Context->logger * Embed logged messageds to a comment in the template html, controlled by the system preference LogToHtmlComments\ * Add both new system preferences to sysprefs.sql Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Bug 8190 follow-up moving updatedatabase part at the right place Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #87 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18871&action=edit Bug 8190: Follow Add some POD Add POD and prefix private methods with _ Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #89 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18873&action=edit Bug 8190: FIX Unit test Set the KOHA_LOG environment variable in the test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #91 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18875&action=edit Bug 8190 - Add a logging module to Koha - Followup - Add html embedded logs to OPAC Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #93 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18877&action=edit Bug 8190: Followup for opac-search Script should not create a second logger object, but use the one that the Auth module already made. Works fine now. Only question is: Should we leave it here. This is somewhat of a debug statement. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a logging module to |Add a logging module to |Koha, that can report log |Koha |message to staff interface | |(for developer use) | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18870|0 |1 is obsolete| | --- Comment #95 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18880&action=edit Bug 8190: Koha::Utils::Logger, Logging module Use the logger like: $logger= C4::Context->logger; $logger->debug("This is a debug message"); $logger->info("This is an information"); $logger->error("This is an error !"); The Logger constructor can take an hash reference with "file" and "level" to define a filepath or a log level. For a log level >= warning, a call stack is printed. Prerequisite: - set an environment variable KOHA_LOG in your virtual host: SetEnv KOHA_LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. Includes (apparently from squashed patches): Bug 8190: Followup Logger: FIX perlcritic Bug 8190 - Followup - Add cached logger, output messages to template * Add C4::Context->logger * Embed logged messages to a comment in the template html, controlled by the system preference LogToHtmlComments\ * Add both new system preferences to sysprefs.sql Bug 8190 follow-up moving updatedatabase part at the right place Signed-off-by: Mason James <mtj@kohaaloha.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Amended the patch for a updatedatabase problem. Edited the commit message. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #97 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18882&action=edit Bug 8190: raise an error if the Log::LogLite module is not installed Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #99 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18884&action=edit Bug 8190: QA Followup - Remove the private variables - Remove the use of C4::Context in the UT - Remove the Exporter Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18876|0 |1 is obsolete| | Attachment #18877|0 |1 is obsolete| | --- Comment #101 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 18887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18887&action=edit Bug 8190: Add the 'alert' level. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #103 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- 'final' comment for RM: Code looks good to me now. (See QA comments before.) I am wondering if we should by default put the level to 5 (normal) at install or upgrade. When someone does not want to use it, we could set it to zero (emerge or unusable level) and have around zero messages. Robin should still have a look for the packaging stuff. Jonathan will probably send a few trivial followups for housekeeping (e.g. correcting 7->8 levels; also in pref desc in db). Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #105 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #95)

Amended the patch for a updatedatabase problem. Edited the commit message.

Thanks for that Marcel! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #107 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #106)

That begs a question, though -- what do we need in Koha?

One part of the answer to that question, for me, and I suspect for most folks who administer more than one Koha database or who administer services in addition to Koha, is syslog support. Log::LogLite doesn't provide such support, whereas Log4Perl does in addition to supporting appending to traditional log files.

Also, Chris in comment 58 all but proposed a counter-patch. Would the original patch submitter respond to that comment, please?

This development was written 1 year ago for BibLibre branches. We need a logger with different levels (like many softwares). I provided a simple module which does what we want. Since this is a simple class, it could be rewritten easily by someone having a better idea. The patch proposed by Chris was not working but it could be the second step to this development. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #109 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #108) Hi Chris,

The point of my counter proposal was that we do not need another module, we can add some lines to context.pm using Log4perl and not have another module to maintain ourselves.

Humm, I don't think it is a good argument. A module with unit tests is easiest to maintain than a module like C4::Context (~1000l) :)

Pushing this now as it is, would mean we would just have to remove it again if we wanted to do it the Log4perl way. IE if people think that is a good idea, then I can write a working patch for that, however if this is pushed, I won't. I also won't be happy that we have yet another module we have to maintain instead.

I maintain we dont need a new logging module, we just need to add logging to C4::Context.

There is no problem to propose an alternative working patch, but don't loose sight of the fact that the module we propose here does something else more than just logging: - a called by trace is displayed for some levels - a get_messages method allows to return all logged messages - messages are thrown to the stdout if the logger is not defined (ie. no filepatch defined or a bad configuration somewhere) - a parameter allows to dump a variable (using Data::Dumper or something else. e.g. $logger->debug($hashref, "dump_me");) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #111 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #109)

(In reply to comment #108)

Hi Chris,

...

The point of my counter proposal was that we do not need another module, we can add some lines to context.pm using Log4perl and not have another module to maintain ourselves.

Humm, I don't think it is a good argument. A module with unit tests is easiest to maintain than a module like C4::Context (~1000l) :)

We still have to maintain C4::Context, and now a new module, it feels hugely like reinventing the wheel for the 13th time and I still don't like it. We probably will have to agree to disagree on this. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13413 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18881|0 |1 is obsolete| | --- Comment #113 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34838&action=edit Bug 8190: Follow Add some POD Add POD and prefix private methods with _ Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18883|0 |1 is obsolete| | --- Comment #115 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34840&action=edit Bug 8190: FIX Unit test Set the KOHA_LOG environment variable in the test Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18886|0 |1 is obsolete| | --- Comment #117 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34842&action=edit Bug 8190: Followup - Add html embedded logs to OPAC Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18888|0 |1 is obsolete| | --- Comment #119 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34844&action=edit Bug 8190: Followup for opac-search Script should not create a second logger object, but use the one that the Auth module already made. Works fine now. Only question is: Should we leave it here. This is somewhat of a debug statement. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #121 from Jonathan Druart <jonathan.druart@biblibre.com> --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #122 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm in general preferring the simplicity of Bug 14167 for now. Lets go with that and get this much needed feature into Koha! -- You are receiving this mail because: You are watching all bug changes.