[Bug 22559] New: OPAC Forgotten password functionality not working
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Bug ID: 22559 Summary: OPAC Forgotten password functionality not working Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: wizzyrea@gmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Trying to reset a password using the forgotten password OPAC functionality seems to fail with one of a couple of messages: Can't call method "catch" without a package or object reference at /home/vagrant/kohaclone/opac/opac-password-recovery.pl line 158 or Can't call method "isa" on an undefined value at /home/vagrant/kohaclone/opac/opac-password-recovery.pl line 159 This seems to happen after commit f822dee088b86edecd5d5c73718ad9f8a04c0664 To reproduce: Enable OpacResetPassword Create a borrower with a username and password Go to the OPAC, try to reset the password (I always get the reset link out of the message_queue in the database rather than worry about receiving the actual email. You do you.) Go to the link provided. Attempt to set a password, this should fail. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 86854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86854&action=edit Bug 22559: Restore OPAC forgotten password functionality To test: Enable OpacResetPassword Create a borrower with a username and password Go to the OPAC, try to reset the password (I always get the reset link token out of the message_queue in the database rather than worry about receiving the actual email. You do you.) Go to the link provided. Attempt to set a password, this should fail. Apply this patch, restart the things Go through the process again, password should be reset. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86854|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 86857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86857&action=edit Bug 22559: Restore OPAC forgotten password functionality To test: Enable OpacResetPassword Create a borrower with a username and password Go to the OPAC, try to reset the password (I always get the reset link token out of the message_queue in the database rather than worry about receiving the actual email. You do you.) Go to the link provided. Attempt to set a password, this should fail. Apply this patch Go through the process again, password should be reset. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22048 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 [Bug 22048] Use set_password instead of update_password in the codebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86857|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86859&action=edit Bug 22559: Restore OPAC forgotten password functionality To test: Enable OpacResetPassword Create a borrower with a username and password Go to the OPAC, try to reset the password (I always get the reset link token out of the message_queue in the database rather than worry about receiving the actual email. You do you.) Go to the link provided. Attempt to set a password, this should fail. Apply this patch Go through the process again, password should be reset. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The enhancement that caused this was not backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org