https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11262 [Bug 11262] Don't require hardcoded translations for seasonal numbering pattern to work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24172 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #4)

(In reply to Jonathan Druart from comment #3)

...

Generate new serial items and confirm that the seasons are correctly translated when displayed

Where will this information appear?

You should see the season translated everywhere it's displayed (not when it appears in an input however). So on the catalogue/detail.pl tab "Subscriptions", or the subscription detail view (/serials/subscription-detail.pl?subscriptionid=1) You need to: gulp po:update --lang es-ES cd misc/translate Edit po/es-ES-messages.po, translate the season names ./translate install es-ES restart_all (strings are cached) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 --- Comment #6 from Hugo Agud <hagud@orex.es> --- I a trying to test into sandbox, but i have no way of updating po. I have seen that If I the pattern include to season like spring-summer, it only translates one of two. sample Número Fecha de publicación Vol. Primavera, Number Summer, Issue 0 04/01/2022 Vol. Verano, Number Fall, Issue 1 07/01/2022 Vol. Otoño, Number Winter, Issue 2 10/01/2022 Vol. Winter, Number Primavera, Issue 3 01/01/2023 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 --- Comment #8 from Hugo Agud <hagud@orex.es> --- Hi Pattern offer you the chance of define {x}, {y} , {z}... it is often use only one season, but there are certain serials that will need two season patter number: springer-summer, winter-auttum for example. when use season two times in the same pattern, koha it only translate one, perhaps it also happens with the rest of days, months...etc -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133107&action=edit Bug 20511: Remove translation support for short version of season Everything get messy when we translate "Sum", then "Summer" as it's a substring. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 --- Comment #12 from Hugo Agud <hagud@orex.es> --- url: https://staff-bug20511.sandboxes.biblibre.eu/cgi-bin/koha/serials/subscription-add.pl?op=modify&subscriptionid=1 screenshot: https://orex.es/wp-content/uploads/2022/04/Captura-de-pantalla-2022-04-08-a-... but I still have no way of accessing to .po, sorry -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130751|0 |1 is obsolete| | Attachment #133107|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135504&action=edit Bug 20511: Make seasons translatable in prediction pattern The season is stored in the DB in English and but not translated when displayed on the interface. This patch will translate the different seasons and their short form ('Spr' for 'Spring'). Test plan: Update the PO of the language you like Edit po/xx-XX-messages.po and translate the season names Setup a new language and use it for the staff interface Create a new subscription using the "Seasonal" subscription pattern Generate new serial items and confirm that the seasons are correctly translated when displayed Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 --- Comment #16 from Florian <florian.bontemps@biblibre.com> --- Created attachment 135775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135775&action=edit Bug 13614: Compiled CSS Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Florian <florian.bontemps@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 --- Comment #18 from Florian <florian.bontemps@biblibre.com> --- Created attachment 135777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135777&action=edit Bug 20511: Remove translation support for short version of season Everything get messy when we translate "Sum", then "Summer" as it's a substring. Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am a little worried by the patch comments:

Remove translation support for short version of season

The season is stored in the DB in English and but not translated when displayed on the interface.

I am not sure if that is correct? If a translated GUI is used, you will have created a string (serialseq I tihnk) using the numberpattern that contains the translation of the season. Will this still work as before after the patches? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could you please rebase? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135776|0 |1 is obsolete| | Attachment #135777|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138684&action=edit Bug 20511: Make seasons translatable in prediction pattern The season is stored in the DB in English and but not translated when displayed on the interface. This patch will translate the different seasons and their short form ('Spr' for 'Spring'). Test plan: Update the PO of the language you like Edit po/xx-XX-messages.po and translate the season names Setup a new language and use it for the staff interface Create a new subscription using the "Seasonal" subscription pattern Generate new serial items and confirm that the seasons are correctly translated when displayed Sponsored-by: Orex Digital Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think think this doesn't fix what was reported as the bug initially: comment#1 The seasonal (season, day and month) prediction it doesn't change according the locale defined in the patterns, the pattern uses always the language of the staff user interface. I believe that the expectation here is that it should work like months/day of week do. You should be able to use the Locale setting of the subscription to determine the language used for the generated strings, so that it matches with what is printed on the issue. These are not meant to be multi-lingual, but to match the 'original' printed version. What this patch does is actually the bug: It makes the description switch depending on the GUI language used. Before this patch (tested in 20.11): Staff interface: German Locale: German Preview pattern: German Serial collection: German Edit serials: English OPAC: English Database: English With this patch set: Staff interface: *English* Locale: Spanish Preview pattern: English Serial collection: English Edit serials: English OPAC: English Database: English Update translations, switch interface to German: Staff interface: *German* Locale: Spanish Preview pattern: German Subscription detail view: German Serial collection German Edit serials: English (!) (input fields) Database: English Staff detail view: German Late issues/claims: German OPAC detail page - Subscription: English OPAC brief history: English Full history: English Conclusion: 1) This makes the display more consistent in the staff interface. OPAC has been missed and should work the same as staff. 2) Locale setting is ignored for seasons. This makes seasons work different to the other formatted strings. This doesn't sit well with me, because it's also an inconsistency, but I am not sure there is a fix as I believe the library used for other strings just doesn't support seasons. :( If we agree on the different behavior we should document it. Suggestion: Extend the hint below the Locale pull down by: "Not used for seasons." 3) Removing the limited support for abbreviated seasons is a little issue. We can hardly remove the setting if libraries have used it, but is it really useful if it works only for English? A compromise could be to add a hint to the entry in the formatting pull down: "Name of season (abbreviated, English)" What could help here in the future would be a feature to define your own "formatted strings" as a list of authorised values (thought I had filed that... but can't find it). Codes would be numerical, AV would be the string used and we could use them to extend the list of available formats. I had requests for Roman numbering and we could also imagine someone wanting to do Japanese numbering or similar. This could help solve that issue. (I'll file later if people like it :) ) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 --- Comment #26 from Mathieu Saby <mathsabypro@gmail.com> --- Hi Is there a chance to see this problem fixed in 2024? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #27 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Hello ! I am not quite sure I understand the reason why the bug is stuck. What I understand about the bug : Librarian using non english versions of Koha have seasons displayed in english and would like to have it in english. What I understand about the patch : Occurrences on the interface are replaced by a translatable string while not modifying anything in DB for evident reasons. For a reason I do not understand it is not possible for abbreviations. What I understand about the current issue :

It lacks at an OPAC changes Is it necessary in the scope of this patch ?

Removing the limited support for abbreviated seasons is a little issue. We can hardly remove the setting if libraries have used it, but is it really useful if it works only for English? A compromise could be to add a hint to the entry in the formatting pull down: "Name of season (abbreviated, English)" I like the idea of having the key abbreviated in English, it works a bit like we do with permissions.

What I do not understand :

Locale setting is ignored for seasons. This makes seasons work different to the other formatted strings. This doesn't sit well with me, because it's also an inconsistency, but I am not sure there is a fix as I believe the library used for other strings just doesn't support seasons.

I do not get the point and hence I might not have understood the patch: the library we are using for translations requires manual input for translations, doesn't it ? What is the relation between the fact it works everywhere but in serial editions and the translation library ? -- You are receiving this mail because: You are watching all bug changes.