[Bug 27272] New: Move C4::Items::GetItemsInfo to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug ID: 27272 Summary: Move C4::Items::GetItemsInfo to Koha namespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This method should just be removed and a mix of things used instead: my $biblio = Koha::Biblios->find($biblio_id, {prefetch =>['items', 'biblioitem'] }); my @items = $biblio->items; my $biblioitem = $biblio->biblioitem; ^^^ could do most of it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Good tip, Tomás! I'll do that when I begin this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128230&action=edit Bug 27272: Remove GetItemsInfo from catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128231&action=edit Bug 27272: Remove type= This is not related to anything known.. was it "itype" at some point? `git log -p` will tell you that it's there for a looong time already -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This is just a start! I am willing to work on that (ie. completely remove this silly subroutine). Just tell me you are ready to test the patches and I will continue! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26587 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #5)
This is just a start! I am willing to work on that (ie. completely remove this silly subroutine). Just tell me you are ready to test the patches and I will continue!
Still nobody interested in this? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #6)
(In reply to Jonathan Druart from comment #5)
This is just a start! I am willing to work on that (ie. completely remove this silly subroutine). Just tell me you are ready to test the patches and I will continue!
Still nobody interested in this?
Go on ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #6)
(In reply to Jonathan Druart from comment #5)
This is just a start! I am willing to work on that (ie. completely remove this silly subroutine). Just tell me you are ready to test the patches and I will continue!
Still nobody interested in this?
I'd say go for it. Next step is to just pass the items to the templates I guess? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128230|0 |1 is obsolete| | Attachment #128231|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135640&action=edit Bug 27272: Remove GetItemsInfo from catalogue/detail.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135641&action=edit Bug 27272: catalogue/detail -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135642&action=edit Bug 27272: Remove type= This is not related to anything known.. was it "itype" at some point? `git log -p` will tell you that it's there for a looong time already -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135643&action=edit Bug 27272: basket/basket -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135644&action=edit Bug 27272: basket/sendbasket Why are we display with $raw? Why are we display the location code instead of the AV's lib? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135645&action=edit Bug 27272: catalogue/imageviewer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135646&action=edit Bug 27272: labels/label-item-search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135647&action=edit Bug 27272: misc/migration_tools/rebuild_zebra.pl Hum... Item2Marc ok here? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135648&action=edit Bug 27272: opac-detail -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135649&action=edit Bug 27272: already_reserved never set (was set before 14695) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135650&action=edit Bug 27272: opac-reserve -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135651&action=edit Bug 27272: moredetail -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135652&action=edit Bug 27272: opac-sendbasket -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135653&action=edit Bug 27272: opac-tags -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135654&action=edit Bug 27272: serials/routing-preview -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135655&action=edit Bug 27272: tags/list.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135656&action=edit Bug 27272: opac-sendshelf -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135657&action=edit Bug 27272: virtualshelves/sendshelf.pl shelves.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135658&action=edit Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135640|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135659&action=edit Bug 27272: Remove GetItemsInfo from catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #8)
I'd say go for it. Next step is to just pass the items to the templates I guess?
Yes "just"... :D Here are the patches. What next now? Do I open one bug report per patch? IMO we should test, review and push all of them at the same time, so no need for 19 new bug reports, but I do whatever you prefer. It's crazy the number of bugs I found and fixed. You will find some FIXMEs I have added (some that need attention now, others that are for later). The code is way cleaner now and, I think, more efficient (perf) as well. I haven't tested everything, and tests need test plans, but basically 80% of the work is done. There is much more to do in these scripts, we could simplify even more. But first, this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29697, 30885, 30886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 [Bug 29697] Replace GetMarcBiblio occurrences with $biblio->metadata->record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 [Bug 30885] Recall - detail page explosion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30886 [Bug 30886] Recall status cannot be correct on opac-detail -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- 30 files changed, 495 insertions(+), 893 deletions(-) Please understand that we need the patches pushed ASAP once they are ready for testing. I will NOT rebase them several months. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #29)
It's crazy the number of bugs I found and fixed.
And some related to items visibility at the OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135641|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Ha, and question, see catalogue/detail.pl We are using an order_by that was initially used in GetItemsInfo. Should it be the default order by for all item searches? I am also stuck trying to replicate the previous order_by behaviour for serials (see the FIXME there) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #29)
I haven't tested everything, and tests need test plans, but basically 80% of the work is done.
If I can save 80% of my records, we're happy :) Great work. We need some priority lane for these things. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11213 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #33)
Great work. We need some priority lane for these things.
This is a priority on this cycle. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #35 from Nick Clemens <nick@bywatersolutions.com> --- 1 - View details.pl for a record - confirm barcode link takes you to correct page and other info displays correctly 2 - Add several records to a cart - find a mix with and without items 3 - Confirm the records display correctly the location and branchcodes in the cart 4 - Setup SMTP using your email. For gmail: Create app password: https://support.google.com/accounts/answer/185833?hl=en Add gmail server to koha-conf <smtp_server> <host>smtp.gmail.com</host> <port>465</port> <timeout>60</timeout> <ssl_mode>SSL</ssl_mode> <user_name>kohadev@cool.com</user_name> <password>expialodotious</password> <debug>0</debug> </smtp_server> 5 - Send cart to yourself and verify branches show name correctly 6 - Enable LocalCoverImages system poreference 7 - Upload an image to a record (from details page, images tab) 8 - Click the image in the tab and confirm it is shown 9 - Set searchenginge system preference to zebra 10 - sudo koha-shell kohadev 11 - perl misc/migration_tools/rebuild_zebra.pl -b -v 12 - confirm searchign for item fields works 13 - Find/create a subscription (Serials->New subscription) Ensure in subscription details that: Create an item record when receiving this serial is marked 14 - Receive/find an issue with an item, view in opac 15 - Confirm "Vol info" column correctly populated, and other item info displays as epxectd 16 - Place a reserve on OPAC, make sure to find/create a record with some holdable and unholdable items, and some items on loan/checked out 17 - Ensure items show correctly in form and hold can be placed 18 - In staff client, view the items tab for a record. 19 - Confirm items show correctly and links are preserved 20 - Confirm item statuses show correctly, including issued items, transit items, not for loan 21 - Repeat cart tests on the opac, ensure sent cart displays correcttly 22 - On staff client, return to subscription used previously 23 - From subscription details click 'Create routing list' 24 - Add some patrons, and a note, save 25 - Click 'save and preview' and ensure item displays correctly 26 - In the opac, add soem tags to a record (TagsEnabled system preference must be on, add from details page) 27 - In staff client browse to tools->tags, approve tag, click on term in the approved list 28 - Confirm items show correctly on the list 29 - Create a list on staff client (add items from search to new list) 30 - Send the list (Lists->clkick list name-> Send list) 31 - Confirm it is ofrmatted correctly 32 - Send list from OPAC and confirm it displays correctlyin email as well -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #36 from Nick Clemens <nick@bywatersolutions.com> --- Rough test plan - Jonathan, at one point you switch from item.onloan to item.checkout - do we need this extra fetch? onloan both tells us if checked out, and provides due date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nick Clemens from comment #36)
Rough test plan - Jonathan, at one point you switch from item.onloan to item.checkout - do we need this extra fetch? onloan both tells us if checked out, and provides due date
Maybe because onloan is only the date, but doesn't have the time? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Nick Clemens from comment #36)
Rough test plan - Jonathan, at one point you switch from item.onloan to item.checkout - do we need this extra fetch? onloan both tells us if checked out, and provides due date
From opac-reserve:
- my $issue = Koha::Checkouts->find( { itemnumber => $itemNum } ); - if ( $issue ) { - $itemLoopIter->{dateDue} = output_pref({ dt => dt_from_string($issue->date_due, 'sql'), as_due_date => 1 }); - $itemLoopIter->{onloan} = 'onloan'; So "onloan" was actually coming from item->checkout. Also: [% IF ( itemLoo.dateDue ) %] - <span class="checkedout">Due [% itemLoo.dateDue | html %]</span> + [% IF ( itemLoo.checkout.date_due) %] + <span class="checkedout">Due [% itemLoo.checkout.date_due| $KohaDates as_due_date => 1 %]</span> => We need the date_due from issue->checkout anyway. Thanks a lot for the test plan, Nick! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135648|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135649|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135650|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135651|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135652|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135653|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135654|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135655|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135656|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135657|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135658|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135659|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135642|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135643|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135644|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135645|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135646|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135647|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/joubu/Ko | |ha/-/commits/bug_27272 Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com --- Comment #39 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- See the following remote branch for the patches rebased against master: https://gitlab.com/joubu/Koha/-/commits/bug_27272 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi Status|Needs Signoff |Failed QA --- Comment #40 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- I found some issues: - Commit "Bug 27272: basket/basket" breaks opening the basket:
Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt line 235: unexpected token (ELSE)
- Commit "Bug 27272: basket/sendbasket" seems to break sending the basket via email (need to fix the aformentioned basket opening bug too to get here), it complained about uncovered tests. - The patch "Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo" needs to come after all the calls have been removed. - Most of the commit titles don't describe the change, please add the descriptions. I will continue review after these issues has been addressed, and also the bugs in the dependency this bug relies on have been fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #41 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Joonas Kylmälä from comment #40)
I found some issues:
Fixed! Remote branch adjusted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 30885, which changed state. Bug 30885 Summary: Recall - detail page explosion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30885 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 30886, which changed state. Bug 30886 Summary: Recall status cannot be correct on OPAC detail page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30886 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #32)
Ha, and question, see catalogue/detail.pl We are using an order_by that was initially used in GetItemsInfo. Should it be the default order by for all item searches? I am also stuck trying to replicate the previous order_by behaviour for serials (see the FIXME there)
I wonder if we should add ordering into the Koha::Biblio->items method? I'm not sure how it would/could affect embedding/prefetching/joining/caching... But it would be nice to consistently order.. binding on whether the bib is a serial or otherwise to get the 'right' ordering? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Remote branch rebased against master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #42)
(In reply to Jonathan Druart from comment #32)
Ha, and question, see catalogue/detail.pl We are using an order_by that was initially used in GetItemsInfo. Should it be the default order by for all item searches? I am also stuck trying to replicate the previous order_by behaviour for serials (see the FIXME there)
I wonder if we should add ordering into the Koha::Biblio->items method?
I'm not sure how it would/could affect embedding/prefetching/joining/caching...
But it would be nice to consistently order.. binding on whether the bib is a serial or otherwise to get the 'right' ordering?
Maybe we should have an explicit "search ordered" method? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stalkernoid@gmail.com Assignee|jonathan.druart+koha@gmail. |stalkernoid@gmail.com |com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #45 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Remote branch rebased against master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30847 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 [Bug 30847] Cleanup opac-reserve.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #46 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Doesn't apply anymore against latest master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #47 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Remote branch rebased against master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think I agreed to the idea of explicit search_ordered.. thus calling it chained to get the order one wants in each case.. Can you now actually pass ordering in as attributes to the relation accessor anyway too already? $biblio->items({},{ order_by => whatever }); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #49 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Petro, are you working on this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #50 from Peter Vashchuk <stalkernoid@gmail.com> --- Yes, I'm on it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #51 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137966&action=edit Bug 27272: Remove type= from detail.pl This is not related to anything known.. was it "itype" at some point? `git log -p` will tell you that it's there for a looong time already -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #52 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137967&action=edit Bug 27272: Remove GetItemsInfo from basket/basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #53 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137968&action=edit Bug 27272: Remove GetItemsInfo from basket/sendbasket Why are we display with $raw? Why are we display the location code instead of the AV's lib? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #54 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137969&action=edit Bug 27272: Remove GetItemsInfo from catalogue/imageviewer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #55 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137970&action=edit Bug 27272: Remove GetItemsInfo labels/label-item-search It was commented anyway -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #56 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137971&action=edit Bug 27272: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl Hum... Item2Marc ok here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #57 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137972&action=edit Bug 27272: Remove GetItemsInfo from opac-detail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #58 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137973&action=edit Bug 27272: Remove 'already_reserved' flag from opac-reserve.pl It was never set (was set before 14695) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #59 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137974&action=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from opac-reserve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #60 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137975&action=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from moredetail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #61 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137976&action=edit Bug 27272: Remove GetItemsInfo from opac-sendbasket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #62 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137977&action=edit Bug 27272: Remove GetItemsInfo import from opac-tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #63 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137978&action=edit Bug 27272: Remove GetItemsInfo from serials/routing-preview -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #64 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137979&action=edit Bug 27272: Remove GetItemsInfo from tags/list.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #65 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137980&action=edit Bug 27272: Remove GetItemsInfo from virtualshelves/sendshelf.pl And GetItemsLocationInfo from shelves.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #66 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137981&action=edit Bug 27272: Remove GetItemsInfo from catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #67 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137982&action=edit Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://gitlab.com/joubu/Ko | |ha/-/commits/bug_27272 | --- Comment #68 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Patches from remote branch have been attached here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #69 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 138109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138109&action=edit Bug 27272: Add search_ordered sub to order items with extra conditions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|stalkernoid@gmail.com |jonathan.druart+koha@gmail. | |com --- Comment #70 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I am writing tests for the last patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #71 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138296&action=edit Bug 27272: Allow to pass params and attributes to search_ordered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #72 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138297&action=edit Bug 27272: Add tests for search_ordered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #73 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138298&action=edit Bug 27272: Call search_ordered when GetItemsInfo was called before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off --- Comment #74 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Back to NQA. Thanks, Petro! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137981|0 |1 is obsolete| | --- Comment #75 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138303&action=edit Bug 27272: Remove GetItemsInfo from catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137982|0 |1 is obsolete| | --- Comment #76 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138304&action=edit Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138109|0 |1 is obsolete| | --- Comment #77 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138305&action=edit Bug 27272: Add search_ordered sub to order items with extra conditions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138296|0 |1 is obsolete| | --- Comment #78 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138306&action=edit Bug 27272: Allow to pass params and attributes to search_ordered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138297|0 |1 is obsolete| | --- Comment #79 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138307&action=edit Bug 27272: Add tests for search_ordered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138298|0 |1 is obsolete| | --- Comment #80 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138308&action=edit Bug 27272: Call search_ordered when GetItemsInfo was called before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #81 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Did some testing, no code review yet but noticed the following problems: 1. Going to a serial biblio's detail page fails on opac, e.g. page http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 on KTD.
DBIx::Class::ResultSource::_resolve_join(): No such relationship serial on Item at /kohadevbox/koha/Koha/Objects.pm line 421
Same error on the detail.pl on the staff side. 2. Go to any biblio's OPAC detail page, checkout an item for that biblio and notice the Status column is not updated and it still shows "Available". Before applying these patches the status was "Checked out" 3. serials/routing-preview.pl doesn't display the branch name anymore. Will continue testing after this, there are still some things I want to test on the biblio detail pages that I cannot due to the internal server errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138305|0 |1 is obsolete| | --- Comment #82 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138437&action=edit Bug 27272: Add search_ordered sub to order items with extra conditions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138306|0 |1 is obsolete| | --- Comment #83 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138438&action=edit Bug 27272: Allow to pass params and attributes to search_ordered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138307|0 |1 is obsolete| | --- Comment #84 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138439&action=edit Bug 27272: Add tests for search_ordered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138308|0 |1 is obsolete| | --- Comment #85 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138440&action=edit Bug 27272: Call search_ordered when GetItemsInfo was called before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #86 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138441&action=edit Bug 27272: Fix availability - OPAC Has to move some code to a method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #87 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138442&action=edit Bug 27272: Fix library display on routing slip - to squash -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #88 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Joonas Kylmälä from comment #81) Thanks, Joonas!
Did some testing, no code review yet but noticed the following problems:
1. Going to a serial biblio's detail page fails on opac, e.g. page http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 on KTD.
DBIx::Class::ResultSource::_resolve_join(): No such relationship serial on Item at /kohadevbox/koha/Koha/Objects.pm line 421
Same error on the detail.pl on the staff side.
My tests were wrong but passing! It's fixed now.
2. Go to any biblio's OPAC detail page, checkout an item for that biblio and notice the Status column is not updated and it still shows "Available". Before applying these patches the status was "Checked out"
Should be fixed, but this area is a mess. Hard to keep things clean, the idea here is to not get worse. We should focus on that once this bug is pushed.
3. serials/routing-preview.pl doesn't display the branch name anymore.
Will continue testing after this, there are still some things I want to test on the biblio detail pages that I cannot due to the internal server errors.
Oops, fixed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137966|0 |1 is obsolete| | --- Comment #89 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138553&action=edit Bug 27272: Remove type= from detail.pl This is not related to anything known.. was it "itype" at some point? `git log -p` will tell you that it's there for a looong time already -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137967|0 |1 is obsolete| | --- Comment #90 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138554&action=edit Bug 27272: Remove GetItemsInfo from basket/basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137968|0 |1 is obsolete| | --- Comment #91 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138555&action=edit Bug 27272: Remove GetItemsInfo from basket/sendbasket Why are we display with $raw? Why are we display the location code instead of the AV's lib? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137969|0 |1 is obsolete| | --- Comment #92 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138556&action=edit Bug 27272: Remove GetItemsInfo from catalogue/imageviewer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137970|0 |1 is obsolete| | --- Comment #93 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138557&action=edit Bug 27272: Remove GetItemsInfo labels/label-item-search It was commented anyway -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137971|0 |1 is obsolete| | --- Comment #94 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138558&action=edit Bug 27272: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl Hum... Item2Marc ok here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137972|0 |1 is obsolete| | --- Comment #95 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138559&action=edit Bug 27272: Remove GetItemsInfo from opac-detail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137973|0 |1 is obsolete| | --- Comment #96 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138560&action=edit Bug 27272: Remove 'already_reserved' flag from opac-reserve.pl It was never set (was set before 14695) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137974|0 |1 is obsolete| | --- Comment #97 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138561&action=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from opac-reserve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137975|0 |1 is obsolete| | --- Comment #98 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138562&action=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from moredetail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137976|0 |1 is obsolete| | --- Comment #99 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138563&action=edit Bug 27272: Remove GetItemsInfo from opac-sendbasket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137977|0 |1 is obsolete| | --- Comment #100 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138564&action=edit Bug 27272: Remove GetItemsInfo import from opac-tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137978|0 |1 is obsolete| | --- Comment #101 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138565&action=edit Bug 27272: Remove GetItemsInfo from serials/routing-preview -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137979|0 |1 is obsolete| | --- Comment #102 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138566&action=edit Bug 27272: Remove GetItemsInfo from tags/list.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137980|0 |1 is obsolete| | --- Comment #103 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138567&action=edit Bug 27272: Remove GetItemsInfo from virtualshelves/sendshelf.pl And GetItemsLocationInfo from shelves.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138303|0 |1 is obsolete| | --- Comment #104 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138568&action=edit Bug 27272: Remove GetItemsInfo from catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138304|0 |1 is obsolete| | --- Comment #105 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138569&action=edit Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138437|0 |1 is obsolete| | --- Comment #106 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138570&action=edit Bug 27272: Add search_ordered sub to order items with extra conditions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138438|0 |1 is obsolete| | --- Comment #107 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138571&action=edit Bug 27272: Allow to pass params and attributes to search_ordered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138439|0 |1 is obsolete| | --- Comment #108 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138572&action=edit Bug 27272: Add tests for search_ordered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138440|0 |1 is obsolete| | --- Comment #109 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138573&action=edit Bug 27272: Call search_ordered when GetItemsInfo was called before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138441|0 |1 is obsolete| | --- Comment #110 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138574&action=edit Bug 27272: Fix availability - OPAC Has to move some code to a method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138442|0 |1 is obsolete| | --- Comment #111 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138575&action=edit Bug 27272: Fix library display on routing slip - to squash -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #112 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Rebased. It was tough, one patch blew up with the infamous: error: sha1 information is lacking or useless (opac/opac-detail.pl). error: could not build fake ancestor Patch failed at 0001 Bug 27272: Remove GetItemsInfo from opac-detail But thankfully it was possible to use your repo https://gitlab.com/joubu/Koha/-/commits/bug_27272/ The latest patches aren't there so it wasn't possible to it directly (and I wasn't certain the existing commits were at their latest version). But! Getting just the problematic commit and applying it worked :D And the rest applied without issue on top of master. Comparing the diffs of the previous "Remove GetItemsInfo from opac-detail" from this ticket and the rebased on showed no difference in the changed lines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #113 from Victor Grousset/tuxayo <victor@tuxayo.net> --- The test suite passes. --- Here is the only complain from the QA script: FAIL C4/Items.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 Is it legit? --- Tell me (Jonathan or a QAer that looks into this) if there is particular stuff to test manually. For lack of clues I just reread all the patches in case there where something obviously suspicious. I haven't done development with those functions and in all the places they are used so I can't tell if the replacement of GetItemsInfo & co is correct. Let's move on and see what QA has to say. These kind of patches with nothing clear to test can easily get stuck forever waiting for SO because testers don't know what to do. I would happily come back if there is precise stuff to test manually. Thanks Jonathan for the big refactoring! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138553|0 |1 is obsolete| | --- Comment #114 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138614&action=edit Bug 27272: Remove type= from detail.pl This is not related to anything known.. was it "itype" at some point? `git log -p` will tell you that it's there for a looong time already Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138554|0 |1 is obsolete| | --- Comment #115 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138615&action=edit Bug 27272: Remove GetItemsInfo from basket/basket Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138555|0 |1 is obsolete| | --- Comment #116 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138616&action=edit Bug 27272: Remove GetItemsInfo from basket/sendbasket Why are we display with $raw? Why are we display the location code instead of the AV's lib? Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138556|0 |1 is obsolete| | --- Comment #117 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138617&action=edit Bug 27272: Remove GetItemsInfo from catalogue/imageviewer Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138557|0 |1 is obsolete| | --- Comment #118 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138618&action=edit Bug 27272: Remove GetItemsInfo labels/label-item-search It was commented anyway Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138558|0 |1 is obsolete| | --- Comment #119 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138619&action=edit Bug 27272: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl Hum... Item2Marc ok here? Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138559|0 |1 is obsolete| | --- Comment #120 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138620&action=edit Bug 27272: Remove GetItemsInfo from opac-detail Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138560|0 |1 is obsolete| | --- Comment #121 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138621&action=edit Bug 27272: Remove 'already_reserved' flag from opac-reserve.pl It was never set (was set before 14695) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138561|0 |1 is obsolete| | --- Comment #122 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138622&action=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from opac-reserve Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138562|0 |1 is obsolete| | --- Comment #123 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138623&action=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from moredetail Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138563|0 |1 is obsolete| | --- Comment #124 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138624&action=edit Bug 27272: Remove GetItemsInfo from opac-sendbasket Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138564|0 |1 is obsolete| | --- Comment #125 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138625&action=edit Bug 27272: Remove GetItemsInfo import from opac-tags Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138565|0 |1 is obsolete| | --- Comment #126 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138626&action=edit Bug 27272: Remove GetItemsInfo from serials/routing-preview Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138566|0 |1 is obsolete| | --- Comment #127 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138627&action=edit Bug 27272: Remove GetItemsInfo from tags/list.pl Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138567|0 |1 is obsolete| | --- Comment #128 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138628&action=edit Bug 27272: Remove GetItemsInfo from virtualshelves/sendshelf.pl And GetItemsLocationInfo from shelves.pl Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138568|0 |1 is obsolete| | --- Comment #129 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138629&action=edit Bug 27272: Remove GetItemsInfo from catalogue/detail.pl Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138569|0 |1 is obsolete| | --- Comment #130 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138630&action=edit Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138570|0 |1 is obsolete| | --- Comment #131 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138631&action=edit Bug 27272: Add search_ordered sub to order items with extra conditions Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138571|0 |1 is obsolete| | --- Comment #132 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138632&action=edit Bug 27272: Allow to pass params and attributes to search_ordered Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138572|0 |1 is obsolete| | --- Comment #133 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138633&action=edit Bug 27272: Add tests for search_ordered Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138573|0 |1 is obsolete| | --- Comment #134 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138634&action=edit Bug 27272: Call search_ordered when GetItemsInfo was called before Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138574|0 |1 is obsolete| | --- Comment #135 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138635&action=edit Bug 27272: Fix availability - OPAC Has to move some code to a method Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138575|0 |1 is obsolete| | --- Comment #136 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138636&action=edit Bug 27272: Fix library display on routing slip - to squash Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #137 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (the only thing found when reviewing was a minor typo on a FIXME comment. It was fixed by amending the commit. holding_branc => holding_branch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #138 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There is a test plan in comment 35. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #139 from Victor Grousset/tuxayo <victor@tuxayo.net> --- oh I missed it, thanks, I'll apply it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #140 from Nick Clemens <nick@bywatersolutions.com> --- patch needs minor rebase opac-details: Template process failed: undef error - The method Koha::Item->transfertwhen is not covered by tests! --from item-status-schema-org Itemtype icons no longer displaying in staff interface That's all I can touch right now. If you do not object to this becoming an omnibus and breaking it apart I will work through it in sections. I am happy to create the new bugs to help. This is fairly large in current state - I have some slight concerns about increased db fetches with this change and would like to be bale to focus on smaller bits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138614|0 |1 is obsolete| | --- Comment #141 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138714&action=edit Bug 27272: Remove type= from detail.pl This is not related to anything known.. was it "itype" at some point? `git log -p` will tell you that it's there for a looong time already -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138615|0 |1 is obsolete| | --- Comment #142 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138715&action=edit Bug 27272: Remove GetItemsInfo from basket/basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138616|0 |1 is obsolete| | --- Comment #143 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138716&action=edit Bug 27272: Remove GetItemsInfo from basket/sendbasket Why are we display with $raw? Why are we display the location code instead of the AV's lib? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138617|0 |1 is obsolete| | --- Comment #144 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138717&action=edit Bug 27272: Remove GetItemsInfo from catalogue/imageviewer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138618|0 |1 is obsolete| | --- Comment #145 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138718&action=edit Bug 27272: Remove GetItemsInfo labels/label-item-search It was commented anyway -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138619|0 |1 is obsolete| | --- Comment #146 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138719&action=edit Bug 27272: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl Hum... Item2Marc ok here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138620|0 |1 is obsolete| | --- Comment #147 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138720&action=edit Bug 27272: Remove GetItemsInfo from opac-detail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138621|0 |1 is obsolete| | --- Comment #148 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138721&action=edit Bug 27272: Remove 'already_reserved' flag from opac-reserve.pl It was never set (was set before 14695) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138622|0 |1 is obsolete| | --- Comment #149 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138722&action=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from opac-reserve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138623|0 |1 is obsolete| | --- Comment #150 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138723&action=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from moredetail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138624|0 |1 is obsolete| | --- Comment #151 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138724&action=edit Bug 27272: Remove GetItemsInfo from opac-sendbasket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138625|0 |1 is obsolete| | --- Comment #152 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138725&action=edit Bug 27272: Remove GetItemsInfo import from opac-tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138626|0 |1 is obsolete| | --- Comment #153 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138726&action=edit Bug 27272: Remove GetItemsInfo from serials/routing-preview -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138627|0 |1 is obsolete| | --- Comment #154 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138727&action=edit Bug 27272: Remove GetItemsInfo from tags/list.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138628|0 |1 is obsolete| | --- Comment #155 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138728&action=edit Bug 27272: Remove GetItemsInfo from virtualshelves/sendshelf.pl And GetItemsLocationInfo from shelves.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138629|0 |1 is obsolete| | --- Comment #156 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138729&action=edit Bug 27272: Remove GetItemsInfo from catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138630|0 |1 is obsolete| | --- Comment #157 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138730&action=edit Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138631|0 |1 is obsolete| | --- Comment #158 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138731&action=edit Bug 27272: Add search_ordered sub to order items with extra conditions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138632|0 |1 is obsolete| | --- Comment #159 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138732&action=edit Bug 27272: Allow to pass params and attributes to search_ordered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138633|0 |1 is obsolete| | --- Comment #160 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138733&action=edit Bug 27272: Add tests for search_ordered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138634|0 |1 is obsolete| | --- Comment #161 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138734&action=edit Bug 27272: Call search_ordered when GetItemsInfo was called before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138635|0 |1 is obsolete| | --- Comment #162 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138735&action=edit Bug 27272: Fix availability - OPAC Has to move some code to a method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138636|0 |1 is obsolete| | --- Comment #163 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 138736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138736&action=edit Bug 27272: Fix library display on routing slip - to squash -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #164 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Nick Clemens from comment #140)
patch needs minor rebase
Here it is, hope that helps ^^ (Bug 31272 caused a bit of trouble with date stuff but it was solvable reliably :) )
That's all I can touch right now. If you do not object to this becoming an omnibus and breaking it apart I will work through it in sections. I am happy to create the new bugs to help.
I'm not Jonathan but to help: how could this be split? Like having a 1st ticket with the common work. And including a minor "Remove GetItemsInfo from XXX" And then having several tickets each with a large "Remove GetItemsInfo from XXX" And the minor ones grouped into a ticket. Would that work well? To have less ticket management overhead and simplify the maintenance during the review (the many rebases!), would it work well to keep everything here and have multiple people review it? Like you could focus on only some of the "Remove GetItemsInfo from XXX" patches. The signed-off lines would keep track on the which patches are QAed and which aren't. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #165 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Issue found: 1. Apply the patches (with or without bug 30847) 2. Go to the OPAC 3. Go to any record details page 4. it blows up Template process failed: undef error - The method Koha::Item->transfertwhen is not covered by tests! Another issue found: 1. after from test plan: step 14 - Receive/find an issue with an item, view in opac 2. go to the staff detail page of the record 3. it blows up Template process failed: undef error - The method Koha::Serial::Item->publisheddate is not covered by tests! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138714|0 |1 is obsolete| | Attachment #138715|0 |1 is obsolete| | Attachment #138716|0 |1 is obsolete| | Attachment #138717|0 |1 is obsolete| | Attachment #138718|0 |1 is obsolete| | Attachment #138719|0 |1 is obsolete| | Attachment #138720|0 |1 is obsolete| | Attachment #138721|0 |1 is obsolete| | Attachment #138722|0 |1 is obsolete| | Attachment #138723|0 |1 is obsolete| | Attachment #138724|0 |1 is obsolete| | Attachment #138725|0 |1 is obsolete| | Attachment #138726|0 |1 is obsolete| | Attachment #138727|0 |1 is obsolete| | Attachment #138728|0 |1 is obsolete| | Attachment #138729|0 |1 is obsolete| | Attachment #138730|0 |1 is obsolete| | Attachment #138731|0 |1 is obsolete| | Attachment #138732|0 |1 is obsolete| | Attachment #138733|0 |1 is obsolete| | Attachment #138734|0 |1 is obsolete| | Attachment #138735|0 |1 is obsolete| | Attachment #138736|0 |1 is obsolete| | --- Comment #166 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138773&action=edit Bug 27272: Remove type= from detail.pl This is not related to anything known.. was it "itype" at some point? `git log -p` will tell you that it's there for a looong time already -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #167 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138774&action=edit Bug 27272: Remove GetItemsInfo from basket/basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #168 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138775&action=edit Bug 27272: Remove GetItemsInfo from basket/sendbasket Why are we display with $raw? Why are we display the location code instead of the AV's lib? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #169 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138776&action=edit Bug 27272: Remove GetItemsInfo from catalogue/imageviewer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #170 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138777&action=edit Bug 27272: Remove GetItemsInfo labels/label-item-search It was commented anyway -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #171 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138778&action=edit Bug 27272: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl Hum... Item2Marc ok here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #172 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138779&action=edit Bug 27272: Remove GetItemsInfo from opac-detail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #173 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138780&action=edit Bug 27272: Remove 'already_reserved' flag from opac-reserve.pl It was never set (was set before 14695) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #174 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138781&action=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from opac-reserve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #175 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138782&action=edit Bug 27272: Remove GetHostItemsInfo and GetItemsInfo from moredetail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #176 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138783&action=edit Bug 27272: Remove GetItemsInfo from opac-sendbasket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #177 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138784&action=edit Bug 27272: Remove GetItemsInfo import from opac-tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #178 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138785&action=edit Bug 27272: Remove GetItemsInfo from serials/routing-preview -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #179 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138786&action=edit Bug 27272: Remove GetItemsInfo from tags/list.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #180 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138787&action=edit Bug 27272: Remove GetItemsInfo from virtualshelves/sendshelf.pl And GetItemsLocationInfo from shelves.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #181 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138788&action=edit Bug 27272: Remove GetItemsInfo from catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #182 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138789&action=edit Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #183 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138790&action=edit Bug 27272: Add search_ordered sub to order items with extra conditions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #184 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138791&action=edit Bug 27272: Allow to pass params and attributes to search_ordered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #185 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138792&action=edit Bug 27272: Add tests for search_ordered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #186 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138793&action=edit Bug 27272: Call search_ordered when GetItemsInfo was called before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #187 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138794&action=edit Bug 27272: Fix availability - OPAC Has to move some code to a method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #188 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Nick Clemens from comment #140)
patch needs minor rebase
opac-details: Template process failed: undef error - The method Koha::Item->transfertwhen is not covered by tests! --from item-status-schema-org
Fixed.
Itemtype icons no longer displaying in staff interface
Fixed.
That's all I can touch right now. If you do not object to this becoming an omnibus and breaking it apart I will work through it in sections. I am happy to create the new bugs to help.
This is fairly large in current state - I have some slight concerns about increased db fetches with this change and would like to be bale to focus on smaller bits
Which areas exactly? I am pretty sure we going globally to do better with this move, the query run by GetItemsInfo is big and is certainly the cause of some slowness. We could split it up into several bugs, but my feeling is that it will add extra work (new bug report, more people involved in SO+QA, more time to get it in, can be released into 22.11 without all the work done, follow-ups can be harder, same for revert if we need it) for not much benefit. (In reply to Victor Grousset/tuxayo from comment #165)
Issue found:
1. Apply the patches (with or without bug 30847) 2. Go to the OPAC 3. Go to any record details page 4. it blows up Template process failed: undef error - The method Koha::Item->transfertwhen is not covered by tests!
This is what Nick reported.
Another issue found: 1. after from test plan: step 14 - Receive/find an issue with an item, view in opac 2. go to the staff detail page of the record 3. it blows up Template process failed: undef error - The method Koha::Serial::Item->publisheddate is not covered by tests!
Fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #189 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #188)
I am pretty sure we going globally to do better with this move, the query run by GetItemsInfo is big and is certainly the cause of some slowness.
It's the same query as GetItemsForInventory - afaict from some profiling that is much faster than our other methods, big query, but run once
We could split it up into several bugs, but my feeling is that it will add extra work (new bug report, more people involved in SO+QA, more time to get it in, can be released into 22.11 without all the work done, follow-ups can be harder, same for revert if we need it) for not much benefit.
Each patch that only deals with a single script is easier to SO/QA/rebase/revert if needed - removal from a single script doesn't rely on the other patches. The patches near the end with search ordered can be their own, the will touch more, but it is just verifying a single routine work It will be more people - but I think that's the benefit - more people reviewing the areas they know. When the sets are this big it is often a large commitment from a single person, and reviewing on a large level often comes out to: "Good enough, seems solid, let's catch the bugs after" I see the negative with a single bug as: large rebases/large testing plans/large time commitment and I don't see the benefit of this. Large patches move slower -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #190 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Rebased are a nightmare when you need to maintain patches from several bug report... Anyway, I will create the bug reports and move the patches, if you think it can help. Prove me I am wrong! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #191 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #166)
Created attachment 138773 [details] [review] Bug 27272: Remove type= from detail.pl
This is not related to anything known.. was it "itype" at some point? `git log -p` will tell you that it's there for a looong time already
Moved to bug 31305. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #192 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #173)
Created attachment 138780 [details] [review] Bug 27272: Remove 'already_reserved' flag from opac-reserve.pl
It was never set (was set before 14695)
Moved to bug 31307. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #193 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #183)
Created attachment 138790 [details] [review] Bug 27272: Add search_ordered sub to order items with extra conditions
(In reply to Jonathan Druart from comment #184)
Created attachment 138791 [details] [review] Bug 27272: Allow to pass params and attributes to search_ordered
(In reply to Jonathan Druart from comment #185)
Created attachment 138792 [details] [review] Bug 27272: Add tests for search_ordered
Moved to bug 31306. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31308 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31308 [Bug 31308] Remove GetItemsInfo from basket/basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31309 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31309 [Bug 31309] Remove GetItemsInfo from basket/sendbasket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31310 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31310 [Bug 31310] Remove GetItemsInfo from catalogue/imageviewer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31311 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31311 [Bug 31311] Remove GetItemsInfo from labels/label-item-search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31312 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31312 [Bug 31312] Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31313 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 [Bug 31313] Remove GetItemsInfo from opac-detail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31314 [Bug 31314] Remove GetItemsInfo from opac-reserve.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31315 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 [Bug 31315] Remove GetItemsInfo from moredetail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31316 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31316 [Bug 31316] Remove GetItemsInfo from opac-sendbasket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31317 [Bug 31317] Remove GetItemsInfo from opac-tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31318 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31318 [Bug 31318] Remove GetItemsInfo from serials/routing-preview -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31319 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31319 [Bug 31319] Remove GetItemsInfo from tags/list.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31320 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31320 [Bug 31320] Remove GetItemsInfo from virtualshelves/sendshelf.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31321 [Bug 31321] Remove GetItemsInfo from catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|30847 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30847 [Bug 30847] Cleanup opac-reserve.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138773|0 |1 is obsolete| | Attachment #138774|0 |1 is obsolete| | Attachment #138775|0 |1 is obsolete| | Attachment #138776|0 |1 is obsolete| | Attachment #138777|0 |1 is obsolete| | Attachment #138778|0 |1 is obsolete| | Attachment #138779|0 |1 is obsolete| | Attachment #138780|0 |1 is obsolete| | Attachment #138781|0 |1 is obsolete| | Attachment #138782|0 |1 is obsolete| | Attachment #138783|0 |1 is obsolete| | Attachment #138784|0 |1 is obsolete| | Attachment #138785|0 |1 is obsolete| | Attachment #138786|0 |1 is obsolete| | Attachment #138787|0 |1 is obsolete| | Attachment #138788|0 |1 is obsolete| | Attachment #138789|0 |1 is obsolete| | Attachment #138790|0 |1 is obsolete| | Attachment #138791|0 |1 is obsolete| | Attachment #138792|0 |1 is obsolete| | Attachment #138793|0 |1 is obsolete| | Attachment #138794|0 |1 is obsolete| | --- Comment #194 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138832&action=edit Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo With the different bug reports we removed the calls for those 3 subroutines. We can remove them now. Test plan: git grep their names and you should not find any occurrences in the code base -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #195 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Bug 31308 - Remove GetItemsInfo from basket/basket Bug 31309 - Remove GetItemsInfo from basket/sendbasket Bug 31310 - Remove GetItemsInfo from catalogue/imageviewer Bug 31311 - Remove GetItemsInfo from labels/label-item-search Bug 31312 - Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl Bug 31313 - Remove GetItemsInfo from opac-detail Bug 31314 - Remove GetItemsInfo from opac-reserve.pl Bug 31315 - Remove GetItemsInfo from moredetail Bug 31316 - Remove GetItemsInfo from opac-sendbasket Bug 31317 - Remove GetItemsInfo from opac-tags Bug 31318 - Remove GetItemsInfo from serials/routing-preview Bug 31319 - Remove GetItemsInfo from tags/list.pl Bug 31320 - Remove GetItemsInfo from virtualshelves/sendshelf.pl Bug 31321 - Remove GetItemsInfo from catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #196 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The ugly job is done. (repeating myself) I don't think it's the way we should move this forward, but I am just doing what others think it's best. That won't help rebase (QA will submit follow-ups on the different bugs and so more conflicts), the code may differ from when the first patch has been pushed and the last one, we could end up with only a part of the patches pushed in a major release, behaviours may be different between views, git log won't have them grouped, etc. That's why I suggest to push everything at once, even if this is split now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #197 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #196)
The ugly job is done.
(repeating myself) I don't think it's the way we should move this forward, but I am just doing what others think it's best. That won't help rebase (QA will submit follow-ups on the different bugs and so more conflicts), the code may differ from when the first patch has been pushed and the last one, we could end up with only a part of the patches pushed in a major release, behaviours may be different between views, git log won't have them grouped, etc.
That's why I suggest to push everything at once, even if this is split now.
No worries. We are gonna make this a team effort as it is part of the roadmap, and we are all engaged. Rebasing won't be a problem. Great job, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Large patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138832|0 |1 is obsolete| | --- Comment #198 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 139928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139928&action=edit Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo With the different bug reports we removed the calls for those 3 subroutines. We can remove them now. Test plan: git grep their names and you should not find any occurrences in the code base Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #199 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Trivial removal of unused subroutines, fast forwarding directly to PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #200 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Text to go in the| |Another step on the old release notes| |code refactoring. At this | |time, related to item | |information display. | | | |There | |are several DB queries that | |get avoided with this | |change as well, leading to | |more performant processing | |of requests. Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 31319, which changed state. Bug 31319 Summary: Remove GetItemsInfo from tags/list.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31319 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 31316, which changed state. Bug 31316 Summary: Remove GetItemsInfo from opac-sendbasket https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31316 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 31311, which changed state. Bug 31311 Summary: Remove GetItemsInfo from labels/label-item-search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31311 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 31308, which changed state. Bug 31308 Summary: Remove GetItemsInfo from basket/basket https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31308 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 31309, which changed state. Bug 31309 Summary: Remove GetItemsInfo from basket/sendbasket https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31309 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 31313, which changed state. Bug 31313 Summary: Remove GetItemsInfo from opac-detail https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31313 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 31312, which changed state. Bug 31312 Summary: Remove GetItemsInfo from misc/migration_tools/rebuild_zebra.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31312 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 29697, which changed state. Bug 29697 Summary: Replace GetMarcBiblio occurrences with $biblio->metadata->record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 31321, which changed state. Bug 31321 Summary: Remove GetItemsInfo from catalogue/detail.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31321 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug 27272 depends on bug 31315, which changed state. Bug 31315 Summary: Remove GetItemsInfo from moredetail https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31315 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32445 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 [Bug 32445] Status display of 'not for loan' items is broken in OPAC/staff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32555 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32555 [Bug 32555] Error when viewing serial in OPAC -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org