https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi Status|Needs Signoff |Failed QA --- Comment #40 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- I found some issues: - Commit "Bug 27272: basket/basket" breaks opening the basket:
Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt line 235: unexpected token (ELSE)
- Commit "Bug 27272: basket/sendbasket" seems to break sending the basket via email (need to fix the aformentioned basket opening bug too to get here), it complained about uncovered tests. - The patch "Bug 27272: Remove GetItemsInfo, GetItemsLocationInfo and GetHostItemsInfo" needs to come after all the calls have been removed. - Most of the commit titles don't describe the change, please add the descriptions. I will continue review after these issues has been addressed, and also the bugs in the dependency this bug relies on have been fixed. -- You are receiving this mail because: You are watching all bug changes.