https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39374 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 179494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179494&action=edit Bug 39374: Add feature to block sending of lists from OPAC This change adds a system preference OPACDisableSendList which disables the ability to send lists from the OPAC, and hides the "Send list" link on the opac-shelves.pl page. This is useful in situations where you do not want OPAC users to be able to generate emails to arbitrary addresses with arbitrary comments. Test plan: 0. Apply the patch and koha-plack --restart kohadev 1. Create a public list with at least one record and view it in the OPAC 2. Click "Send list" and note you can fill out boxes for "Email address" and "Comment" 3. Change syspref OPACDisableSendList to "Don't allow" and click "Send list" again 4. Note the popup window now says "You do not have permission to send this list." 5. Reload the list web page and notice "Send list" no longer appears on the toolbar next to "Print list" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39374 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39374 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179494|0 |1 is obsolete| | --- Comment #3 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 179983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179983&action=edit Bug 39374: Add feature to block sending of lists from OPAC This change adds a system preference OPACDisableSendList which disables the ability to send lists from the OPAC, and hides the "Send list" link on the opac-shelves.pl page. This is useful in situations where you do not want OPAC users to be able to generate emails to arbitrary addresses with arbitrary comments. Test plan: 0. Apply the patch and koha-plack --restart kohadev 1. Create a public list with at least one record and view it in the OPAC 2. Click "Send list" and note you can fill out boxes for "Email address" and "Comment" 3. Change syspref OPACDisableSendList to "Don't allow" and click "Send list" again 4. Note the popup window now says "You do not have permission to send this list." 5. Reload the list web page and notice "Send list" no longer appears on the toolbar next to "Print list" Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39374 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |brendan@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39374 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #5)

However it is a bit weird to have a button that will anyway tell you that you don't have the right. The information should be at the level of the button.

Hence, the patch should gray out the icon and add a tooltip or could even remove the button since it is a setting from the instance : no user have access to the functionnality if it is disabled on the opac.

From memory, I thought that I was hiding/removing the button. Did I miss one? Let me know where it is and I'll nuke it.

(I was trying to cover all bases, so that the Perl controller script would reject the action if someone managed to bypass the restriction in the view, or if they had a cached view or they were trying to send as someone was disabling it and so on.) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39374 --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Oh nvm it's fine, I stopped at 4 and was thinking it was weird :) I think the pref in the yaml file is missing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39374 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39374 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179984|0 |1 is obsolete| | --- Comment #11 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 181054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181054&action=edit Bug 39374: Database changes Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39374 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |New system preference release notes| |"OPACDisableSendList" | |provides libraries the | |option to disable the | |ability to send lists from | |the OPAC, and hides the | |"Send list" link on the | |opac-shelves.pl page. --- Comment #14 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #12)

I feel like this is more an enhancement than a bugfix. If you disagree, please add some notes!

I suppose arguments could be made either way? In a way, I think it's a deficiency in the current system, so the lack of it could be considered as a bug. On the other hand, one could argue it's a new feature for new functionality previously not available. I think I'm fine leaving it as an enhancement. Personally, I'll backport it to my own 24.11 soon. It's small enough that anyone wanting it should be able to do that reasonably easily I hope. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39374 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #15)

It's up to the RMaints to decide for an enhancement, but I feel it's more appropriate that way.

I was wondering, what about the cart email feature?

Maybe for a future bug report?

Yeah, I think future bug report. For the project that spawned a lot of this work, I was able to just turn off the cart completely, so it wasn't as urgent as the lists where we wanted to still use lists, but use them with more finely grained controls. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39374 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40546 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39374 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | Status|Pushed to main |Pushed to stable --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Very useful enhancement (considering bot activity), backported. Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39374 --- Comment #19 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #17)

Oh we need the same for sending cart :O

Agreed! Bug 39374 came up while I was locking down a Koha where the cart was just turned off, so I didn't get around to it, but it would definitely be a good addition. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39374 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #21 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.