[Bug 39022] New: Last patron is replaced by current patron on page load
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39022 Bug ID: 39022 Summary: Last patron is replaced by current patron on page load Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Before bug 21246 Koha only stored a single last patron - when loading a new patron we would preserve the previous patron during the initial page load. After loading we would replace the stored patron so that the next page load would display the most recent patron. After bug 21246 we began to update the list of patrons to display, add the new one, then display. This means as soon as you load a patron you cannot get back to the previous patron. To test: 1 - Enable showLastPatron system preference and set showLastPatronCount to 1 2 - Go to a patron, say Ronnie Ballard 3 - Note you have a link to 'Last patron' - hover or click split dropdown and see it is the patron you are viewing 4 - Search for another patron, Edna Acosta 5 - Note the 'Last patron' links point to Edna, and not Ronnie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39022 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39022 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177476&action=edit Bug 39022: Display the current previous patron list before updating stored values This patch just reverses the order so we display the list, then update it. To test: 1 - Enable showLastPatron system preference and set showLastPatronCount to 1 2 - Go to a patron, say Ronnie Ballard 3 - Note you have a link to 'Last patron' - hover or click split dropdown and see it is the patron you are viewing 4 - Search for another patron, Edna Acosta 5 - Note the 'Last patron' links point to Edna, and not Ronnie 6 - Apply patch 7 - Reload Edna, note last patron lists Edna 8 - Search for Ronnie 9 - Confirm previous patron is linked to Edna 10 - Click the link to go to Edna 11 - Confirm last patron now links to Ronnie 12 - Instead of following link, click on another tab for patron 13 - Now the link is updated to current patron, this was behaviour before 21246 as well 14 - Sign off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39022 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39022 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177476|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 177491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177491&action=edit Bug 39022: Display the current previous patron list before updating stored values This patch just reverses the order so we display the list, then update it. To test: 1 - Enable showLastPatron system preference and set showLastPatronCount to 1 2 - Go to a patron, say Ronnie Ballard 3 - Note you have a link to 'Last patron' - hover or click split dropdown and see it is the patron you are viewing 4 - Search for another patron, Edna Acosta 5 - Note the 'Last patron' links point to Edna, and not Ronnie 6 - Apply patch 7 - Reload Edna, note last patron lists Edna 8 - Search for Ronnie 9 - Confirm previous patron is linked to Edna 10 - Click the link to go to Edna 11 - Confirm last patron now links to Ronnie 12 - Instead of following link, click on another tab for patron 13 - Now the link is updated to current patron, this was behaviour before 21246 as well 14 - Sign off. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39022 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39022 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177491|0 |1 is obsolete| | --- Comment #3 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 177639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177639&action=edit Bug 39022: Display the current previous patron list before updating stored values This patch just reverses the order so we display the list, then update it. To test: 1 - Enable showLastPatron system preference and set showLastPatronCount to 1 2 - Go to a patron, say Ronnie Ballard 3 - Note you have a link to 'Last patron' - hover or click split dropdown and see it is the patron you are viewing 4 - Search for another patron, Edna Acosta 5 - Note the 'Last patron' links point to Edna, and not Ronnie 6 - Apply patch 7 - Reload Edna, note last patron lists Edna 8 - Search for Ronnie 9 - Confirm previous patron is linked to Edna 10 - Click the link to go to Edna 11 - Confirm last patron now links to Ronnie 12 - Instead of following link, click on another tab for patron 13 - Now the link is updated to current patron, this was behaviour before 21246 as well 14 - Sign off. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39022 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Signed Off |Passed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39022 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39022 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39022 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Version(s)|25.05.00 |25.05.00,24.11.08 released in| | --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 24.11.x for 24.11.08 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39022 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39022 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41074 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41074 [Bug 41074] Last patron links are shuffled and wrong patrons removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39022 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org