[Bug 20971] New: additem Corrupted storable string
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 Bug ID: 20971 Summary: additem Corrupted storable string Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@joensuu.fi QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Sometimes additem.pl will complain about "Storable::thaw failed to thaw LastCreatedItem-cookie.", see bug 14844. Now, actually fix the bug. The bug is caused by trying to URI (un)escape MARC::Record, binary data. We'll use a base64 url-safe version instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pasi.kallinen@joensuu.fi |ity.org | --- Comment #1 from paxed <pasi.kallinen@joensuu.fi> --- Created attachment 76223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76223&action=edit Perl script to demonstrate uri (un)escape problem and base64url correctness -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 --- Comment #2 from paxed <pasi.kallinen@joensuu.fi> --- Created attachment 76224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76224&action=edit Bug 20971: additem Corrupted storable string Sometimes additem.pl will complain about "Storable::thaw failed to thaw LastCreatedItem-cookie.", see bug 14844. Now, actually fix the bug. The bug is caused by trying to URI (un)escape MARC::Record, binary data. We'll use a base64 url-safe version instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14844 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #3 from Michal Denar <black23@gmail.com> --- Hi, some test plan? Thanks Mike -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #4 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Bump, any test plan to follow for this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Status|Needs Signoff |Failed QA --- Comment #5 from Liz Rea <wizzyrea@gmail.com> --- Hi, We can't test this without a plan, please provide one. :) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron@biblibre.c | |om Status|Failed QA |Needs Signoff --- Comment #6 from didier <didier.gautheron@biblibre.com> --- Hi Without this patch PrefillItem functionality is broken when adding unrelated items. TEST: 1: Set PrefillItem to 'The new item is prefilled...' 2: Set a SubfieldsToUseWhenPrefill, 'c' for example 3: Add a new item for biblio A with 'c' set. 4: Double check 'c' value is set for next new item A. 5: search and add a new item for biblio B 6: 'c' is not set Apply patch 7: logout, login 8: repeat steps 3, 4, and 5 . 9: now 'c' is set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|additem Corrupted storable |Corrupted storable string |string |breaks | |SubfieldsToUseWhenPrefill | |functionality Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 James O'Keeffe <jamespfk@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 James O'Keeffe <jamespfk@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76224|0 |1 is obsolete| | --- Comment #7 from James O'Keeffe <jamespfk@gmail.com> --- Created attachment 115257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115257&action=edit Bug 20971: additem Corrupted storable string Sometimes additem.pl will complain about "Storable::thaw failed to thaw LastCreatedItem-cookie.", see bug 14844. Now, actually fix the bug. The bug is caused by trying to URI (un)escape MARC::Record, binary data. We'll use a base64 url-safe version instead. Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: James O'Keeffe <jamespfk@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We've recently also run into this in a workshop - glad to find a fix here! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115257|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 115260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115260&action=edit Bug 20971: additem Corrupted storable string Sometimes additem.pl will complain about "Storable::thaw failed to thaw LastCreatedItem-cookie.", see bug 14844. Now, actually fix the bug. The bug is caused by trying to URI (un)escape MARC::Record, binary data. We'll use a base64 url-safe version instead. Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: James O'Keeffe <jamespfk@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you, James! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115260|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115332&action=edit Bug 20971: Prevent Storable::thaw to fail on LastCreatedItem Sometimes additem.pl will complain about "Storable::thaw failed to thaw LastCreatedItem-cookie.", see bug 14844. Now, actually fix the bug. The bug is caused by trying to URI (un)escape MARC::Record, binary data. We'll use a base64 url-safe version instead. Test plan: 1: Set PrefillItem to 'The new item is prefilled...' 2: Set a SubfieldsToUseWhenPrefill, 'c' for example 3: Add a new item for biblio A with 'c' set. 4: Double check 'c' value is set for next new item A. 5: search and add a new item for biblio B 6: 'c' is not set Apply patch 7: logout, login 8: repeat steps 3, 4, and 5 . 9: now 'c' is set. Signed-off-by: Pasi Kallinen <pasi.kallinen@joensuu.fi> Signed-off-by: James O'Keeffe <jamespfk@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> JD amended patch: fix commit title and add test plan Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.02 released in| | --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org