[Bug 26797] New: Error when trying to access Relative Checkouts between Professional and Organizational patron categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Bug ID: 26797 Summary: Error when trying to access Relative Checkouts between Professional and Organizational patron categories Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In Koha 20.05 and 19.11, when a Professional Patron Category patron and an Organizational patron category patron are linked, from the Professional patron, there is a tab to see the 'Relative Checkouts', but Koha just will spin and say processing. Koha is looking for a first name to link the relative checkouts from a professional to the linked Organizational patron. On an organizational patron, there is no first name and therefore Koha can not do the link. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 26796 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Version|20.05 |master --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Confirmed on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 114091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114091&action=edit Bug 26797: Escape firstname to prevent relative's checkouts to crash If no firstname is defined for a relative, the "Relative's checkouts" tab will be "processing" forever. JS error: TypeError: oObj.borrower.firstname is null Test plan: Patron A is Org and guarantor of patron B Check an item out to B Go to the details page of A, click "Relative's checkouts" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27133 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note that there is a UI issue display (header number mismatch). See bug 27133. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114091|0 |1 is obsolete| | --- Comment #5 from Kelly McElligott <kelly@bywatersolutions.com> --- Created attachment 114099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114099&action=edit Bug 26797: Escape firstname to prevent relative's checkouts to crash If no firstname is defined for a relative, the "Relative's checkouts" tab will be "processing" forever. JS error: TypeError: oObj.borrower.firstname is null Test plan: Patron A is Org and guarantor of patron B Check an item out to B Go to the details page of A, click "Relative's checkouts" Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I have an organization (school) with a guarantee that doesn't have a firstname. (empty string, also tested with a patron created without firstname) But I don't have an error in the console and the table loads. What is missing in my test plan? https://picat.drycat.fr/aXxAy7eU.png I even tried with a library being the guarantee of a school. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114099|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114977&action=edit Bug 26797: Escape firstname to prevent relative's checkouts to crash If no firstname is defined for a relative, the "Relative's checkouts" tab will be "processing" forever. JS error: TypeError: oObj.borrower.firstname is null Test plan: 1 - Create a patron (PatronA) in a category with type 'Org' 'School' in sample data works 2 - Add a guarantee (Patron B) 3 - Check out an item to PatronA 4 - Go to PatronB's record and click relativwe's checkouts 5 - There is an error and the table doe snot load 6 - Apply patch 7 - Reload 8 - Table loads correctly Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #6)
I have an organization (school) with a guarantee that doesn't have a firstname. (empty string, also tested with a patron created without firstname) But I don't have an error in the console and the table loads. What is missing in my test plan?
https://picat.drycat.fr/aXxAy7eU.png
I even tried with a library being the guarantee of a school.
The patch was correct, the test plan was wrong - the guarantee could not load the checkouts for the guarantor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.02 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- This doesn't fix the issue for me in 20.05. Patch applies fine, but I get this error when trying to see the Org's checkoouts in the prof's record: checkouts_20.0507002.js:785 Uncaught TypeError: Cannot read property 'escapeHtml' of null at mDataProp (checkouts_20.0507002.js:785) at datatables.min_20.0507002.js:57 at Object.b.fnGetData (datatables.min_20.0507002.js:51) at B (datatables.min_20.0507002.js:56) at Ha (datatables.min_20.0507002.js:64) at O (datatables.min_20.0507002.js:55) at datatables.min_20.0507002.js:88 at i (datatables.min_20.0507002.js:74) at Object.success (checkouts_20.0507002.js:802) at i (jquery-2.2.3.min_20.0507002.js:2) Jonathan, any ideas? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Andrew, it looks like a cache issue, can you confirm the cache has been correctly flushed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org