[Bug 14948] New: Display amounts right aligned in tables on patron pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Bug ID: 14948 Summary: Display amounts right aligned in tables on patron pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Amounts for charge, cine, price etc. appear left alinged (instead of right aligned) in tables on patron pages. To verify: - Go to Home > Patrons, perform a search (Column 'Fines') - Go to a patron with fines and credits - Checkout tab (circulation.pl): Columns 'Charge', 'Fine', 'Price' (maybe you have to show column with 'Show / hide colums') - Fines Tab > Account (boraccount.pl): Columns 'Amount', 'Outstanding' - Fines Tab > Pay fines (pay.pl): Columns 'Amount', 'Amount Outstanding' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 43092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43092&action=edit Bug 14948 - Display amounts right aligned in tables on patron pages This patch set display amounts for charge, fine, price etc. right aligned in tables on patron pages. To test, apply patch and verify that amounts appear right aligned on following pages: - Go to Home > Patrons, perform a search (Column 'Fines') - Go to a patron with fines and credits - Checkout tab (circulation.pl): Columns 'Charge', 'Fine', 'Price' (maybe you have to show column with 'Show / hide colums') - Fines Tab > Pay fines (pay.pl): Columns 'Amount', 'Amount Outstanding' - Fines Tab > Account (boraccount.pl): Columns 'Amount', 'Outstanding' Note: Test here 'Filter paid transactions' as well -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |nengard@gmail.com --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- On the patron details and the check out tab at the bottom the amounts are not right aligned. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 44259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44259&action=edit not aligned -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 44268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44268&action=edit Values right-aligned in checkout and detail tabs I tested again with patch applied, the values are right-aligned, see screenshot. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 --- Comment #5 from Marc Véron <veron@veron.ch> --- BTW, I had to do a full browser reload (F5) after applying the patch to see the changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43092|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 44298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44298&action=edit Bug 14948 - Display amounts right aligned in tables on patron pages This patch set display amounts for charge, fine, price etc. right aligned in tables on patron pages. To test, apply patch and verify that amounts appear right aligned on following pages: - Go to Home > Patrons, perform a search (Column 'Fines') - Go to a patron with fines and credits - Checkout tab (circulation.pl): Columns 'Charge', 'Fine', 'Price' (maybe you have to show column with 'Show / hide colums') - Fines Tab > Pay fines (pay.pl): Columns 'Amount', 'Amount Outstanding' - Fines Tab > Account (boraccount.pl): Columns 'Amount', 'Outstanding' Note: Test here 'Filter paid transactions' as well Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Everything works fine, but I would prefer to see a css class defined to use everywhere. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44298|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44545&action=edit Bug 14948 - Display amounts right aligned in tables on patron pages This patch set display amounts for charge, fine, price etc. right aligned in tables on patron pages. To test, apply patch and verify that amounts appear right aligned on following pages: - Go to Home > Patrons, perform a search (Column 'Fines') - Go to a patron with fines and credits - Checkout tab (circulation.pl): Columns 'Charge', 'Fine', 'Price' (maybe you have to show column with 'Show / hide colums') - Fines Tab > Pay fines (pay.pl): Columns 'Amount', 'Amount Outstanding' - Fines Tab > Account (boraccount.pl): Columns 'Amount', 'Outstanding' Note: Test here 'Filter paid transactions' as well Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #7)
Everything works fine, but I would prefer to see a css class defined to use everywhere.
Let's say do it later. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 --- Comment #10 from Marc Véron <veron@veron.ch> --- Still applies. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44545|0 |1 is obsolete| | --- Comment #11 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 46066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46066&action=edit Bug 14948 - Display amounts right aligned in tables on patron pages This patch set display amounts for charge, fine, price etc. right aligned in tables on patron pages. To test, apply patch and verify that amounts appear right aligned on following pages: - Go to Home > Patrons, perform a search (Column 'Fines') - Go to a patron with fines and credits - Checkout tab (circulation.pl): Columns 'Charge', 'Fine', 'Price' (maybe you have to show column with 'Show / hide colums') - Fines Tab > Pay fines (pay.pl): Columns 'Amount', 'Amount Outstanding' - Fines Tab > Account (boraccount.pl): Columns 'Amount', 'Outstanding' Note: Test here 'Filter paid transactions' as well Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m --- Comment #12 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Thanks -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14948 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #14 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org