[Bug 14636] New: Sorting and searching by publication year in item search doesn't work correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Bug ID: 14636 Summary: Sorting and searching by publication year in item search doesn't work correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org I am not sure if this is only a problem for MARC21 - it might. If you limit an item search by Year, using the pull down field and by call number, the reults are not correct. The shown publication year doesn't match what was searched for, the call number is correct in my example. Sorting the column for copyright year gives wrong results - the list changes, but the sorting is incorrect. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 14823 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45070&action=edit Bug 14636: Item search - fix search and sort by publication date for MARC21 Problem: MARC21/NORMARC stores the publication date in biblio.copyrightdate, but UNIMARC uses biblioitems.publicationyear. To test: - Without patch in a MARC21 installation: - Search by publication date - Verify that the results don't match the publication year you searched for. - Try sorting the table by publication year. - Verify that the sort doesn't work. - Apply patch. - Repeat both, search and sort. - Verify both work correctly now. - Repeat tests on a UNIMARC installation. - Verify both still work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45071&action=edit Bug 14636: Item search - improving display - Changes "Publication Date" to "Publication date" in the CSV export - Fixes 'no JavaScript fallback' display to match the normal display - only show 'by' when it's UNIMARC and an author exist - show copyrightdate if publicationyear is empty To test: - Turn of Javascript in your browser before you item search. This will activate the alternative display. - For MARC21: - Verify that the author displays when existing and no 'by' is shown. - Verify that the publication date is now shown. - For UNIMARC: - Verify that 'by' only displays when there is an author to display. - Verify that the publication date is still shown. - Try the CSV export. - Verify that the CSV header now reads 'Publication date'. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45070|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 45120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45120&action=edit [SIGNED-OFF] Bug 14636: Item search - fix search and sort by publication date for MARC21 Problem: MARC21/NORMARC stores the publication date in biblio.copyrightdate, but UNIMARC uses biblioitems.publicationyear. To test: - Without patch in a MARC21 installation: - Search by publication date - Verify that the results don't match the publication year you searched for. - Try sorting the table by publication year. - Verify that the sort doesn't work. - Apply patch. - Repeat both, search and sort. - Verify both work correctly now. - Repeat tests on a UNIMARC installation. - Verify both still work. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested searching and sorting successfully in a MARC21 installation. DID NOT test in UNIMARC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45071|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 45121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45121&action=edit [SIGNED-OFF] Bug 14636: Item search - improving display - Changes "Publication Date" to "Publication date" in the CSV export - Fixes 'no JavaScript fallback' display to match the normal display - only show 'by' when it's UNIMARC and an author exist - show copyrightdate if publicationyear is empty To test: - Turn of Javascript in your browser before you item search. This will activate the alternative display. - For MARC21: - Verify that the author displays when existing and no 'by' is shown. - Verify that the publication date is now shown. - For UNIMARC: - Verify that 'by' only displays when there is an author to display. - Verify that the publication date is still shown. - Try the CSV export. - Verify that the CSV header now reads 'Publication date'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Successfully tested non-JS behavior and CSV export. DID NOT test UNIMARC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I left this as 'needs signoff' because I think it requires a test by a UNIMARC user as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Even without this patch, in UNIMARC, item search by publication date does not work. It is because there is in itemsearch.tt publicationdate instead of publicationyear. May I provide a patch here ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 45153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45153&action=edit Bug 14636: Item search - biblioitems column is publicationyear not publicationdate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45153|0 |1 is obsolete| | --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 45161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45161&action=edit Bug 14636: Item search - biblioitems column is publicationyear not publicationdate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45161|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45168&action=edit Bug 14636: Item search - biblioitems column is publicationyear not publicationdate Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Thx for the follow-up! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45169&action=edit Bug 14636: Follow-up - fix typo in system preference name The preference is named "marcflavour" not "marcflavor". Without this change, search will always use "copyrightyear" and break search by publication date for UNIMARC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Fridolin - thx to your testing we found 2 more bugs. I added another follow-up and retested all patches together in MARC21 and UNIMARC. Can you please test again? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 45304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45304&action=edit Bug 14636: Item search - fix search and sort by publication date for MARC21 Problem: MARC21/NORMARC stores the publication date in biblio.copyrightdate, but UNIMARC uses biblioitems.publicationyear. To test: - Without patch in a MARC21 installation: - Search by publication date - Verify that the results don't match the publication year you searched for. - Try sorting the table by publication year. - Verify that the sort doesn't work. - Apply patch. - Repeat both, search and sort. - Verify both work correctly now. - Repeat tests on a UNIMARC installation. - Verify both still work. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested searching and sorting successfully in a MARC21 installation. DID NOT test in UNIMARC. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 45305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45305&action=edit Bug 14636: Item search - improving display - Changes "Publication Date" to "Publication date" in the CSV export - Fixes 'no JavaScript fallback' display to match the normal display - only show 'by' when it's UNIMARC and an author exist - show copyrightdate if publicationyear is empty To test: - Turn of Javascript in your browser before you item search. This will activate the alternative display. - For MARC21: - Verify that the author displays when existing and no 'by' is shown. - Verify that the publication date is now shown. - For UNIMARC: - Verify that 'by' only displays when there is an author to display. - Verify that the publication date is still shown. - Try the CSV export. - Verify that the CSV header now reads 'Publication date'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Successfully tested non-JS behavior and CSV export. DID NOT test UNIMARC. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45168|0 |1 is obsolete| | --- Comment #15 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 45306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45306&action=edit Bug 14636: Item search - biblioitems column is publicationyear not publicationdate Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Thx for the follow-up! Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45169|0 |1 is obsolete| | --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 45307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45307&action=edit Bug 14636: Follow-up - fix typo in system preference name The preference is named "marcflavour" not "marcflavor". Without this change, search will always use "copyrightyear" and break search by publication date for UNIMARC. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45120|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45121|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #17 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I signoff for UNIMARC, works perfect -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45304|0 |1 is obsolete| | Attachment #45305|0 |1 is obsolete| | Attachment #45306|0 |1 is obsolete| | Attachment #45307|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45315&action=edit Bug 14636: Item search - fix search and sort by publication date for MARC21 Problem: MARC21/NORMARC stores the publication date in biblio.copyrightdate, but UNIMARC uses biblioitems.publicationyear. To test: - Without patch in a MARC21 installation: - Search by publication date - Verify that the results don't match the publication year you searched for. - Try sorting the table by publication year. - Verify that the sort doesn't work. - Apply patch. - Repeat both, search and sort. - Verify both work correctly now. - Repeat tests on a UNIMARC installation. - Verify both still work. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Tested searching and sorting successfully in a MARC21 installation. DID NOT test in UNIMARC. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45316&action=edit Bug 14636: Item search - improving display - Changes "Publication Date" to "Publication date" in the CSV export - Fixes 'no JavaScript fallback' display to match the normal display - only show 'by' when it's UNIMARC and an author exist - show copyrightdate if publicationyear is empty To test: - Turn of Javascript in your browser before you item search. This will activate the alternative display. - For MARC21: - Verify that the author displays when existing and no 'by' is shown. - Verify that the publication date is now shown. - For UNIMARC: - Verify that 'by' only displays when there is an author to display. - Verify that the publication date is still shown. - Try the CSV export. - Verify that the CSV header now reads 'Publication date'. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Successfully tested non-JS behavior and CSV export. DID NOT test UNIMARC. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45317&action=edit Bug 14636: Item search - biblioitems column is publicationyear not publicationdate Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Thx for the follow-up! Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45318&action=edit Bug 14636: Follow-up - fix typo in system preference name The preference is named "marcflavour" not "marcflavor". Without this change, search will always use "copyrightyear" and break search by publication date for UNIMARC. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45319&action=edit Bug 14636: Remove debug message Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master! Thanks Katrin, Frido and Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #25 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org