http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 38792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38792&action=edit Bug 14131 - Patroncard: Add possibility to print from patron lists This patch adds the possibility to print patron cards from patron lists. To test: - Go to Home > Tools > Patron card creator - Prepare a patron card and create some cards using the batch functionality - Apply patch - Prepare a patron list e.g. from patron search - Go to Home > Tools > Patron card creator > Manage batches - Below the list of batches you have a dropdown to select a patron list - Select your list and hit "Export from patron list" - Select template and layout as you would do with batches - Hit "Export" - Download PDF -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12471 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u --- Comment #2 from Chris Nighswonger <cnighswonger@foundations.edu> --- When attempting to create a patron list (running master), I receive an error which states: "An error occurred." See the attached screenshot. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38875|0 |1 is obsolete| | --- Comment #4 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 38876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38876&action=edit Error when attempting to build a patron list And now the shot with the error showing... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #6 from Marc Véron <veron@veron.ch> --- Still applies. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@jsense.co.uk --- Comment #7 from Marc Véron <veron@veron.ch> --- *** Bug 12471 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #9 from Pete Edwards <koha@jsense.co.uk> --- This is a really useful improvement - thanks. I have 2 comments: There is a small typo in the patch. See line 54 in print.tt. [% IF ( borrower_count == 1 ) %]Exporting [% borrower_count %] patroncard[% ELSE %]Exporting [% borrower_count %] patroncards[% END %]a The "a" at the end is incorrect. The feature has been added to the Patron Card Creator tool which is where cards are normally created but the functionality is very oriented towards batches and in this case there is no batch. This may be a little quirky for the user. They have to go to "Manage batches" in order to export a list. Can I suggest a few options? - Describe this feature in the home page of the module - Add a link on the left, e.g."Export list" - In the Patron Lists module, add an "Export cards" button in the table of Patron Lists and then, in the list itself allow the user to select some borrowers and "Export cards" for those selected. The Export button on the patron list table could be done with the following changes to patron_lists/lists.tt: Add: [% INCLUDE 'greybox.inc' %] Modify the table sorting: { "aTargets": [ -1, -2, -3, -4 ], "bSortable": false, "bSearchable": false }, Add export column: <td> <a class="btn btn-mini" href="#" onclick='GB_showCenter(_("Export patron cards from list"), "/cgi-bin/koha/patroncards/print.pl?patronlist_id=[% l.patron_list_id %]", 700, 800);return false;'> <i class="icon-print"></i> Export cards </a> </td> I know this is not the complete solution as the grey box does not have a Done button. I will investigate how to become a contributor to Koha but wanted to make this suggestion while I work on that. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 42821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42821&action=edit [Follow-up]Bug 14131 - Fix typo in print.tt Superfluous 'a' removed in koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/print.tt line 54 (See comment #9) -MV -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I join the opinion of Pete, there is an ergonomic issue, I don't think the new "export from patron list" enhancement is correctly placed. I let another QAer have a look at your patch and give his/her feedback. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42491|0 |1 is obsolete| | --- Comment #14 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 43414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43414&action=edit Bug 14131 - Patroncard: Add possibility to print from patron lists This patch adds the possibility to print patron cards from patron lists. To test: - Go to Home > Tools > Patron card creator - Prepare a patron card and create some cards using the batch functionality - Apply patch - Prepare a patron list e.g. from patron search - Go to Home > Tools > Patron card creator > Manage batches - Below the list of batches you have a dropdown to select a patron list - Select your list and hit "Export from patron list" - Select template and layout as you would do with batches - Hit "Export" - Download PDF Modified patch to work with Bug 14676 changes. Functionality unchanged. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Liz <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #16 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 43415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43415&action=edit Bug 14131 - Adding print patron cards to patron lists home page To test: Go to /cgi-bin/koha/patron-lists/lists.pl Make a patron list Click "Print patron cards" Success: you get a pdf of cards to print. Failure: you can't get a pdf of cards to print. Note that you'll need to have a card layout, template, and printer profile defined. The defaults should work. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #18 from Liz Rea <liz@catalyst.net.nz> --- The ergonomic change I added will probably want testing on top of this patch. The modified patch I did for compatibility with 14676 is likely ok, but if you're gonna test the one, you'll have to have the other(s) anyway. Note that the two I've uploaded will need to be applied on top of 14676. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43415|0 |1 is obsolete| | --- Comment #19 from Marc Véron <veron@veron.ch> --- Created attachment 43544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43544&action=edit Bug 14131 - Adding print patron cards to patron lists home page To test: Go to /cgi-bin/koha/patron-lists/lists.pl Make a patron list Click "Print patron cards" Success: you get a pdf of cards to print. Failure: you can't get a pdf of cards to print. Note that you'll need to have a card layout, template, and printer profile defined. The defaults should work. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 43806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43806&action=edit Bug 14131: Reduce the greybox height to 400px Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- ... with the last patch! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Liz Rea from comment #24)

Jonathan, do you think we should change the height on that greybox across the board for the label and patron card creators?

It kinda feels like the right thing to do.

Liz

Indeed, to be consistent it would be good to reduce them too. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Liz Rea from comment #26)

cool I'll probably have a poke at that one unless you've already started on it.

I don't :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43805|0 |1 is obsolete| | --- Comment #29 from Marc Véron <veron@veron.ch> --- Created attachment 45635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45635&action=edit Bug 14131 - Adding print patron cards to patron lists home page To test: Go to /cgi-bin/koha/patron-lists/lists.pl Make a patron list Click "Print patron cards" Success: you get a pdf of cards to print. Failure: you can't get a pdf of cards to print. Note that you'll need to have a card layout, template, and printer profile defined. The defaults should work. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131 --- Comment #31 from Marc Véron <veron@veron.ch> --- I amended the first patch to make it apply and then re-uploaded the following patches (unchanged) to keep them in the right order, I hope that is OK. -- You are receiving this mail because: You are watching all bug changes.