[Bug 10076] New: Add Bcc syspref for claimacquisition and clamissues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Bug ID: 10076 Summary: Add Bcc syspref for claimacquisition and clamissues Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: pelletiermaxime@gmail.com There is already a syspref called "OverdueNoticeBcc" for sending Bcc copies of mails sent for overdues and other notices. It would be useful to have a new preference to bcc the claimacquisition and clamissues alerts. I will work on a patch if this is something that could be wanted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |pelletiermaxime@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #1 from Maxime Pelletier <pelletiermaxime@gmail.com> --- Created attachment 17853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17853&action=edit Patch to add the syspref -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- SendAlerts() is not used only from serials/claims.pl, but from members/memberentry.pl as well, which would cause unwanted Bcc. I suggest type is examined for Bcc as well -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 marjorie barry-vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17853|0 |1 is obsolete| | --- Comment #3 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 30632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30632&action=edit Bug 10076 - Fixed merge conflicts. Patch now applies properly modified: C4/Letters.pm modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref Type is checked before sending Bcc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com Assignee|pelletiermaxime@gmail.com |maxime.beaulieu@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paola.rossi@cineca.it --- Comment #4 from Paola Rossi <paola.rossi@cineca.it> --- I've applied the patch against master 3.17.00.016 I set the pref ClaimsBccCopy to "Send". Everything is OK as required. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30632|0 |1 is obsolete| | --- Comment #5 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 31262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31262&action=edit Bug 10076 - Add Bcc syspref for claimacquisition and claimissues -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- This patch does not add the new system preference to updatedatabase.pl or sysprefs.sql. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #7 from simith.doliveira@inlibro.com --- Created attachment 31397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31397&action=edit syspref.sql and updatedatabase.pl Added -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|maxime.beaulieu@inlibro.com |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #8 from Amit <amitddng135@gmail.com> --- simith any plan to rebase this patch on master? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxime.beaulieu@inlibro.com Assignee|simith.doliveira@inlibro.co |maxime.beaulieu@inlibro.com |m | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #9 from Amit Gupta <amitddng135@gmail.com> --- Hi maxime.beaulieu@inlibro.com, Need this patch one of our client. Can i take on this bug? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #10 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 40843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40843&action=edit Bug 10076 - Fixed merge conflicts. Patch now applies properly modified: C4/Letters.pm modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31397|0 |1 is obsolete| | --- Comment #11 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 40844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40844&action=edit syspref.sql and updatedatabase.pl Added -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #12 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Created attachment 40845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40845&action=edit Bug 10076 - Atomic Update new file: installer/data/mysql/atomicupdate/Bug10076_ClaimsBccCopy.sql -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31262|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40843|Bug 10076 - Fixed merge |Bug 10076 - Add Bcc syspref description|conflicts. |for claimacquisition and | |claimissues -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #13 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- Patch has been rebased to current master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #14 from Frédéric Demians <frederic@tamil.fr> --- Since it's a small patch, it would be better to package it in a single patch. And could you use the capitalized version of the new syspref in SQL? ClaimsBccCopy rather than claimsbcccopy. Here: VALUES ('claimsbcccopy','0','','bcc the claimacquisition and clamissues alerts','YesNo'); ('claimsbcccopy','0','','bcc the claimacquisition and clamissues alerts','YesNo'), -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please make the small fixes suggested by Frederic! :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40843|0 |1 is obsolete| | Attachment #40844|0 |1 is obsolete| | Attachment #40845|0 |1 is obsolete| | --- Comment #16 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 45181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45181&action=edit Bug 10076 - Add Bcc syspref for ClaimAcquisition and ClaimIssues This is a squash of the previous three patches, with capitalization of the syspref 'ClaimsBccCopy' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |charles.farmer@inlibro.com Assignee|maxime.beaulieu@inlibro.com |charles.farmer@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45181|0 |1 is obsolete| | --- Comment #17 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 45183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45183&action=edit Bug 10076 - Add Bcc syspref for ClaimAcquisition and ClaimIssues There is already a syspref called "OverdueNoticeBcc" for sending Bcc copies of mails sent for overdues and other notices. This patch add a new syspref ClaimsBccCopy to bcc the claimacquisition and clamissues alerts. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Works as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just a request for a small follow-up here: The system preference is not nicely formatted and I think the wording could be a bit more clear. Currently it reads: Send a copy in bcc of the ClaimAcquisition and ClaimIssues letters to the active user [Send|Don't send] My suggestion after discussing with a native speaker (thx Liz :) ) would be: [Send|Don't send] blind copy (BCC) to logged in user when sending serial or acquisitions claims notices. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45183|0 |1 is obsolete| | --- Comment #19 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 45264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45264&action=edit Bug 10076 - Add Bcc syspref for ClaimAcquisition and ClaimIssues There is already a syspref called "OverdueNoticeBcc" for sending Bcc copies of mails sent for overdues and other notices. This patch add a new syspref ClaimsBccCopy to bcc the claimacquisition and clamissues alerts. Changed the wording of the system preference to: [Send|Don't send] blind copy (BCC) to logged in user when sending serial or acquisitions claims notices. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Charles, for a small change request like this doing a follow-up patch and keep the 'Signed-off' would be ok next time! I just noticed comment#2 from Srdjan - can you comment on that? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #21 from Charles Farmer <charles.farmer@inlibro.com> --- (In reply to Katrin Fischer from comment #20)
Hi Charles, for a small change request like this doing a follow-up patch and keep the 'Signed-off' would be ok next time! I just noticed comment#2 from Srdjan - can you comment on that?
Hi Katrin, Maxime already took care of it. This problem is avoided in the patch by first checking if the letter type is 'claimacquisition' or 'claimissues'. Never should a BCC be sent otherwise. I unfortunately cannot unit test this part though, because the email is never queued anywhere. But from the code, it looks like no unwanted BCC can be sent. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, I can see it now! So all we need is another sign-off now - or the old signed patch + a new follow-up dealing with the string changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45264|0 |1 is obsolete| | --- Comment #23 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 45350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45350&action=edit Bug 10076 - Add Bcc syspref for ClaimAcquisition and ClaimIssues There is already a syspref called "OverdueNoticeBcc" for sending Bcc copies of mails sent for overdues and other notices. This patch add a new syspref ClaimsBccCopy to bcc the claimacquisition and clamissues alerts. Changed the wording of the system preference to: [Send|Don't send] blind copy (BCC) to logged in user when sending serial or acquisitions claims notices. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45350|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45361&action=edit [PASSED QA] Bug 10076 - Add Bcc syspref for ClaimAcquisition and ClaimIssues There is already a syspref called "OverdueNoticeBcc" for sending Bcc copies of mails sent for overdues and other notices. This patch add a new syspref ClaimsBccCopy to bcc the claimacquisition and clamissues alerts. Changed the wording of the system preference to: [Send|Don't send] blind copy (BCC) to logged in user when sending serial or acquisitions claims notices. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #25 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to master - Thanks -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org