[Bug 14631] New: Change to "Patron" in patroncard toolbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Bug ID: 14631 Summary: Change to "Patron" in patroncard toolbar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: indradg@gmail.com Reporter: indradg@gmail.com QA Contact: testopia@bugs.koha-community.org The toolbar for "Manage patron card batches" template shows "item(s)" instead of "patron(s)". This patch proposes to fix it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 --- Comment #1 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 41305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41305&action=edit patron(s) described as item(s) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 --- Comment #2 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 41306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41306&action=edit Bug 14631 - Change item(s) to patron(s) in toolbar The toolbar for "Manage patron card batches" template shows "item(s)" instead of "patron(s)". This patch proposes to fix it. Test plan ========= 1/ Go to Patron card creator > Manage patron card batches notice. 2/ Select a batch to edit, you should see the toolbar as described in attachment 41305 3/ Apply patch and refresh page. The toolbar should read correctly as 'patron(s)' 4/ Go back to step #1 above and select "New batch" and let the page automatically refresh. The toolbar button presented should read "Add patron(s)" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia@hotmail.com --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- The patch works fine, but just wanted to add a few things which still should be changed from item(s) to patron(s): - title of 'Items in Batch number x' (which can be seen in your screenshot) - on the main Manage batches page where it gives a list of Currently Available Batches, there is a column title 'Item Count' - when adding a new batch, there is a message saying "There are no items in batch 0 yet, Use the toolbar above to add items." So in my opinion, four more instances where it should say patrons. Will set to Failed QA so you can submit a new patch :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #4 from Liz Rea <liz@catalyst.net.nz> --- I noticed this while working on bug 14676, and was going to tidy it up as part of that. I'll use your stuff if you beat me to it though. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |Label/patron card printing CC| |veron@veron.ch --- Comment #5 from Marc Véron <veron@veron.ch> --- I hope it's OK to change module to Label/patroncard printing -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu --- Comment #6 from Tom Misilo <misilot@fit.edu> --- Would this make sense to change the text in the file instead of using javascript to do it? If so I can try and make a new patch that does that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 --- Comment #7 from Liz Rea <liz@catalyst.net.nz> --- Yeah, I think we should not do this with javascript. The right place would be to change the labels where they are generated, or have a look at jonathan's translation fixes for the label creator, which makes things more translatable: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41625&action=diff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 --- Comment #8 from Liz Rea <liz@catalyst.net.nz> --- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41626&action=diff sorry I meant this one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- On current master this has been fixed. We have "Add patron(s) Remove selected patrons ... Export selected card(s) Export card batch" There are other strings that need attention: alert(_("Deletion of item from a batch with only one item will delete the batch.\n\nIf this is what you want, select 'Delete batch' option from toolbar")); <strong>[% duplicate_count %] duplicate item(s) found</strong> and removed from batch [% batch_id %]. <h2>Items in batch number [% batch_id %]</h2> <h4>There are no items in this batch yet</h4> <p>Add items by borrowernumber using the text area above or leave empty to add via patron search.</p> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 --- Comment #10 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 45889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45889&action=edit Bug 14631: More changes from 'items' to 'patrons' Some of the changes Bernardo noticed were missed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 --- Comment #11 from Marc Véron <veron@veron.ch> --- A small translatability woe (sentence splitting by tags): <strong>[% duplicate_count %] duplicate patron(s) found</strong> and removed from batch [% batch_id %]. Maybe something like: <strong>Duplicate patron(s) removed from batch [% batch_id %]:</strong> [% duplicate_count %] or: <strong>Duplicates removed from batch [% batch_id %]:</strong> [% duplicate_count %] patron(s) or even: <strong>Duplicates removed from batch [% batch_id %]:</strong> [% duplicate_count %] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 --- Comment #12 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 45919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45919&action=edit Bug 14631: Translatability fix -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Danielle Elder <danielle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle@bywatersolutions.c | |om --- Comment #13 from Danielle Elder <danielle@bywatersolutions.com> --- Comment on attachment 41306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41306 Bug 14631 - Change item(s) to patron(s) in toolbar Did not apply. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 --- Comment #14 from Liz Rea <liz@catalyst.net.nz> --- Hi, I'm not sure most of this is even applicable, as the patron card creator has had a UI overhaul since this bug was started. It would pay to go through and make sure we didn't miss any items -> patrons conversion as part of that work, but this may not be relevant anymore. Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #15 from Liz Rea <liz@catalyst.net.nz> --- Bug 14676 is the one that did most of that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14631 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Patch doesn't apply |RESOLVED --- Comment #16 from Liz Rea <liz@catalyst.net.nz> --- Aleisha has opened bug 15573 for the remaining things to be fixed here. As the UI is totally changed, nothing here is of importance anymore. Liz -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org