[Bug 13668] New: Creator of an SQL report shoudl be NULL when the staff patron is deleted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Bug ID: 13668 Summary: Creator of an SQL report shoudl be NULL when the staff patron is deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When deletig a staff patron his/her reports are still linked to his/her former borrowernumber. It would be better to delete the connection to the creator when the staff patron is deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org --- Comment #1 from Nick Clemens <nick@quecheelibrary.org> --- FWIW I would kind of like to know who created a report even if they are removed from the system. Maybe link it to the deletedborrowers table and display in red or with a note? Some people's reports you might want to save, and some delete, harder to suss out if all set to null. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The idea behind this is that we shoudln't keep information about people (staff or patrons) forever in the database. When you have left the library, there should be a point where they are no longer saving things about you in their computer systems. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 --- Comment #3 from Nick Clemens <nick@quecheelibrary.org> --- Agreed. My thinking was factoring in bug 13667. Once deletedborrowers is cleared, borrowernumber seems a fairly anonymous piece of info, but that might just be how we use it as staff here. As far as I can tell, the statistics table doesn't null out borrowernumber when deleting a patron either. Not a big deal and okay with this solution, just giving my 2 cents -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nick, I understand your point - we are a bit crazy here about saving/deleting things :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 46592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46592&action=edit Bug 13668: Add foreign key on saved_sql.borrowernumber saved_sql.borrowernumber refers to a borrowernumber, the DB structure should reflect this constraint. Test plan: 0/ Do not execute the update DB entry 1/ Add a new patron 2/ Use this patron to create a new report 3/ Delete the patron 4/ Execute the DB entry 5/ The saved_sql.borrowernumber for this report should have been set to NULL 6/ On the reports table, the column 'Author' should be empty. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46592|0 |1 is obsolete| | --- Comment #6 from Joy Nelson <joy@bywatersolutions.com> --- Created attachment 46622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46622&action=edit Bug 13668: Add foreign key on saved_sql.borrowernumber saved_sql.borrowernumber refers to a borrowernumber, the DB structure should reflect this constraint. Test plan: 0/ Do not execute the update DB entry 1/ Add a new patron 2/ Use this patron to create a new report 3/ Delete the patron 4/ Execute the DB entry 5/ The saved_sql.borrowernumber for this report should have been set to NULL 6/ On the reports table, the column 'Author' should be empty. Signed-off-by: Joy Nelson <joy@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13668 Danielle Elder <danielle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46622|0 |1 is obsolete| | --- Comment #7 from Danielle Elder <danielle@bywatersolutions.com> --- Created attachment 46623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46623&action=edit Bug 13668: Add foreign key on saved_sql.borrowernumber saved_sql.borrowernumber refers to a borrowernumber, the DB structure should reflect this constraint. Test plan: 0/ Do not execute the update DB entry 1/ Add a new patron 2/ Use this patron to create a new report 3/ Delete the patron 4/ Execute the DB entry 5/ The saved_sql.borrowernumber for this report should have been set to NULL 6/ On the reports table, the column 'Author' should be empty. Signed-off-by: Joy Nelson <joy@bywatersolutions.com> Signed-off-by: Dani Elder <danielle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org