[Bug 10995] New: Accessibility: Allow manual entry of renewal date and specific due date in circ
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Bug ID: 10995 Summary: Accessibility: Allow manual entry of renewal date and specific due date in circ Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org In 3.12 it's no longer possible to enter dates manually as specific due date and renewal date in the patron account in circulation. This is a big accessibility problem as not everyone can use the datepickers for filling those fields. We have a library where this is a blocker. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- +1 M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 23699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23699&action=edit Bug 10995 - Accessibility: Allow manual entry of renewal date and specific due date in circ
From Katrin Fischer: In 3.12 it's no longer possible to enter dates manually as specific due date and renewal date in the patron account in circulation. This is a big accessibility problem as not everyone can use the datepickers for filling those fields. We have a library where this is a blocker.
Test Plan: 1) Apply this patch 2) Start checking out a patron 3) Note when you click the due date field, the calendar pops up, but you can now edit the field by hand as well -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Kyle M Hall from comment #2)
Created attachment 23699 [details] [review] Bug 10995 - Accessibility: Allow manual entry of renewal date and specific due date in circ
From Katrin Fischer: In 3.12 it's no longer possible to enter dates manually as specific due date and renewal date in the patron account in circulation. This is a big accessibility problem as not everyone can use the datepickers for filling those fields. We have a library where this is a blocker.
Test Plan: 1) Apply this patch 2) Start checking out a patron 3) Note when you click the due date field, the calendar pops up, but you can now edit the field by hand as well
Did you try the calendar popup in a screen reader? Does it work? If not, we kinda haven't solved the accessibility issue, I can't easily test this, can someone? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Chris Cormack from comment #3)
(In reply to Kyle M Hall from comment #2)
Created attachment 23699 [details] [review] [review] Bug 10995 - Accessibility: Allow manual entry of renewal date and specific due date in circ
From Katrin Fischer: In 3.12 it's no longer possible to enter dates manually as specific due date and renewal date in the patron account in circulation. This is a big accessibility problem as not everyone can use the datepickers for filling those fields. We have a library where this is a blocker.
Test Plan: 1) Apply this patch 2) Start checking out a patron 3) Note when you click the due date field, the calendar pops up, but you can now edit the field by hand as well
Did you try the calendar popup in a screen reader? Does it work? If not, we kinda haven't solved the accessibility issue, I can't easily test this, can someone?
Ahh I see whats happening, you can ignore the pop up, hmm so that works, the question is if people will know that, maybe we could add a tooltip for the screen reader to read? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can only imagine that getting the calendar widget read out to you is quite painful and takes too long in circ to be any fun. The library is currently using 3.6 where you can enter the date directly. I think if we could get that back, it would probably work best for them. What about making the calendar only pop up when you click on the calendar icon? I think that is how it works in some other places. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #6 from Christopher Brannon <cbrannon@cdalibrary.org> --- Forgive me, I am not sure what the protocol is here. Not sure if I should change the status to discussion. I've tested the patch, and it does what is described, however, this condition does exist in other places throughout Koha. request.pl opac-reserve.pl opac-memberentry.pl And I am sure there are other places I didn't think of. It seems to me we should comb through Koha and address all the date fields, and not just one. Am I incorrect on this matter? Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Christopher, yes, I think we should fix all of those to be more accessible, especially in the OPAC. I have started pointing out the problem when testing new patches and I filed some bugs (you shoudl be able to find most of them with 'accessibility'). Until the library we support pointed it out, I was not aware of the problem, but now that we know it is a problem, it would be nice to find a more accessible best practice for the date fields. But I think it shouldn't stop this patch from going in, because if it works well it will already be a small improvement and help a library. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Katrin Fischer from comment #7)
Hi Christopher,
yes, I think we should fix all of those to be more accessible, especially in the OPAC. I have started pointing out the problem when testing new patches and I filed some bugs (you shoudl be able to find most of them with 'accessibility'). Until the library we support pointed it out, I was not aware of the problem, but now that we know it is a problem, it would be nice to find a more accessible best practice for the date fields.
But I think it shouldn't stop this patch from going in, because if it works well it will already be a small improvement and help a library.
If that is the case, I will go ahead and sign off on this. As I stated earlier, this fixes the issue as described. Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> ---
If that is the case, I will go ahead and sign off on this. As I stated earlier, this fixes the issue as described.
Christopher
Hi Christopher (from another Christopher) Do you want to do the sign off on the patch? Do you know how to do that, would you like me to add your sign off for you? Or if you plan to test more (please say yes) This is probably the easiest way http://wiki.koha-community.org/wiki/Git_bz_configuration Alternatively, you can just git commit --amend -s To add your signoff git format-patch origin/master To create the signed off patch, and then attach it in bugzilla, obsoleting the old patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #10 from Christopher Brannon <cbrannon@cdalibrary.org> --- Chris, No worries. I've got it. I didn't realize there was more to signing off than changing the status. I'll just do it from the sandbox. Thanks! Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #11 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23699|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #12 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 23875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23875&action=edit Bug 10995 - Accessibility: Allow manual entry of renewal date and specific due date in circ
From Katrin Fischer: In 3.12 it's no longer possible to enter dates manually as specific due date and renewal date in the patron account in circulation. This is a big accessibility problem as not everyone can use the datepickers for filling those fields. We have a library where this is a blocker.
Test Plan: 1) Apply this patch 2) Start checking out a patron 3) Note when you click the due date field, the calendar pops up, but you can now edit the field by hand as well Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #13 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Chris Cormack from comment #9)
Hi Christopher (from another Christopher)
Do you want to do the sign off on the patch? Do you know how to do that, would you like me to add your sign off for you? Or if you plan to test more (please say yes)
Chris, I just realized you said "please say yes" to testing more. Did I miss something? Does something else need tested? I did find a bunch of other pages with the same issue, but for the sake of this bug, the patch works as expected. Should I have done more? Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Christopher Brannon from comment #13)
(In reply to Chris Cormack from comment #9)
Hi Christopher (from another Christopher)
Do you want to do the sign off on the patch? Do you know how to do that, would you like me to add your sign off for you? Or if you plan to test more (please say yes)
Chris, I just realized you said "please say yes" to testing more. Did I miss something? Does something else need tested? I did find a bunch of other pages with the same issue, but for the sake of this bug, the patch works as expected. Should I have done more?
Christopher
Not in relation to this bug, but we always need more people signing off/testing. It's even more important than writing patches. Without sign offs, patches can go no where. If you ever have free time, check out http://dashboard.koha-community.org you should be able to find a ton of patches that need testing :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #15 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Chris Cormack from comment #14)
Not in relation to this bug, but we always need more people signing off/testing. It's even more important than writing patches. Without sign offs, patches can go no where.
If you ever have free time, check out http://dashboard.koha-community.org you should be able to find a ton of patches that need testing :)
Actually, I have been checking this as I can and chipping away at the items I can test in the sandbox. Always glad to do what I can. Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd like to ask the library who reported this problem to take a look as I think that would be the best way to find out if the proposed solution works. I noticed while testing that an invalid date will somehow automatically be 'corrected'. I am not sure if this will cause problems. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: There are some concerns here, I think: There is another readonly field in the circulation.tt file. Trying to test it, I entered an invalid date (14/14/2014), and I got a crashing error (The 'month' parameter ("14") to DateTime::new did not pass the 'an integer between 1 and 12' callback). In fact the INVALID_DATE error code is set only if the date does not match the syspref format. If we allow the user to enter what he wants, we have to catch correctly any error. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We have asked the library who reported this to take a look, but catching errors is indeed the biggest problem I see. I think it's not so bad that this only fixes the due date, as we are still trying to figure out the best way of doing it. Javascript alerts seemed to work ok for this library in the past, so I think we might be able to do that, although server side would probably be the most accessible. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The library we asked to test reported that it's ok now and they can enter dates. I think we still need some error handling, but in general this seems to work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13601 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14060 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10995 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- See bug 14060 for a global solution of this problem. *** This bug has been marked as a duplicate of bug 14060 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org