[Bug 13941] New: Add ids to pages in staff client where missing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Bug ID: 13941 Summary: Add ids to pages in staff client where missing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Some time ago we added ids and classes to all the pages in the staff client to make it easier to customize. The newly added modules are missing those and we should add them. So far I noticed they are missing on the course reserves pages, but a search would probably turn up some more. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #1 from Frédéric Demians <frederic@tamil.fr> --- Are you talking about id/class attributes of <body> exclusively, or about other tags? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ids to pages in staff |Add ids to <body> tag in |client where missing |staff client where missing --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Frederic, thx for asking - I have clarified the title of the bug. I meant the <body> tag here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Several TT files have <body> without id/class. We need a test. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 37733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37733&action=edit Bug 13941 [1/2] Fix <body> tags missing id/class -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 37734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37734&action=edit Bug 13941 [2/2] Fix <body> tags missing id/class -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 37735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37735&action=edit Bug 13941 [1/2] Test <body> tag with id/class attributes Test: - Apply the first patch [1/2] containg a new test checking <body> tags in all templates - Run the test: prove xt/tt_valid.t - You get a list of templates with invalid <body> tags. - Apply the second patch [2/2] fixing all invalid <body> tags. - Re-run the test: It passes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37733|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |frederic@tamil.fr CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 37735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37735 Bug 13941 [1/2] Test <body> tag with id/class attributes Review of attachment 37735: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13941&attachment=37735) ----------------------------------------------------------------- ::: xt/tt_valid.t @@ +41,4 @@
} close $dh;
+use YAML;
Seems useless. @@ +56,5 @@
+ { + description => '<body> tag with id and class attributes', + check => sub { + my ($self, $name, $token) = @_; + my $_ = $token->{_string};
Hum... Sure about this? :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 37734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37734 Bug 13941 [2/2] Fix <body> tags missing id/class Review of attachment 37734: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13941&attachment=37734) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt @@ +135,4 @@
</script>
</head> +<body id="common_patron_seach" id="common">
typo "search" ::: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step1.tt @@ +2,4 @@
<title>Koha › Course reserves › Add items</title> [% INCLUDE 'doc-head-close.inc' %] </head> +<body id="courses_items_step1" class="course">
why not couse_add_items_step1? ::: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt @@ +3,4 @@
[% INCLUDE 'doc-head-close.inc' %] </head>
+<body id="courses_items_step2" class="course">
idem. ::: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt @@ +32,4 @@
</head>
+<body id="courses_details" class="course">
Shouldn't be courses_course_details? ::: koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-reserves.tt @@ +14,4 @@
</script>
</head> +<body id="courses_reserves" class="course">
Shouldn't be courses_course_reserves? ::: koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/add-modify.tt @@ +19,4 @@
</head>
+<body id="patlist_add_modify" class="pat patlist">
Shouldn't be patlist*s*? ::: koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt @@ +65,4 @@
</head>
+<body id="patlist_list" class="pat patlist">
Shouldn't be patlist*s*? ::: koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt @@ +24,4 @@
</head>
+<body id="patlist_lists" class="pat patlist">
Shouldn't be patlist*s*? ::: koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-disabled.tt @@ +5,4 @@
[% INCLUDE 'calendar.inc' %] </head>
+<body id="plugins_disbled" class="plugins">
typo Shouldn't be plugins_plugins_disabled? ::: koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt @@ +5,4 @@
[% INCLUDE 'calendar.inc' %] </head>
+<body id="plugins_home" class="plugins">
Shouldn't be plugins_plugins_home? ::: koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-upload.tt @@ +5,4 @@
[% INCLUDE 'calendar.inc' %] </head>
+<body id="plugins_upload" class="plugins">
Shouldn't be plugins_plugins_upload? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Marked as Failed QA, at least for typo. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #10 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Jonathan Druart from comment #7) Thanks for testing.
Comment on attachment 37735 [details] [review] Bug 13941 [1/2] Test <body> tag with id/class attributes
Review of attachment 37735 [details] [review]: -----------------------------------------------------------------
::: xt/tt_valid.t @@ +41,4 @@
} close $dh;
+use YAML;
Seems useless.
Sure.
@@ +56,5 @@
+ { + description => '<body> tag with id and class attributes', + check => sub { + my ($self, $name, $token) = @_; + my $_ = $token->{_string};
Hum... Sure about this? :)
Yes. Do you see anything wrong/strange? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #11 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Jonathan Druart from comment #8)
Comment on attachment 37734 [details] [review] Bug 13941 [2/2] Fix <body> tags missing id/class
Review of attachment 37734 [details] [review]:
Your points are well taken. You have good eyesight. But this:
::: koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/add-modify.tt @@ +19,4 @@
</head>
+<body id="patlist_add_modify" class="pat patlist">
Shouldn't be patlist*s*?
I don't understand. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Frédéric Demians from comment #11)
(In reply to Jonathan Druart from comment #8)
Comment on attachment 37734 [details] [review] [review] Bug 13941 [2/2] Fix <body> tags missing id/class
Review of attachment 37734 [details] [review] [review]:
Your points are well taken. You have good eyesight.
But this:
::: koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/add-modify.tt @@ +19,4 @@
</head>
+<body id="patlist_add_modify" class="pat patlist">
Shouldn't be patlist*s*?
I don't understand.
The module is plural, not the id (patron_lists vs patlist). See plugins and tools. But if you prefer patlist, go for it :) (In reply to Frédéric Demians from comment #10)
(In reply to Jonathan Druart from comment #7)
Thanks for testing.
Comment on attachment 37735 [details] [review] [review] Bug 13941 [1/2] Test <body> tag with id/class attributes
Review of attachment 37735 [details] [review] [review]: -----------------------------------------------------------------
::: xt/tt_valid.t @@ +41,4 @@
} close $dh;
+use YAML;
Seems useless.
Sure.
@@ +56,5 @@
+ { + description => '<body> tag with id and class attributes', + check => sub { + my ($self, $name, $token) = @_; + my $_ = $token->{_string};
Hum... Sure about this? :)
Yes. Do you see anything wrong/strange?
At least a warning :) Use of my $_ is experimental at xt/tt_valid.t line 61. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #13 from Frédéric Demians <frederic@tamil.fr> ---
Shouldn't be patlist*s*?
I don't understand.
The module is plural, not the id (patron_lists vs patlist). See plugins and tools. But if you prefer patlist, go for it :)
I understand now your *s*. I wasn't reading it properly... I will keep it as it is if you don't mind. It's already a sort of shortcut.
Use of my $_ is experimental at xt/tt_valid.t line 61.
Ok. I don't get it on Perl 5.14, but it's a valid warning. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37734|0 |1 is obsolete| | --- Comment #14 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 37759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37759&action=edit Bug 13941 [2/2] Fix <body> tags missing id/class -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37735|0 |1 is obsolete| | --- Comment #15 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 37760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37760&action=edit Bug 13941 [1/2] Test <body> tag with id/class attributes Test: - Apply the first patch [1/2] containg a new test checking <body> tags in all templates - Run the test: prove xt/tt_valid.t - You get a list of templates with invalid <body> tags. - Apply the second patch [2/2] fixing all invalid <body> tags. - Re-run the test: It passes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #16 from Marc Véron <veron@veron.ch> --- Patch 2/2 does not apply on current master because koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt no longer exists. Applying: Bug 13941 [2/2] Fix <body> tags missing id/class Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... error: refusing to lose untracked file at 'koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt' CONFLICT (modify/delete): koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt deleted in HEAD and modified in Bug 13941 [2/2] Fix <body> tags missing id/class. Version Bug 13941 [2/2] Fix <body> tags missing id/class of koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt left in tree. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37759|0 |1 is obsolete| | --- Comment #17 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 37774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37774&action=edit Bug 13941 [2/2] Fix <body> tags missing id/class -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37760|0 |1 is obsolete| | --- Comment #18 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 37775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37775&action=edit Bug 13941 [1/2] Test <body> tag with id/class attributes Test: - Apply the first patch [1/2] containg a new test checking <body> tags in all templates - Run the test: prove xt/tt_valid.t - You get a list of templates with invalid <body> tags. - Apply the second patch [2/2] fixing all invalid <body> tags. - Re-run the test: It passes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #19 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Marc Véron from comment #16)
Patch 2/2 does not apply on current master because koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/receipt.tt no longer exists.
Thanks. Conflict solved. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #20 from Marc Véron <veron@veron.ch> --- Created attachment 37781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37781&action=edit [Signed-off] Bug 13941 [1/2] Test <body> tag with id/class attributes Test: - Apply the first patch [1/2] containg a new test checking <body> tags in all templates - Run the test: prove xt/tt_valid.t - You get a list of templates with invalid <body> tags. - Apply the second patch [2/2] fixing all invalid <body> tags. - Re-run the test: It passes. Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37775|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #21 from Marc Véron <veron@veron.ch> --- Created attachment 37782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37782&action=edit [Signed-off] Bug 13941 [2/2] Fix <body> tags missing id/class Followed test plan (Comment #18), works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37774|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 37781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37781 [Signed-off] Bug 13941 [1/2] Test <body> tag with id/class attributes Review of attachment 37781: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13941&attachment=37781) ----------------------------------------------------------------- ::: xt/tt_valid.t @@ +55,5 @@
+ description => '<body> tag with id and class attributes', + check => sub { + my ($self, $name, $token) = @_; + return if $name =~ /bodytag\.inc/; + $_ = $token->{_string};
Sorry but I still don't understand why this is useful. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #23 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Jonathan Druart from comment #22)
Comment on attachment 37781 [details] [review] [Signed-off] Bug 13941 [1/2] Test <body> tag with id/class attributes
Review of attachment 37781 [details] [review]: -----------------------------------------------------------------
::: xt/tt_valid.t @@ +55,5 @@
+ description => '<body> tag with id and class attributes', + check => sub { + my ($self, $name, $token) = @_; + return if $name =~ /bodytag\.inc/; + $_ = $token->{_string};
Sorry but I still don't understand why this is useful.
The sub complete code is: my ($self, $name, $token) = @_; return if $name =~ /bodytag\.inc/; $_ = $token->{_string}; push @{$self->{errors}->{$name}}, $token->{_lc} if /^<body/ && ! /id=".+"/ && ! /class=".+"/; The $_ is used in the last line which should have been coded like that without $_ assignation: if $token->{_string} =~ $/^<body/ && ! $token->{_string} =~ /id=".+"/ && ! $token->{_string} =~ /class=".+"/; Hope this explanation doesn't obfuscate more something which isn't already that clear. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Frédéric Demians from comment #23)
(In reply to Jonathan Druart from comment #22)
Comment on attachment 37781 [details] [review] [review] [Signed-off] Bug 13941 [1/2] Test <body> tag with id/class attributes
Review of attachment 37781 [details] [review] [review]: -----------------------------------------------------------------
::: xt/tt_valid.t @@ +55,5 @@
+ description => '<body> tag with id and class attributes', + check => sub { + my ($self, $name, $token) = @_; + return if $name =~ /bodytag\.inc/; + $_ = $token->{_string};
Sorry but I still don't understand why this is useful.
The sub complete code is:
my ($self, $name, $token) = @_; return if $name =~ /bodytag\.inc/; $_ = $token->{_string}; push @{$self->{errors}->{$name}}, $token->{_lc} if /^<body/ && ! /id=".+"/ && ! /class=".+"/;
The $_ is used in the last line which should have been coded like that without $_ assignation:
if $token->{_string} =~ $/^<body/ && ! $token->{_string} =~ /id=".+"/ && ! $token->{_string} =~ /class=".+"/;
Hope this explanation doesn't obfuscate more something which isn't already that clear.
Sorry, read to quickly the push statement. I personally think it's a bad idea to assign the default variable, but I don't want to impose that. Without the second patch applied, I get: % prove xt/tt_valid.t xt/tt_valid.t .. Can't use string ("</head>") as a HASH ref while "strict refs" in use at xt/tt_valid.t line 60. # Looks like your test exited with 255 before it could output anything. xt/tt_valid.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/3 subtests Test Summary Report ------------------- xt/tt_valid.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 3 tests but ran 0. Files=1, Tests=0, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.10 cusr 0.00 csys = 0.12 CPU) Result: FAIL If I apply the second one, and remove an id from a body tag: % git diff diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt index 74bedcb..ffd1c1b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt @@ -123,7 +123,7 @@ function submitForm(form) { //]]> </script> </head> -<body id="acq_basketgroup" class="acq"> +<body class="acq"> [% INCLUDE 'header.inc' %] [% INCLUDE 'acquisitions-search.inc' %] % prove xt/tt_valid.t xt/tt_valid.t .. ok All tests successful. Files=1, Tests=3, 2 wallclock secs ( 0.02 usr 0.00 sys + 2.76 cusr 0.00 csys = 2.78 CPU) Result: PASS Shouldn't it fail? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Jonathan Druart from comment #24)
Sorry, read to quickly the push statement. I personally think it's a bad idea to assign the default variable, but I don't want to impose that.
I agree with you. Since I have to fix the patch due to you other comment, I will stop using default variable which doesn't add readability in these case.
Without the second patch applied, I get: % prove xt/tt_valid.t xt/tt_valid.t .. Can't use string ("</head>") as a HASH ref while "strict refs" in use at xt/tt_valid.t line 60.
It comes from fixing the warning you reported. I will send new version of the UT.
Shouldn't it fail?
Yes, it should. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37782|0 |1 is obsolete| | --- Comment #26 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 37823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37823&action=edit Bug 13941 [2/2] Fix <body> tags missing id/class -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37781|0 |1 is obsolete| | --- Comment #27 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 37824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37824&action=edit Bug 13941 [1/2] Test <body> tag with id/class attributes Test: - Apply the first patch [1/2] containing a new test checking <body> tags in all templates - Run the test: prove xt/tt_valid.t - You get a list of templates with invalid <body> tags. - Apply the second patch [2/2] fixing all invalid <body> tags. - Re-run the test: It passes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #28 from Marc Véron <veron@veron.ch> --- Created attachment 37896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37896&action=edit [Signed-off] Bug 13941 [1/2] Test <body> tag with id/class attributes Test: - Apply the first patch [1/2] containing a new test checking <body> tags in all templates - Run the test: prove xt/tt_valid.t - You get a list of templates with invalid <body> tags. - Apply the second patch [2/2] fixing all invalid <body> tags. - Re-run the test: It passes. Folowed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37824|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #29 from Marc Véron <veron@veron.ch> --- Created attachment 37897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37897&action=edit [Signed-off] Bug 13941 [2/2] Fix <body> tags missing id/class Followed test plan from patch 1/2, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37823|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 37897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37897 [Signed-off] Bug 13941 [2/2] Fix <body> tags missing id/class Review of attachment 37897: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13941&attachment=37897) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorder.tt @@ +3,4 @@
[% INCLUDE "doc-head-close.inc" %] </head>
+<body id="a" class="acq">
Typo? I think should be 'acq_addorder'. @@ +7,5 @@
[% INCLUDE "header.inc" %]
<div id="doc3" class="yui-t7">
+<div id="acq_addorder" class="acq">
This change doesn't look right - see above. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37896|0 |1 is obsolete| | Attachment #37897|0 |1 is obsolete| | --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37927&action=edit [PASSED QA] Bug 13941 [1/2] Test <body> tag with id/class attributes Test: - Apply the first patch [1/2] containing a new test checking <body> tags in all templates - Run the test: prove xt/tt_valid.t - You get a list of templates with invalid <body> tags. - Apply the second patch [2/2] fixing all invalid <body> tags. - Re-run the test: It passes. Folowed test plan, works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37929&action=edit [PASSED QA] Bug 13941 [2/2] Fix <body> tags missing id/class Followed test plan from patch 1/2, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37930&action=edit Bug 13941: QA Follow-up - fix for acqui/addorder.tt -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have written a follow-up for the problem described in the last comment - please check. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 --- Comment #35 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Katrin Fischer from comment #34)
I have written a follow-up for the problem described in the last comment - please check.
Looks good to me. I suspect other templates may have inconsistent id/class with their file name and module. I thought about improving the UT to detect that cases, but changing id/class that are here since a while may broke local JavaScript developed by libraries. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13941 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org