[Bug 26929] New: Koha will only display the first 20 macros Advanced Editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Bug ID: 26929 Summary: Koha will only display the first 20 macros Advanced Editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: nick@bywatersolutions.com Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl In 20.05, if a library has more than 20 macros, then they will not appear on the screen and will not be accessible to the cataloger. The current workaround, upping the value in this system preference, RESTdefaultPageSize - increased to 40, this will display the rest of the macros (over 20) for the library. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Depends on| |17268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Bug 26929 depends on bug 17268, which changed state. Bug 17268 Summary: Advanced cataloging editor - rancor - macros are lost when browser storage cleared https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|nick@bywatersolutions.com |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 171502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171502&action=edit Bug 26929: Fetching macros for Advanced Editor should ignore default pagesize The REST API has a default page size of 20, controlled by the preference RESTdefaultPageSize. That's fine for things that are fetched to display in pages of 20, but for things like macros in the Advanced Editor that don't implement paging, it's awkward, since when you create your 21st macro, it disappears the next time you open the editor. The Advanced Editor should instead disable paging by passing the param _per_page=-1 Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable. While you are there, set the preference RESTdefaultPageSize to 2, so you don't have to create 21 macros to see one disappear 2. Cataloging - Advanced editor - Macros 3. Click New macro..., give it the name 1, then repeat for 2 and 3 4. You have a list of macros open with all three listed, so far so good. Refresh the browser page and reopen Macros. You now have two macros 5. Apply patch, refresh the page, reopen Macros. You now have three macros 6. You should probably reset that RESTdefaultPageSize back to 20 if you aren't about to reset ktd Sponsored-by: Chetco Community Public Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171502|0 |1 is obsolete| | --- Comment #2 from Olivier V <ovezina@inlibro.com> --- Created attachment 171979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171979&action=edit Bug 26929: Fetching macros for Advanced Editor should ignore default pagesize The REST API has a default page size of 20, controlled by the preference RESTdefaultPageSize. That's fine for things that are fetched to display in pages of 20, but for things like macros in the Advanced Editor that don't implement paging, it's awkward, since when you create your 21st macro, it disappears the next time you open the editor. The Advanced Editor should instead disable paging by passing the param _per_page=-1 Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable. While you are there, set the preference RESTdefaultPageSize to 2, so you don't have to create 21 macros to see one disappear 2. Cataloging - Advanced editor - Macros 3. Click New macro..., give it the name 1, then repeat for 2 and 3 4. You have a list of macros open with all three listed, so far so good. Refresh the browser page and reopen Macros. You now have two macros 5. Apply patch, refresh the page, reopen Macros. You now have three macros 6. You should probably reset that RESTdefaultPageSize back to 20 if you aren't about to reset ktd Sponsored-by: Chetco Community Public Library Signed-off-by: Olivier V <olivier.vezina@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |ovezina@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171979|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171980&action=edit Bug 26929: Fetching macros for Advanced Editor should ignore default pagesize The REST API has a default page size of 20, controlled by the preference RESTdefaultPageSize. That's fine for things that are fetched to display in pages of 20, but for things like macros in the Advanced Editor that don't implement paging, it's awkward, since when you create your 21st macro, it disappears the next time you open the editor. The Advanced Editor should instead disable paging by passing the param _per_page=-1 Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable. While you are there, set the preference RESTdefaultPageSize to 2, so you don't have to create 21 macros to see one disappear 2. Cataloging - Advanced editor - Macros 3. Click New macro..., give it the name 1, then repeat for 2 and 3 4. You have a list of macros open with all three listed, so far so good. Refresh the browser page and reopen Macros. You now have two macros 5. Apply patch, refresh the page, reopen Macros. You now have three macros 6. You should probably reset that RESTdefaultPageSize back to 20 if you aren't about to reset ktd Sponsored-by: Chetco Community Public Library Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #8 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- This looks like a bug fix, nothing to change in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org