[Bug 36320] New: Clicking Edit items from catalogue/detail.pl leads to 'Add item' screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Bug ID: 36320 Summary: Clicking Edit items from catalogue/detail.pl leads to 'Add item' screen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl To recreate: 1. Find a record with more than 1 items attached. 2. From catalogue/detail.pl click the 'Edit' button in the toolbar to activate the dropdown. 3. Click 'Edit items'. 4. This cannot direct the user to any particular item to edit because Koha doesn't know which item you want to edit at this point. If there is a single item this should direct the user straight to an 'Edit item'. If a record has many items maybe a blank screen ( no Add Item ) would be less confusing? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #1 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- This behavior is so long-standing that I'm a little hesitant to change it. But on the other hand I've definitely trained librarians to ignore the "Edit items" button exactly because the behavior is not what one might want/expect. I agree that for a bib with just 1 item, it makes sense to assume a click on "Edit items" should edit the one available item. A blank screen when one clicks Edit Items on a record with multiple items makes sense to me. The change might be disruptive. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some ideas: * Should we remove "Edit items" from the Edit pull down, as it doesn't work as expected? * Should we rename it "Manage items" or similar? Koha bringing up the empty item form leads to confusion practically every training we do. I think an empty page with a button for new item would make a lot of sense in some scenarios. If you explicitly click "Add item" we could still bring up the form maybe? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Juliet Heltibridle <jheltibridle@rcplib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org --- Comment #3 from Juliet Heltibridle <jheltibridle@rcplib.org> --- I like the idea of changing it to "Manage items" and replacing the Add items form at the bottom with a button to add an item. I use this page for a few tasks, like duplicating an item, or editing items individually one after another instead of in a batch. Our system also has holdings on the normal view page split so other library holdings don't show in the first tab, and going to the "edit item" screen gives me a table with everyone's items, so I can see them together if needed. It looks like I could do the same things by using the Add item drop-down, so I wouldn't be opposed to getting rid of the "edit items" drop-down entirely, if that was the consensus. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 --- Comment #4 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- It's worth noting that one also ends up on the Add Item screen with a blank item form after each edit of a single item. Whatever we decide on here should also be applied to the post-edit landing page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g --- Comment #5 from Kristi <kkrueger@cuyahogalibrary.org> --- Re: I like the idea of changing it to "Manage items" and replacing the Add items form at the bottom with a button to add an item. I use this page for a few tasks, like duplicating an item, or editing items individually one after another instead of in a batch. I also like the idea of Manage items. I would hesitate to add a button to click into to add items from that form since it would add another click to the workflow. One click to get to the Add item form is ideal. Maybe "add items" could be its own option in the dropdown. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Heather <flyingendpaper@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |flyingendpaper@gmail.com --- Comment #6 from Heather <flyingendpaper@gmail.com> --- I'm in favor of ANYTHING that would be faster than my current workflow to add an item: --Find the record and from the Details display in the staff interface select "Edit items." --Spend the next 100 hours scrolling down to the bottom of the page (OK, I exaggerate, but there is MUCH scrolling!!!) --Keep scrolling. --Yet more scrolling. (Yes, we have records with a lot of items.) --When I'm FINALLY at the bottom of the screen, I can fill in the blank Add Item form. Selecting "Manage items" and then an "Add item" button on the screen on which I've landed would be much faster! I'd take two clicks (or two taps) over the almost endless scrolling! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 172830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172830&action=edit Bug 36320: Clicking Edit items from catalogue/detail.pl leads to 'Add item' screen This patch updates the catalog toolbar so that the "Edit items" choice under the "Edit" menu is replaced with two new options: "Manage items," which takes you to the top of the add/edit items page; and "Add item" which takes the user directly to the add item form (scrolling automatically past the table of existing items). The patch also adds a "Jump to add item form" link at the top of the add/edit items page. To test, apply the patch and search for a bibliographic record in the staff interface. - View the detail page for the record. - Click the "Edit" menu button in the toolbar. - You should see the two new menu items, "Manage items" and "Add item." - Clicking the "Manage items" button should take you to the top of the add/edit items page in cataloging. - You should see a "Jump to add item form" limk under the page heading. - Clicking it should jump you to the "Add item" form. - Clicking the "Add item" menu item from the bibliographic detail "Edit" menu should take you directly to the add item form, scrolling down past the existing items. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 --- Comment #8 from Kristi <kkrueger@cuyahogalibrary.org> --- I am going through the test steps in a sandbox. The steps work ok if there are one or two items on a record. I added 30 items to a record, and clicking on "Jump to add item form" and "add item" do not scroll the page down far enough to get past the item holdings to the form. (Screenshot on the way). Looking forward to trying it again soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 --- Comment #9 from Kristi <kkrueger@cuyahogalibrary.org> --- Created attachment 172832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172832&action=edit Screen jump for bib with many items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Kristi from comment #8)
I added 30 items to a record, and clicking on "Jump to add item form" and "add item" do not scroll the page down far enough to get past the item holdings to the form.
This is probably the same issue as Bug 37945. We don't want to lose the fixed header on the items table here so I will investigate an alternative solution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172830|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 172870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172870&action=edit Bug 36320: Clicking Edit items from catalogue/detail.pl leads to 'Add item' screen This patch updates the catalog toolbar so that the "Edit items" choice under the "Edit" menu is replaced with two new options: "Manage items," which takes you to the top of the add/edit items page; and "Add item" which takes the user directly to the add item form (scrolling automatically past the table of existing items). The patch also adds a "Jump to add item form" link at the top of the add/edit items page. To test, apply the patch and search for a bibliographic record in the staff interface. - View the detail page for the record. - Click the "Edit" menu button in the toolbar. - You should see the two new menu items, "Manage items" and "Add item." - Clicking the "Manage items" button should take you to the top of the add/edit items page in cataloging. - You should see a "Jump to add item form" limk under the page heading. - Clicking it should jump you to the "Add item" form. - Clicking the "Add item" menu item from the bibliographic detail "Edit" menu should take you directly to the add item form, scrolling down past the existing items. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172870|0 |1 is obsolete| | --- Comment #12 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 172889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172889&action=edit Bug 36320: Clicking Edit items from catalogue/detail.pl leads to 'Add item' screen This patch updates the catalog toolbar so that the "Edit items" choice under the "Edit" menu is replaced with two new options: "Manage items," which takes you to the top of the add/edit items page; and "Add item" which takes the user directly to the add item form (scrolling automatically past the table of existing items). The patch also adds a "Jump to add item form" link at the top of the add/edit items page. To test, apply the patch and search for a bibliographic record in the staff interface. - View the detail page for the record. - Click the "Edit" menu button in the toolbar. - You should see the two new menu items, "Manage items" and "Add item." - Clicking the "Manage items" button should take you to the top of the add/edit items page in cataloging. - You should see a "Jump to add item form" limk under the page heading. - Clicking it should jump you to the "Add item" form. - Clicking the "Add item" menu item from the bibliographic detail "Edit" menu should take you directly to the add item form, scrolling down past the existing items. Sponsored-by: Athens County Public Libraries Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 --- Comment #13 from Kristi <kkrueger@cuyahogalibrary.org> --- Going through these steps this morning with a 33-item bib looked good. To test, apply the patch and search for a bibliographic record in the staff interface. - View the detail page for the record. - Click the "Edit" menu button in the toolbar. - You should see the two new menu items, "Manage items" and "Add item." - Clicking the "Manage items" button should take you to the top of the add/edit items page in cataloging. - You should see a "Jump to add item form" limk under the page heading. - Clicking it should jump you to the "Add item" form. - Clicking the "Add item" menu item from the bibliographic detail "Edit" menu should take you directly to the add item form, scrolling down past the existing items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 --- Comment #14 from Juliet Heltibridle <jheltibridle@rcplib.org> --- I don't think it is necessary to add the Add item button to the Edit drop-down. There's already a new item in the new drop-down which does the same thing. Otherwise, this is a great improvement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172889|0 |1 is obsolete| | --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 173052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173052&action=edit Bug 36320: Clicking Edit items from catalogue/detail.pl leads to 'Add item' screen This patch updates the catalog toolbar so that the "Edit items" choice under the "Edit" menu is replaced with a new option: "Manage items," which takes you to the top of the add/edit items page. The "New item" menu item has been modified to add the anchor so that the link jumps the user directly to add item form (past the existing items). The patch also adds a "Jump to add item form" link at the top of the add/edit items page. To test, apply the patch and search for a bibliographic record in the staff interface. - View the detail page for the record. - Click the "Edit" menu button in the toolbar. - You should see the new menu item, "Manage items." - Clicking the "Manage items" button should take you to the top of the add/edit items page in cataloging. - You should see a "Jump to add item form" limk under the page heading. - Clicking it should jump you to the "Add item" form. - Clicking the "New item" menu item from the bibliographic detail "New" menu should take you directly to the add item form, scrolling down past the existing items. Sponsored-by: Athens County Public Libraries Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Juliet Heltibridle from comment #14)
There's already a new item in the new drop-down
Of course, you're correct. I've modified the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173052|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173505&action=edit Bug 36320: Clicking Edit items from catalogue/detail.pl leads to 'Add item' screen This patch updates the catalog toolbar so that the "Edit items" choice under the "Edit" menu is replaced with a new option: "Manage items," which takes you to the top of the add/edit items page. The "New item" menu item has been modified to add the anchor so that the link jumps the user directly to add item form (past the existing items). The patch also adds a "Jump to add item form" link at the top of the add/edit items page. To test, apply the patch and search for a bibliographic record in the staff interface. - View the detail page for the record. - Click the "Edit" menu button in the toolbar. - You should see the new menu item, "Manage items." - Clicking the "Manage items" button should take you to the top of the add/edit items page in cataloging. - You should see a "Jump to add item form" limk under the page heading. - Clicking it should jump you to the "Add item" form. - Clicking the "New item" menu item from the bibliographic detail "New" menu should take you directly to the add item form, scrolling down past the existing items. Sponsored-by: Athens County Public Libraries Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Clicking Edit items from |Clicking 'Edit items' from |catalogue/detail.pl leads |detail page in staff |to 'Add item' screen |interface leads to 'Add | |item' screen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #19 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Merge conflicts with 24.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39400 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39400 [Bug 39400] "Jump to add item form" doesn't work while editing an existing item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36320 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1077 CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org