https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39398 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179558&action=edit Screenshot of the proposed updated interface -- UNIMARC For the UNIMARC version I wanted to be able to break up the UNIMARC-specific search fields into smaller chunks so they could be displayed in a grid too. In this screenshot you can see I split the "Coded fields" section into two: "Coded fields" and "More coded fields" but that seems a little silly. Perhaps someone could think of a more intelligent way to organize those form fields so that each section could have a more descriptive name? I'm also interested in giving labels to the two "Picture" fields. Are the terms "Graphics type" and "Graphics support" sensible to display to the user? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39398 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com --- Comment #4 from Aude Charillon <aude.charillon@ptfs-europe.com> ---

From a MARC21 user: looks good! Makes it all look nicer and clearer :-)

Out of curiosity: are you leaving the drop-down lists as they are for this piece of work, or are they going to become more flexible like the Item search picklists? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39398 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39398 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- I don't think this is necessarily ready for signoff, but I wanted to send the patch so folks could test. I think it especially needs confirmation that searching is working correctly I'd love to get some opinions from UNIMARC libraries about how we might better break up the options which were previously grouped under the "Afficher les filtres sur les données codées" link. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39398 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com --- Comment #8 from Eric Bégin <eric.begin@inLibro.com> --- Love it ! I noted an extra <p> under the "Subtype limits" which offset the Audience label. With more test, I noted that clicking the checkbox of the itemtypes doesn't get check, we need to click the images to do so. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39398 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39398 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39398 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180975|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184940&action=edit Bug 39398: (follow-up) Fix click handling of itype/ccode/loc checkboxes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39398 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39398 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 188481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188481&action=edit Bug 39398: (follow-up) Fix click handling of itype/ccode/loc checkboxes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39398 --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 190483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190483&action=edit Bug 39398: Improve style and layout of staff interface advanced search form This patch updates the staff interface advanced search form to make it more responsive and to style it similarly to the item search form. To test, apply the patch and rebuild the staff interface CSS. - Go to the advanced search page in the staff interface. - Test the layout at various widths. Everything should adjust well. - Test in the "More options" view. - Test that adding and removing fields works correctly. - Test when using Zebra and Elasticsearch (SearchEngine system preference). - With Elasticsearch, test with ElasticsearchMARCFormat set to "Searchable array". - Test with IncludeSeeFromInSearches enabled. - Test using both MARC21 and UNIMARC. - Confirm that searching works correctly in all cases. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39398 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement improves release notes| |the layout of the advanced | |search form in the staff | |interface, making it easy | |to identify the options | |available. These are | |grouped into sections, and | |it is easier to scan for | |the options and values. See | |screenshots. CC| |david@davidnind.com --- Comment #16 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. The issues noted below happened before the patch as well, so are existing behavours. 2. I didn't really test ElasticsearchMARCFormat set to "Searchable array" and IncludeSeeFromInSearches, as I'm not sure what I'm looking for. Had them enabled though. MARC21 and UNIMARC - Zebra and Elasticsearch - quotes around search term ============================================ 1. Search so that you get no results (with or without more options toggled): - Keyword: a - Keyword for UNIMARC: sdfg - Subtype: Audience = Preschool (or primary for UNIMARC) 2. You get no results 3. Click "Edit this search" 4. Note that the keyword (a or sdfg) has quotes around it 5. Click search again 6. Still no results 7. Click "Edit this search" again 8. Note that there are now two sets of quotes around the a: ""a"" 9. If you keep repeating this, you get more quotes 10. Not sure if this actually makes any difference or not UNIMARC - Zebra and Elasticsearch ================================= 1. Under the 'Picture' options, there are two dropdown lists, starting with Any but with different values. There are no field labels shown. Maybe call them what UNIMARC field 116 builder calls them? (https://www.ifla.org/unimarc-updates/unimarc-bibliographic-format-manual-onl... page 120) - Specific material designation (or Material) (collage, drawing, etc) - Primary support material (or Support material) (canvas, etc) - Maybe instead of 'Picture' the heading should be called 'Graphics' - Definitely something to ask UNIMARC people about 2. Enter a as a keyword search, under coded fields for audience select a value (for example, juvenile, general), and click search: - After the search results are shown, click 'Edit this search' - Note that there is now an "Other limits" options area with ta:a and a tick (between location and availability options and sorting options) - If you select other values from other search options, these are shown under "Other limits" with codes, and the values you selected aren't pre-populated in the dropdown lists 3. I could replicate the Zebra (MARC21 and UNIMARC) issue with quotes around the search term when there are no results. To start KTD with UNIMARC = edit .env file and change KOHA_MARC_FLAVOUR=UNIMARC or start up KTD with: KOHA_MARC_FLAVOUR=UNIMARC ktd --es7 up To reindex Elasticsearch: koha-elasticsearch --rebuild -d -b -a kohadev -- You are receiving this mail because: You are watching all bug changes.