[Bug 42786] New: Unauthenticated user details lost when progressing ILL request without linking it to a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42786 Bug ID: 42786 Summary: Unauthenticated user details lost when progressing ILL request without linking it to a patron Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: aude.charillon@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: lisette@bywatersolutions.com, pedro.amorim@openfifth.co.uk, tomascohen@gmail.com When using ILLOpacUnauthenticatedRequest, the correct workflow is for library staff to link the unauthenticated ILL request to a patron record before progressing the request. However, if they forget and go straight to progressing the request, there is no block or warning, and the contact details entered by the user disappear. To replicate: 1. Set ILLmodule system preference to Enable. 2. Set ILLOpacUnauthenticatedRequest system preference to Allow. 3. Go to the OPAC, make sure you are not logged in. Place a new interlibrary loan request ({yourdomain}/cgi-bin/koha/opac-illrequests.pl?op=create) 4. Go to the staff interface > ILL module. 5. View your unauthenticated request. There is a section for "Unauthenticated request details" containing the user details. 6. Progress the request: e.g. click Confirm request, then confirm again on the next screen. 7. You are returned to the request view. There is no "Unauthenticated request details" section any more, even though the request has not been linked to a Koha patron. In my opinion, staff should not be able to progress the request (confirm the request or place the request with partners) until it has been linked to a patron record. Or, at the minimum, the "Unauthenticated request details" should be retained until the request has been linked to a patron record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42786 --- Comment #1 from Aude Charillon <aude.charillon@openfifth.co.uk> --- To note: the unauthenticated details usually remain visible when using the "Display supplier metadata" button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42786 --- Comment #2 from Bernard <bernard.scaife@openfifth.co.uk> --- Created attachment 200738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200738&action=edit Bug 42786 Display unauthenticated user details in both ILL view or edit forms where patron id is not set, regardless of whether status is unauthenticated. Test plan. 1. Set ILLmodule system preference to Enable. 2. Set ILLOpacUnauthenticatedRequest system preference to Allow. 3. Go to the OPAC, make sure you are not logged in (eg Incognito winde). Place a new interlibrary loan request via this link ({yourdomain}/cgi-bin/koha/opac-illrequests.pl?op=create) 4. Go to the staff interface > ILL module. 5. View your unauthenticated request. There is a section for "Unauthenticated request details" containing the user details. 6. Progress the request: e.g. click Confirm request, then confirm again on the next screen. 7. You are returned to the request view. There is no "Unauthenticated request details" section any more, even though the request has not been linked to a Koha patron. Neither is the if you edit request 8. Install patch and restart_all 9. Return to the ILL request list and click manage request on the request you were using above. 10. Note Unauthenticated request details section now exists 11. Click edit request and note they are also there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42786 Bernard <bernard.scaife@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bernard.scaife@openfifth.co | |.uk Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42786 R Bradshaw <rebecca.bradshaw@nnuh.nhs.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rebecca.bradshaw@nnuh.nhs.u | |k Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42786 --- Comment #3 from R Bradshaw <rebecca.bradshaw@nnuh.nhs.uk> --- I completed: 1. Set ILLmodule system preference to Enable. 2. Set ILLOpacUnauthenticatedRequest system preference to Allow. 3. Go to the OPAC, make sure you are not logged in. Place a new interlibrary loan request ({yourdomain}/cgi-bin/koha/opac-illrequests.pl?op=create) 4. Go to the staff interface > ILL module. 5. View your unauthenticated request. There is a section for "Unauthenticated request details" containing the user details. 6. Progress the request: e.g. click Confirm request, then confirm again on the next screen. 7. You are returned to the request view. There is no "Unauthenticated request details" section any more, even though the request has not been linked to a Koha patron. All worked fine for me! Thanks Bernard. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42786 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m Keywords| |release-notes-needed Assignee|koha-bugs@lists.koha-commun |bernard.scaife@openfifth.co |ity.org |.uk --- Comment #4 from Lisette Scheer <lisette@bywatersolutions.com> --- Patch doesn't apply (it looks like there's some template changes that it's conflicting with) Additionally, the commit message needs to follow the commit guidelines, especially the title. Those can be found on the wiki: https://wiki.koha-community.org/wiki/Commit_messages (Display unauthenticated user details in both ILL view or edit forms would probably be good for the description) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org