[Bug 34131] New: Plugins page breadcrumbs and side menu not consistent
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Bug ID: 34131 Summary: Plugins page breadcrumbs and side menu not consistent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Install a tool plugin: https://github.com/bywatersolutions/koha-plugin-label-maker/releases/tag/v1.... Install a non-tool plugin: https://github.com/PTFS-Europe/koha-plugin-ill-avail-browzine/releases/tag/1... 1) Go to admin and click "Manage plugins", check the side menu, it's highlighted on "Tool plugins" and the side menu is from tools, not admin. 2) Go to admin and click "Manage jobs", check the side menu, "Plugins" is there, but when you click on it, you go to 1), and can't come back. 3) On the plugin page at /cgi-bin/koha/plugins/plugins-home.pl Notice how the breadcrumbs are "Tools > Plugins" even when "View plugins by class" is set to all, or a different plugin class. 4) Apply patch, verify again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 152727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152727&action=edit Bug 34131: Update breadcrumbs and side bar Update plugins-home accordingly if tool plugins only filter is being used or not Update breadcrumbs for plugins-disabled page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 152728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152728&action=edit Bug 34131: Add 'current' class on correct side menu link This changes the way we're looking for the correct menu item to set as active. If we don't find an exact match for path+params, we attempt to set 'current' to just matching on path. What this does is it sets the 'Plugins' menu item as active, even if the url is 'plugins-home.pl?method=report -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com, oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152727|0 |1 is obsolete| | Attachment #152728|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152745&action=edit Bug 34131: Update breadcrumbs and side bar Update plugins-home accordingly if tool plugins only filter is being used or not. Update breadcrumbs for plugins-disabled page Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152746&action=edit Bug 34131: Add 'current' class on correct side menu link This changes the way we're looking for the correct menu item to set as active. If we don't find an exact match for path+params, we attempt to set 'current' to just matching on path. What this does is it sets the 'Plugins' menu item as active, even if the url is 'plugins-home.pl?method=report Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart+koha@gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Can you detail what is doing the second patch? On http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha/plugins/plugins-home.pl... ".current" is not set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 153150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153150&action=edit ill_availability_services (In reply to Jonathan Druart from comment #5)
Can you detail what is doing the second patch?
On http://kohadev-intra.mydnsname.org:8081/cgi-bin/koha/plugins/plugins-home. pl?method=ill_availability_services ".current" is not set
The patch makes it so that the ".current" class is applied to the parent side menu item even if a URL param exists, instead of matching on exact URL, potentially not containing URL params, and failing. I can't reproduce what you're reporting, it shows for me. See attached. I'm preparing a couple follow-up QA patches, will update bug status shortly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 153151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153151&action=edit Bug 34131: (QA follow-up): Add 'ill_availability_services' to method filter check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 153152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153152&action=edit Bug 34131: (QA follow-up) Update page title to reflect breadcrumbs and side-menu behaviour -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152745|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153164&action=edit Bug 34131: Update breadcrumbs and side bar Update plugins-home accordingly if tool plugins only filter is being used or not. Update breadcrumbs for plugins-disabled page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152746|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153165&action=edit Bug 34131: Add 'current' class on correct side menu link This changes the way we're looking for the correct menu item to set as active. If we don't find an exact match for path+params, we attempt to set 'current' to just matching on path. What this does is it sets the 'Plugins' menu item as active, even if the url is 'plugins-home.pl?method=report Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153151|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153166&action=edit Bug 34131: (QA follow-up): Add 'ill_availability_services' to method filter check Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153152|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153167&action=edit Bug 34131: (QA follow-up) Update page title to reflect breadcrumbs and side-menu behaviour Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34131 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org