https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34201 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33973 [Bug 33973] Sorting broken on ERM tables -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34201 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153053&action=edit Bug 34201: Restore sorting indicator on ERM tables DataTable Vue component keep the 'sorting' class on the th which display the grey up/down icon over the blue icon which indicate the current sort column Test plan: Create several agreements, notice that the list view is having the sorting indicators (blue arrows) in the top right of the first column. Sort the columns: asc, desc, combined sort (shift+click) and confirm that the indicators are correct -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34201 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34201 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153053|0 |1 is obsolete| | --- Comment #3 from Sam Lau <samalau@gmail.com> --- Created attachment 153068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153068&action=edit Bug 34201: Restore sorting indicator on ERM tables DataTable Vue component keep the 'sorting' class on the th which display the grey up/down icon over the blue icon which indicate the current sort column Test plan: Create several agreements, notice that the list view is having the sorting indicators (blue arrows) in the top right of the first column. Sort the columns: asc, desc, combined sort (shift+click) and confirm that the indicators are correct Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34201 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153069&action=edit Bug 34201: (follow-up) Add additional specific CSS This patch adds more CSS to make sure this works in Vue and non-Vue pages. On non-Vue pages there are these three states: .sorting, .sorting_asc, .sorting_desc On the ERM page with Vue there is: .sorting, .sorting.sorting_asc, .sorting.sorting_desc This patch ensures all are covered. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34201 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153069|0 |1 is obsolete| | --- Comment #5 from Sam Lau <samalau@gmail.com> --- Created attachment 153076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153076&action=edit Bug 34201: (follow-up) Add additional specific CSS This patch adds more CSS to make sure this works in Vue and non-Vue pages. On non-Vue pages there are these three states: .sorting, .sorting_asc, .sorting_desc On the ERM page with Vue there is: .sorting, .sorting.sorting_asc, .sorting.sorting_desc This patch ensures all are covered. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34201 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Re-testing this today I find you're correct. My patch is not necessary. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34201 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34201 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34201 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34201 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.