[Bug 35581] New: ILL Koha classes are not consistent

newer
[Bug 36867] ILS-DI AuthorizedIPs...

older
[Bug 35082] New: Koha::Illbatch...

bugzilla-daemon＠bugs.koha-community.org

15 Dec 2023 15 Dec '23

10:20 a.m.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Bug ID: 35581 Summary: ILL Koha classes are not consistent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

Show replies by date

bugzilla-daemon＠bugs.koha-community.org

15 Dec 15 Dec

11:03 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

11:03 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:03 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159863&action=edit Bug 35581: Illbackend.pm -> ILL/Backend.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

11:03 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159864&action=edit Bug 35581: Illbatch.pm -> ILL/Batch.pm Illbatches.pm -> ILL/Batches.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

11:04 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159865&action=edit Bug 35581: Illbatchstatus.pm -> ILL/Batch/status.pm Illbatchstatuses.pm -> ILL/Batch/Statuses.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:04 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159866&action=edit Bug 35581: Illcomment.pm -> ILL/Comment.pm Illcomments.pm -> ILL/Comments.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:04 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159867&action=edit Bug 35581: Illrequestattribute.pm -> ILL/Request/Attribute.pm Illrequestattributes.pm -> ILL/Request/Attributes.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:04 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159868&action=edit Bug 35581: Koha/Illrequest/Workflow.pm -> Koha/ILL/Request/Workflow.pm Koha/Illrequest/Workflow/Availability.pm -> Koha/ILL/Request/Workflow/Availability.pm Koha/Illrequest/Workflow/TypeDisclaimer.pm -> Koha/ILL/Request/Workflow/TypeDisclaimer.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

11:04 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159869&action=edit Bug 35581: Koha/Illrequest/Config.pm -> Koha/ILL/Request/Config.pm -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:04 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159870&action=edit Bug 35581: Koha/Illrequest/Logger.pm -> Koha/ILL/Request/Logger.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

11:04 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159871&action=edit Bug 35581: Koha/Illrequest/SupplierUpdate.pm -> Koha/ILL/Request/SupplierUpdate.pm Koha/Illrequest/SupplierUpdateProcessor.pm -> Koha/ILL/Request/SupplierUpdateProcessor.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

11:04 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #10 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159872&action=edit Bug 35581: Koha/Illrequest.pm -> Koha/ILL/Request.pm Koha/Illrequests.pm -> Koha/ILL/Requests.pm Merged: t/db_dependent/Koha/Illrequests.t t/db_dependent/Illrequests.t Into: t/db_dependent/Koha/ILL/Requests.t ILL classes file structure is, for the most part, around 7 years old and doesn't follow a strict logic. It's so confusing that some test files exist redundantly. This housekeeping should help future work in regards to ISO18626 to add Koha as a supplying agency instead of just requesting agency, as is now. It should also help future housekeeping of moving backend related logic out of the Illrequest.pm into Illbackend.pm (now ILL/Request.pm and ILL/Backend.pm as of this patchset). It should also help in structuring the addition of a master generic form (see bug 35570) This patchset will require existing backends to be updated to match the new class names and structure, if they invoke them. Test plan, k-t-d, run tests: prove t/db_dependent/api/v1/ill_* prove t/db_dependent/Koha/ILL/* Test plan, k-t-d, manual: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) You'll have to switch the FreeForm repo to the one compatible with this work, like: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout reorganize_ILL 3) Do some generic ILL testing: 3.1) Create a request 3.2) Add a comment to a request 3.3) Edit a request 3.4) Edit a request's item metadata 3.5) Confirm a request 3.6) List requests 3.7) Filter requests list using left side filters 4) Install a metadata enrichment plugin: https://github.com/PTFS-Europe/koha-plugin-api-pubmed 4.1) Create an ILL batch and insert a pubmedid like 123 4.2) Add the request and finish batch 5) Verify all of the above works as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:04 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 159873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159873&action=edit Bug 35581: QA Follow-up: Fix tidy warnings Fix forbidden pattern: Incorrect license statement (using postal address) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:05 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605 [Bug 19605] ILL backends should be pluggable through regular Koha plugins -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

11:07 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35570 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

bugzilla-daemon＠bugs.koha-community.org

11:09 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:33 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:09 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 [Bug 35570] Add a generic master form in ILL -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

2 Jan 2 Jan

7:10 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:10 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

7:10 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

7:10 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

7:10 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

7:10 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

7:10 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

7:10 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

7:10 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

7:10 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

7:11 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159872|0 |1 is obsolete| | --- Comment #21 from David Nind <david@davidnind.com> --- Created attachment 160431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160431&action=edit Bug 35581: Koha/Illrequest.pm -> Koha/ILL/Request.pm Koha/Illrequests.pm -> Koha/ILL/Requests.pm Merged: t/db_dependent/Koha/Illrequests.t t/db_dependent/Illrequests.t Into: t/db_dependent/Koha/ILL/Requests.t ILL classes file structure is, for the most part, around 7 years old and doesn't follow a strict logic. It's so confusing that some test files exist redundantly. This housekeeping should help future work in regards to ISO18626 to add Koha as a supplying agency instead of just requesting agency, as is now. It should also help future housekeeping of moving backend related logic out of the Illrequest.pm into Illbackend.pm (now ILL/Request.pm and ILL/Backend.pm as of this patchset). It should also help in structuring the addition of a master generic form (see bug 35570) This patchset will require existing backends to be updated to match the new class names and structure, if they invoke them. Test plan, k-t-d, run tests: prove t/db_dependent/api/v1/ill_* prove t/db_dependent/Koha/ILL/* Test plan, k-t-d, manual: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) You'll have to switch the FreeForm repo to the one compatible with this work, like: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout reorganize_ILL 3) Do some generic ILL testing: 3.1) Create a request 3.2) Add a comment to a request 3.3) Edit a request 3.4) Edit a request's item metadata 3.5) Confirm a request 3.6) List requests 3.7) Filter requests list using left side filters 4) Install a metadata enrichment plugin: https://github.com/PTFS-Europe/koha-plugin-api-pubmed 4.1) Create an ILL batch and insert a pubmedid like 123 4.2) Add the request and finish batch 5) Verify all of the above works as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7:11 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

7:17 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

8 Jan 8 Jan

12:06 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #24 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 160620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160620&action=edit Bug 35581: (QA follow-up): Missed Illrequests.pm REST API class Koha/REST/V1/Illrequests.pm -> Koha/REST/V1/ILL/Requests.pm Test plan: 1 Apply patch 2 Make sure tests pass, run: prove t/db_dependent/api/v1/ill_* -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:20 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35331 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35331 [Bug 35331] Add an ILL table actions plugin hook -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:22 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #25 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 160622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160622&action=edit Bug 35581: (QA follow-up): Update changes coming from bug 35331 Test plan: prove t/db_dependent/Koha/Plugins/Ill_hooks.t -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12 Feb 12 Feb

12:52 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

12:52 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

12:52 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

12:52 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

12:52 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

12:52 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

12:52 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

12:52 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

12:52 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

12:52 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160431|0 |1 is obsolete| | --- Comment #35 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162029&action=edit Bug 35581: Koha/Illrequest.pm -> Koha/ILL/Request.pm Koha/Illrequests.pm -> Koha/ILL/Requests.pm Merged: t/db_dependent/Koha/Illrequests.t t/db_dependent/Illrequests.t Into: t/db_dependent/Koha/ILL/Requests.t ILL classes file structure is, for the most part, around 7 years old and doesn't follow a strict logic. It's so confusing that some test files exist redundantly. This housekeeping should help future work in regards to ISO18626 to add Koha as a supplying agency instead of just requesting agency, as is now. It should also help future housekeeping of moving backend related logic out of the Illrequest.pm into Illbackend.pm (now ILL/Request.pm and ILL/Backend.pm as of this patchset). It should also help in structuring the addition of a master generic form (see bug 35570) This patchset will require existing backends to be updated to match the new class names and structure, if they invoke them. Test plan, k-t-d, run tests: prove t/db_dependent/api/v1/ill_* prove t/db_dependent/Koha/ILL/* Test plan, k-t-d, manual: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) You'll have to switch the FreeForm repo to the one compatible with this work, like: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout reorganize_ILL 3) Do some generic ILL testing: 3.1) Create a request 3.2) Add a comment to a request 3.3) Edit a request 3.4) Edit a request's item metadata 3.5) Confirm a request 3.6) List requests 3.7) Filter requests list using left side filters 4) Install a metadata enrichment plugin: https://github.com/PTFS-Europe/koha-plugin-api-pubmed 4.1) Create an ILL batch and insert a pubmedid like 123 4.2) Add the request and finish batch 5) Verify all of the above works as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

12:52 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

12:52 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

12:52 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

12:54 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #39 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Rebased on bug 34282 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

21 Feb 21 Feb

4 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com, | |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

6 Mar 6 Mar

10:44 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:44 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:44 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:44 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:44 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:44 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:44 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:44 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:45 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:45 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162029|0 |1 is obsolete| | --- Comment #49 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162826&action=edit Bug 35581: Koha/Illrequest.pm -> Koha/ILL/Request.pm Koha/Illrequests.pm -> Koha/ILL/Requests.pm Merged: t/db_dependent/Koha/Illrequests.t t/db_dependent/Illrequests.t Into: t/db_dependent/Koha/ILL/Requests.t ILL classes file structure is, for the most part, around 7 years old and doesn't follow a strict logic. It's so confusing that some test files exist redundantly. This housekeeping should help future work in regards to ISO18626 to add Koha as a supplying agency instead of just requesting agency, as is now. It should also help future housekeeping of moving backend related logic out of the Illrequest.pm into Illbackend.pm (now ILL/Request.pm and ILL/Backend.pm as of this patchset). It should also help in structuring the addition of a master generic form (see bug 35570) This patchset will require existing backends to be updated to match the new class names and structure, if they invoke them. Test plan, k-t-d, run tests: prove t/db_dependent/api/v1/ill_* prove t/db_dependent/Koha/ILL/* Test plan, k-t-d, manual: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) You'll have to switch the FreeForm repo to the one compatible with this work, like: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout reorganize_ILL 3) Do some generic ILL testing: 3.1) Create a request 3.2) Add a comment to a request 3.3) Edit a request 3.4) Edit a request's item metadata 3.5) Confirm a request 3.6) List requests 3.7) Filter requests list using left side filters 4) Install a metadata enrichment plugin: https://github.com/PTFS-Europe/koha-plugin-api-pubmed 4.1) Create an ILL batch and insert a pubmedid like 123 4.2) Add the request and finish batch 5) Verify all of the above works as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:45 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:45 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:45 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:46 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #53 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Rebased on bug 34478 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

7 Mar 7 Mar

10:31 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36245 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36245 [Bug 36245] ILL - Custom backend form action is broken -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:36 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:36 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:36 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:36 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:36 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:36 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:36 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:36 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:36 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:37 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162826|0 |1 is obsolete| | --- Comment #63 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 162889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162889&action=edit Bug 35581: Koha/Illrequest.pm -> Koha/ILL/Request.pm Koha/Illrequests.pm -> Koha/ILL/Requests.pm Merged: t/db_dependent/Koha/Illrequests.t t/db_dependent/Illrequests.t Into: t/db_dependent/Koha/ILL/Requests.t ILL classes file structure is, for the most part, around 7 years old and doesn't follow a strict logic. It's so confusing that some test files exist redundantly. This housekeeping should help future work in regards to ISO18626 to add Koha as a supplying agency instead of just requesting agency, as is now. It should also help future housekeeping of moving backend related logic out of the Illrequest.pm into Illbackend.pm (now ILL/Request.pm and ILL/Backend.pm as of this patchset). It should also help in structuring the addition of a master generic form (see bug 35570) This patchset will require existing backends to be updated to match the new class names and structure, if they invoke them. Test plan, k-t-d, run tests: prove t/db_dependent/api/v1/ill_* prove t/db_dependent/Koha/ILL/* Test plan, k-t-d, manual: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) You'll have to switch the FreeForm repo to the one compatible with this work, like: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout reorganize_ILL 3) Do some generic ILL testing: 3.1) Create a request 3.2) Add a comment to a request 3.3) Edit a request 3.4) Edit a request's item metadata 3.5) Confirm a request 3.6) List requests 3.7) Filter requests list using left side filters 4) Install a metadata enrichment plugin: https://github.com/PTFS-Europe/koha-plugin-api-pubmed 4.1) Create an ILL batch and insert a pubmedid like 123 4.2) Add the request and finish batch 5) Verify all of the above works as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:37 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:37 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:37 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

10:37 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #67 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Rebased on bug 36245 -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

25 Mar 25 Mar

1:22 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:27 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:27 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162880|0 |1 is obsolete| | Attachment #162881|0 |1 is obsolete| | Attachment #162882|0 |1 is obsolete| | Attachment #162883|0 |1 is obsolete| | Attachment #162884|0 |1 is obsolete| | Attachment #162885|0 |1 is obsolete| | Attachment #162886|0 |1 is obsolete| | Attachment #162887|0 |1 is obsolete| | Attachment #162888|0 |1 is obsolete| | Attachment #162889|0 |1 is obsolete| | Attachment #162890|0 |1 is obsolete| | Attachment #162891|0 |1 is obsolete| | Attachment #162892|0 |1 is obsolete| | --- Comment #68 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163803&action=edit Bug 35581: Koha::Illbackend -> Koha::ILL::Backend Koha/Illbackend.pm -> Koha/ILL/Backend.pm Koha/REST/V1/Illbackends.pm -> Koha/REST/V1/ILL/Backends.pm Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:27 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #69 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163804&action=edit Bug 35581: Koha::*Illbatch* -> Koha::*ILL::*Batch* Koha/Illbatch.pm -> Koha/ILL/Batch.pm Koha/Illbatches.pm -> Koha/ILL/Batches.pm Koha/REST/V1/Illbatches.pm -> Koha/REST/V1/ILL/Batches.pm t/db_dependent/Koha/Illbatch.t -> t/db_dependent/Koha/ILL/Batch.t t/db_dependent/Illbatches.t -> t/db_dependent/Koha/ILL/Batches.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:27 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #70 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163805&action=edit Bug 35581: Illbatchstatus* -> ILL::Batch::Status* Koha/IllbatchStatus.pm -> Koha/ILL/Batch/Status.pm Koha/IllbatchStatuses.pm -> Koha/ILL/Batch/Statuses.pm Koha/REST/V1/IllbatchStatuses.pm -> Koha/REST/V1/ILL/Batch/Statuses.pm Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:28 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #71 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163806&action=edit Bug 35581: Koha::Illcomment* -> Koha::ILL::Comment* Koha/Illcomment.pm -> Koha/ILL/Comment.pm Koha/Illcomments.pm -> Koha/ILL/Comments.pm Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:28 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #72 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163807&action=edit Bug 35581: Koha::Illrequestattribute* -> Koha::ILL::Request::Attribute* Koha/Illrequestattribute.pm -> Koha/ILL/Request/Attribute.pm Koha/Illrequestattributes.pm -> Koha/ILL/Request/Attributes.pm Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:29 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #73 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163808&action=edit Bug 35581: Koha::Illrequest::Workflow* -> Koha::ILL::Request::Workflow* Koha/Illrequest/Workflow.pm -> Koha/ILL/Request/Workflow.pm Koha/Illrequest/Workflow/Availability.pm -> Koha/ILL/Request/Workflow/Availability.pm Koha/Illrequest/Workflow/TypeDisclaimer.pm -> Koha/ILL/Request/Workflow/TypeDisclaimer.pm Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:30 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #74 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163809&action=edit Bug 35581: Koha::Illrequest::Config -> Koha::ILL::Request::Config Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:30 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #75 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163810&action=edit Bug 35581: Koha::Illrequest::Logger -> Koha::ILL::Request::Logger Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:31 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #76 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163811&action=edit Bug 35581: Koha::Illrequest::SupplierUpdate* -> Koha::ILL::Request::SupplierUpdate* Koha/Illrequest/SupplierUpdate.pm -> Koha/ILL/Request/SupplierUpdate.pm Koha/Illrequest/SupplierUpdateProcessor.pm -> Koha/ILL/Request/SupplierUpdateProcessor.pm Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:32 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #77 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163812&action=edit Bug 35581: Koha::Illrequest -> Koha::ILL::Request Koha/Illrequests.pm -> Koha/ILL/Requests.pm Merged: t/db_dependent/Koha/Illrequests.t t/db_dependent/Illrequests.t Into: t/db_dependent/Koha/ILL/Requests.t ILL classes file structure is, for the most part, around 7 years old and doesn't follow a strict logic. It's so confusing that some test files exist redundantly. This housekeeping should help future work in regards to ISO18626 to add Koha as a supplying agency instead of just requesting agency, as is now. It should also help future housekeeping of moving backend related logic out of the Illrequest.pm into Illbackend.pm (now ILL/Request.pm and ILL/Backend.pm as of this patchset). It should also help in structuring the addition of a master generic form (see bug 35570) This patchset will require existing backends to be updated to match the new class names and structure, if they invoke them. Test plan, k-t-d, run tests: prove t/db_dependent/api/v1/ill_* prove t/db_dependent/Koha/ILL/* Test plan, k-t-d, manual: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) You'll have to switch the FreeForm repo to the one compatible with this work, like: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout reorganize_ILL 3) Do some generic ILL testing: 3.1) Create a request 3.2) Add a comment to a request 3.3) Edit a request 3.4) Edit a request's item metadata 3.5) Confirm a request 3.6) List requests 3.7) Filter requests list using left side filters 4) Install a metadata enrichment plugin: https://github.com/PTFS-Europe/koha-plugin-api-pubmed 4.1) Create an ILL batch and insert a pubmedid like 123 4.2) Add the request and finish batch 5) Verify all of the above works as expected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:32 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #78 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163813&action=edit Bug 35581: Koha::REST::V1::Illrequests -> Koha::REST::V1::ILL::Requests Test plan: 1. Apply patch 2. Make sure tests pass, run: prove t/db_dependent/api/v1/ill_* Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:33 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #79 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163814&action=edit Bug 35581: Cleanup Comments.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:34 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #80 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163815&action=edit Bug 35581: (follow-up) Remove internal use of ->illrequestattributes By now, we shouldn't be using the deprecated method internally. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:35 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #81 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163816&action=edit Bug 35581: POD fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

28 Mar 28 Mar

4 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

4 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

4 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

4 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

4 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

4 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

4 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

4 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

4 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

4 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163812|0 |1 is obsolete| | --- Comment #91 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 164078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164078&action=edit Bug 35581: Koha::Illrequest -> Koha::ILL::Request Koha/Illrequests.pm -> Koha/ILL/Requests.pm Merged: t/db_dependent/Koha/Illrequests.t t/db_dependent/Illrequests.t Into: t/db_dependent/Koha/ILL/Requests.t ILL classes file structure is, for the most part, around 7 years old and doesn't follow a strict logic. It's so confusing that some test files exist redundantly. This housekeeping should help future work in regards to ISO18626 to add Koha as a supplying agency instead of just requesting agency, as is now. It should also help future housekeeping of moving backend related logic out of the Illrequest.pm into Illbackend.pm (now ILL/Request.pm and ILL/Backend.pm as of this patchset). It should also help in structuring the addition of a master generic form (see bug 35570) This patchset will require existing backends to be updated to match the new class names and structure, if they invoke them. Test plan, k-t-d, run tests: prove t/db_dependent/api/v1/ill_* prove t/db_dependent/Koha/ILL/* Test plan, k-t-d, manual: 1) Install FreeForm, enable ILL module, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.s...) 2) You'll have to switch the FreeForm repo to the one compatible with this work, like: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout reorganize_ILL 3) Do some generic ILL testing: 3.1) Create a request 3.2) Add a comment to a request 3.3) Edit a request 3.4) Edit a request's item metadata 3.5) Confirm a request 3.6) List requests 3.7) Filter requests list using left side filters 4) Install a metadata enrichment plugin: https://github.com/PTFS-Europe/koha-plugin-api-pubmed 4.1) Create an ILL batch and insert a pubmedid like 123 4.2) Add the request and finish batch 5) Verify all of the above works as expected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

4 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

4 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

4 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

1 Apr 1 Apr

12:40 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #96 from Tomás Cohen Arazi <tomascohen@gmail.com> --- \o/ -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

3 Apr 3 Apr

4:39 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #97 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- ./t/db_dependent/Illrequest directory still exists (it shouldn't after this work). I don't want to add anything else here before this is pushed because it's long as it is. @Tomas, @Katrin add it here or handle this later? It's not critically important anyway. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

4:42 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #98 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #97)

...

./t/db_dependent/Illrequest directory still exists (it shouldn't after this work). I don't want to add anything else here before this is pushed because it's long as it is. @Tomas, @Katrin add it here or handle this later? It's not critically important anyway.

I haven't had time to look here closely yet, leaving it to Tomas. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

17 Apr 17 Apr

9:47 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Bug 35581 depends on bug 36245, which changed state. Bug 36245 Summary: ILL - Custom backend form action is broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36245 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

22 Apr 22 Apr

7:39 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

...

(In reply to Pedro Amorim from comment #97)

...
./t/db_dependent/Illrequest directory still exists (it shouldn't after this work). I don't want to add anything else here before this is pushed because it's long as it is. @Tomas, @Katrin add it here or handle this later? It's not critically important anyway.

I haven't had time to look here closely yet, leaving it to Tomas.

Please handle any necessary follow-ups on a separate bug report. I'm adding 'additional_work'needed' so we don't forget to follow-up on this. I've added a follow-up to fix a failing test: t/db_dependent/Koha/ILL/Request.t -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:05 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:05 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #100 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:08 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36662 [Bug 36662] ILL - t/db_dependent/Illrequest should not exist -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:10 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

...

Please handle any necessary follow-ups on a separate bug report. I'm adding 'additional_work'needed' so we don't forget to follow-up on this.

I've added a follow-up to fix a failing test: t/db_dependent/Koha/ILL/Request.t

Thanks Katrin, I've opened bug 36662 detailing what was missed here and intend to follow-up on it soon. I've removed 'additional-work-needed' keyword from this one. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:15 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #102 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I wonder what release notes we should add here, if any? This is just housekeeping work that precedes future features work, there is no new behavior or functionality added here. Please advise. Thanks! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

11:27 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #103 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #102)

...

I wonder what release notes we should add here, if any? This is just housekeeping work that precedes future features work, there is no new behavior or functionality added here. Please advise. Thanks!

I was thinking of some notes for backend authors - I expect they will all have to adapt their backends to the new structure. So something like a warning maybe that stands out a bit? -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

1:27 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

...

(In reply to Pedro Amorim from comment #102)

...
I wonder what release notes we should add here, if any? This is just housekeeping work that precedes future features work, there is no new behavior or functionality added here. Please advise. Thanks!

I was thinking of some notes for backend authors - I expect they will all have to adapt their backends to the new structure. So something like a warning maybe that stands out a bit?

The backend only needs to be updated if it invokes core class methods. In our case (PTFS-E) some of our backends do, others don't. I've added text to go in the release notes and tried to have it be as clear and simple as possible. Please take a look and adapt/update as needed. Thanks! -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

24 Apr 24 Apr

6:40 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed |additional_work_needed --- Comment #105 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We have some test failures where this bug is a likely candidate: t_db_dependent_TestBuilder_t not ok 553 - Module Koha::ILL::Comments should have koha_object[s]_class method if needed not ok 554 - Module Koha::Illcomment should be defined not ok 555 - Module Koha::Illcomments should be defined -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

9:34 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 --- Comment #106 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 165448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165448&action=edit Bug 35581: Fix Illcomment schema file missing koha_object_class methods -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

10:02 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #107 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've added the requisite pieces to the schema class now.. will push shortly.. just removing the additiona_work_needed tag to prevent duplicate work. -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

23 May 23 May

3:40 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #108 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not pushed to 23.11.x -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

5 Jul 5 Jul

10:57 a.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

bugzilla-daemon＠bugs.koha-community.org

8 May 8 May

8:30 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35082 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35082 [Bug 35082] Koha::ILL::Batch should be kosher -- You are receiving this mail because: You are watching all bug changes.

bugzilla-daemon＠bugs.koha-community.org

8:31 p.m.

New subject: [Bug 35581] ILL Koha classes are not consistent

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35581 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35083 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35083 [Bug 35083] Koha::ILL::Batch::Status should be kosher -- You are receiving this mail because: You are watching all bug changes.

433

Age (days ago)

943

Last active (days ago)

List overview

Download

127 comments

1 participants

participants (1)

bugzilla-daemon＠bugs.koha-community.org

[Bug 35581] New: ILL Koha classes are not consistent

tags

participants (1)