[Bug 24421] New: Generated authorities are missing subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Bug ID: 24421 Summary: Generated authorities are missing subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org In bug 21826 the intent was to only add allowed subfields to generated authorities, however, the code uses the authority tag instead of the biblio tag - there is no mapping for these, so correct subfields are ignored To recreate: 1 - Enable the sysprefs AutoCreateAuthorities BiblioAddsAuthorities CatalogModuleRelink 2 - Open a record with a subject heading with a subdivision and add a new subfield, or add a new unauthroized heading to a record and save it e.g. 650$aChess$xOpenings$vFiction. 3 - Save the record, note the created authority and that field is linked 4 - Save the record again and note the authority number changes 5 - Find and view the authority linked to the record 6 - The record is for 'Chess', not Chess openings' 7 - Search authorities for 'Chess' - note duplicated records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21826 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21826 [Bug 21826] Automatic authority record generation improvements -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 97358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97358&action=edit Bug 24421: Check if subfields are valid using the biblio tag To test: 1 - Enable the sysprefs AutoCreateAuthorities BiblioAddsAuthorities CatalogModuleRelink 2 - Open a record with a subject heading with a subdivision and add a new subfield, or add a new unauthroized heading to a record and save it e.g. 650$aChess$xOpenings$vFiction. 3 - Save the record, note the created authority and that field is linked 4 - Save the record again and note the authority number changes 5 - Find and view the authority linked to the record 6 - The record is for 'Chess', not Chess openings' 7 - Search authorities for 'Chess' - note duplicated records 8 - Apply patch, restart all 9 - Save the record, auth number increases again, we shoudl create the correct record this time 10 - Save again, auth number should not change 11 - Search authorities and confirm the generated authority has the correct subfields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- In certain instances this can cause nearly the entire catalog to be relinked to new authorities and generate many duplicated records - marking as critical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97358|0 |1 is obsolete| | --- Comment #3 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Created attachment 97583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97583&action=edit Bug 24421: Check if subfields are valid using the biblio tag To test: 1 - Enable the sysprefs AutoCreateAuthorities BiblioAddsAuthorities CatalogModuleRelink 2 - Open a record with a subject heading with a subdivision and add a new subfield, or add a new unauthroized heading to a record and save it e.g. 650$aChess$xOpenings$vFiction. 3 - Save the record, note the created authority and that field is linked 4 - Save the record again and note the authority number changes 5 - Find and view the authority linked to the record 6 - The record is for 'Chess', not Chess openings' 7 - Search authorities for 'Chess' - note duplicated records 8 - Apply patch, restart all 9 - Save the record, auth number increases again, we shoudl create the correct record this time 10 - Save again, auth number should not change 11 - Search authorities and confirm the generated authority has the correct subfields Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens@lancasterseminar | |y.edu --- Comment #4 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Patch works as expected. Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, can you cover the change with tests please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97583|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 97881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97881&action=edit Bug 24421: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 97882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97882&action=edit Bug 24421: Check if subfields are valid using the biblio tag To test: 1 - Enable the sysprefs AutoCreateAuthorities BiblioAddsAuthorities CatalogModuleRelink 2 - Open a record with a subject heading with a subdivision and add a new subfield, or add a new unauthroized heading to a record and save it e.g. 650$aChess$xOpenings$vFiction. 3 - Save the record, note the created authority and that field is linked 4 - Save the record again and note the authority number changes 5 - Find and view the authority linked to the record 6 - The record is for 'Chess', not Chess openings' 7 - Search authorities for 'Chess' - note duplicated records 8 - Apply patch, restart all 9 - Save the record, auth number increases again, we shoudl create the correct record this time 10 - Save again, auth number should not change 11 - Search authorities and confirm the generated authority has the correct subfields Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Coming from commit b2b7d376d4854394322310f28d2f5aa1560384e0 Bug 21826: Use subfield map in LinkBibHeadingsToAuthorities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97881|0 |1 is obsolete| | Attachment #97882|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97968&action=edit Bug 24421: Unit tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97969&action=edit Bug 24421: Check if subfields are valid using the biblio tag To test: 1 - Enable the sysprefs AutoCreateAuthorities BiblioAddsAuthorities CatalogModuleRelink 2 - Open a record with a subject heading with a subdivision and add a new subfield, or add a new unauthroized heading to a record and save it e.g. 650$aChess$xOpenings$vFiction. 3 - Save the record, note the created authority and that field is linked 4 - Save the record again and note the authority number changes 5 - Find and view the authority linked to the record 6 - The record is for 'Chess', not Chess openings' 7 - Search authorities for 'Chess' - note duplicated records 8 - Apply patch, restart all 9 - Save the record, auth number increases again, we shoudl create the correct record this time 10 - Save again, auth number should not change 11 - Search authorities and confirm the generated authority has the correct subfields Signed-off-by: Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24269 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269 [Bug 24269] Authority matching in Elasticsearch is broken when authority has subdivisions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.05.00 |20.05.00, 19.11.03 released in| | CC| |joy@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #12 from Joy Nelson <joy@bywatersolutions.com> --- Pushed to 19.11.x branch for 19.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.03 |20.05.00, 19.11.03, released in| |19.05.08 CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #14 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Depends on code not in 18.11.x, not backporting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 AspenCat Team <aspencatteam@clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam@clicweb.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24421 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis@gmail.com --- Comment #15 from Phil Ringnalda <phil@chetcolibrary.org> --- *** Bug 23532 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org