[Bug 25261] New: Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Bug ID: 25261 Summary: Multiple parts handling - confirmation alert Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.field@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Koha already has a field in the item record to identify multi-part material. Materials specified (bound volume or other part) or 952$3. When there is a value in this field (e.g. 2) Koha will prompt you at checkout and checkin with a message dialog which says: Note about the accompanying materials: 2 This is helpful but can be missed by library staff. This enhancement takes this one step further to introduce a confirmation box to acknowledge that the parts have been checked on issue and return. This prevents staff from proceeding before checking the item in their hands. The reason for this is to prevent arguments with library patrons that they did not originally take all the parts or that they did not return all the parts. For example, a CD with an accompanying booklet or a string quartet with 4 parts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 103856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103856&action=edit Bug 25261: Add system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 103857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103857&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- Use of uninitialized value $no_of_parts in numeric gt (>) at /C4/Circulation.pm line 848. You should replace: my $no_of_parts = $item_object->materials; with: my $no_of_parts = $item_object->materials || 0; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- The confirmation need is controlled by a new syspref. Why not a per user permission like? CAN_user_circulate_force_checkout_materials -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- You enhancement works great for check in: playing with CircConfirmParts, the confirmation if the return is required or not. But for checkout, independently of CircConfirmParts, the confirmation is required. I will sign your patch and add a follow-up to fix that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103856|0 |1 is obsolete| | --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 104011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104011&action=edit Bug 25261: Add system preference Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103857|0 |1 is obsolete| | --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 104012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104012&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 104013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104013&action=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Is "Parts" meaningful enough? As a non-native English speaker it seems vague to me, "parts" of what? Maybe adding "Item" in the syspref's name? Please ignore if it does not make sense :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Also, from QA script: OK C4/Circulation.pm FAIL circ/returns.pl FAIL spelling recieved ==> received OK installer/data/mysql/sysprefs.sql FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt FAIL filters missing_filter at line 203 ( Please confirm that the accompanying materials are present: [% additional_materials %]) And I spotted a 8 indentation level in returns.pl 304 $needs_confirm = 1; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104011|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104404&action=edit Bug 25261: Add system preference Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104012|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104405&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104013|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104406&action=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104407&action=edit Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts This clarifies the preference name to make it clear we are talking about the 'parts' that make up an 'item'. 'Part' is a well known term in british english libraries and I think perhaps 'Materials' may be confused with other terms? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104408&action=edit Bug 25261: (follow-up) item.material may contain non-numerics Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field, and thus the item.materials field, may contain arbitrary notes about the material rather than just numeric values. As such we need to check for the field being defined as aposed to greater than '0'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- QA failures corrected and system preference updated to include 'Item' to clarify it's use. I've also added a followup to allow for arbitrary notes in the materials field.. they are not always numeric it appears. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104404|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104409&action=edit Bug 25261: Add system preference Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104405|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104410&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104406|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104411&action=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104407|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104412&action=edit Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts This clarifies the preference name to make it clear we are talking about the 'parts' that make up an 'item'. 'Part' is a well known term in british english libraries and I think perhaps 'Materials' may be confused with other terms? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104408|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104413&action=edit Bug 25261: (follow-up) item.material may contain non-numerics Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field, and thus the item.materials field, may contain arbitrary notes about the material rather than just numeric values. As such we need to check for the field being defined as aposed to greater than '0'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 104414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104414&action=edit Bug 25261: (QA follow-up) Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13547 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104409|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 107217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107217&action=edit Bug 25261: Add system preference Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104410|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 107218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107218&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104411|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 107219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107219&action=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104412|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 107220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107220&action=edit Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts This clarifies the preference name to make it clear we are talking about the 'parts' that make up an 'item'. 'Part' is a well known term in british english libraries and I think perhaps 'Materials' may be confused with other terms? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104413|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 107221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107221&action=edit Bug 25261: (follow-up) item.material may contain non-numerics Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field, and thus the item.materials field, may contain arbitrary notes about the material rather than just numeric values. As such we need to check for the field being defined as aposed to greater than '0'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104414|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 107222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107222&action=edit Bug 25261: (QA follow-up) Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107217|0 |1 is obsolete| | Attachment #107218|0 |1 is obsolete| | Attachment #107219|0 |1 is obsolete| | Attachment #107220|0 |1 is obsolete| | Attachment #107221|0 |1 is obsolete| | Attachment #107222|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107228&action=edit Bug 25261: Add system preference Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107228|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107229&action=edit Bug 25261: Add system preference Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107230&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107231&action=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107232&action=edit Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts This clarifies the preference name to make it clear we are talking about the 'parts' that make up an 'item'. 'Part' is a well known term in british english libraries and I think perhaps 'Materials' may be confused with other terms? Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107233&action=edit Bug 25261: (follow-up) item.material may contain non-numerics Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field, and thus the item.materials field, may contain arbitrary notes about the material rather than just numeric values. As such we need to check for the field being defined as aposed to greater than '0'. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 107234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107234&action=edit Bug 25261: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Found 2 problems: 1. When checking in, "Please confirm checkin" click "No" will check the item in 2. If you checkin from the checkouts page there is no alert -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107285&action=edit Bug 25261: (QA follow-up) Simplify tests and conditions Use build_sample_item in tests Simplify tests for the confirmation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 107331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107331&action=edit Bug 25261: (QA follow-up) Non-confirm on return This patch updates the confirmation from an alert to a dismissable modal which allows for optionally not checking the item in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #36)
Found 2 problems: 1. When checking in, "Please confirm checkin" click "No" will check the item in
Fixed in followup, good catch, not sure how my brain missed that :(
2. If you checkin from the checkouts page there is no alert
Can you clarify how to achieve this.. I can't replicate it at present. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #39)
(In reply to Jonathan Druart from comment #36)
2. If you checkin from the checkouts page there is no alert
Can you clarify how to achieve this.. I can't replicate it at present.
from the checkouts view: circ/circulation.pl?borrowernumber=42 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #40)
(In reply to Martin Renvoize from comment #39)
(In reply to Jonathan Druart from comment #36)
2. If you checkin from the checkouts page there is no alert
Can you clarify how to achieve this.. I can't replicate it at present.
from the checkouts view: circ/circulation.pl?borrowernumber=42
Nope, still not sure what you mean. I checkout an item to person X.. and then try to checkout the same item to Person Y... the alert is triggered.. is that not what you mean? How else can you perform a check-in on the checkout page? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- https://snipboard.io/RsyS8W.jpg last column -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Found it.. the action was hidden by the checkout table column settings.. grr. Looking at how the code in the works, this is going to be rather challenging to add 😑 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 107822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107822&action=edit Bug 25261: (QA follow-up) Add confirmation to issues table The issues table allows for checkins and was not appropriately requireing confirmation for the multi-part confirmation added in this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107822|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 107823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107823&action=edit Bug 25261: (QA follow-up) Add confirmation to issues table The issues table allows for checkins and was not appropriately requireing confirmation for the multi-part confirmation added in this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Let me know if you're happy or not with that followup Jonathan.. was an interesting area to dig into :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What about self checkout? Has it been tested? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #47)
What about self checkout? Has it been tested?
Reading the code I think it's missing from opac/sco/sco-main.pl line 154. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder about making it visible in sco/sci, as we had a lengthy discussion about libraries using this field for information that should not be seen by users: bug 13547 I would suggest to deal with self-checkout/checkin separately, maybe with a pref. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- There is the option to just block in SCO by the looks.. 'Please see a member of the library staff.' I wonder if that's the approach to take.? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #50)
There is the option to just block in SCO by the looks..
'Please see a member of the library staff.'
I wonder if that's the approach to take.?
I think that's a common approach for multi-part items. Only problem might be that it causes a change in behaviour we should probably document clearly in the pref description (items with materials no will no longer be able to be returned on self check). Hate to ask, but if we go there... what about SIP? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107229|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108196&action=edit Bug 25261: Add system preference Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107230|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108197&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107231|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108198&action=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107232|0 |1 is obsolete| | --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108199&action=edit Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts This clarifies the preference name to make it clear we are talking about the 'parts' that make up an 'item'. 'Part' is a well known term in british english libraries and I think perhaps 'Materials' may be confused with other terms? Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107233|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108200&action=edit Bug 25261: (follow-up) item.material may contain non-numerics Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field, and thus the item.materials field, may contain arbitrary notes about the material rather than just numeric values. As such we need to check for the field being defined as aposed to greater than '0'. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107234|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108201&action=edit Bug 25261: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107285|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108202&action=edit Bug 25261: (QA follow-up) Simplify tests and conditions Use build_sample_item in tests Simplify tests for the confirmation Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107331|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108203&action=edit Bug 25261: (QA follow-up) Non-confirm on return This patch updates the confirmation from an alert to a dismissable modal which allows for optionally not checking the item in Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107823|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108204&action=edit Bug 25261: (QA follow-up) Add confirmation to issues table The issues table allows for checkins and was not appropriately requireing confirmation for the multi-part confirmation added in this bug. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108205&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkout Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108206&action=edit Bug 25261: (QA follow-up) Add handling to SCO Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108207&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkin Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108208&action=edit Bug 25261: (QA follow-up) Add handling to SCI Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bumping back to the NQA queue as we had a number of QA followups and I feel like a final QA run would be a good idea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- What is the expected behavior on SIP, SCO and SCI? I think updating the commit messages for the last 3 patches could be really helpful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108196|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108230&action=edit Bug 25261: Add system preference Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108197|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108231&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108198|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108232&action=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108199|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108233&action=edit Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts This clarifies the preference name to make it clear we are talking about the 'parts' that make up an 'item'. 'Part' is a well known term in british english libraries and I think perhaps 'Materials' may be confused with other terms? Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108200|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108234&action=edit Bug 25261: (follow-up) item.material may contain non-numerics Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field, and thus the item.materials field, may contain arbitrary notes about the material rather than just numeric values. As such we need to check for the field being defined as aposed to greater than '0'. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108201|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108235&action=edit Bug 25261: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108202|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108236&action=edit Bug 25261: (QA follow-up) Simplify tests and conditions Use build_sample_item in tests Simplify tests for the confirmation Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108203|0 |1 is obsolete| | --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108237&action=edit Bug 25261: (QA follow-up) Non-confirm on return This patch updates the confirmation from an alert to a dismissable modal which allows for optionally not checking the item in Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108204|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108238&action=edit Bug 25261: (QA follow-up) Add confirmation to issues table The issues table allows for checkins and was not appropriately requireing confirmation for the multi-part confirmation added in this bug. Test plan 1/ Enable the feature as per previous patches 2/ Checkot an item with attached materials 3/ Navigate to a page that display your users issues table (the checkout page is a reasonable example) 4/ You should have the option to select items for return in the table (If not, use the column settings to enable the feature) 5/ Select at least the item with attached materials to return 6/ Upon clicking the return buttton you should find that items without additional materials are returned as expected, but rows with additional materials turn yellow and contain a message and additional checkbox for confirmation in the table. 7/ Ensure the checkbox is selected and click the return button again 8/ This item should have been returned. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108205|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108239&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkout Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via a SIP unit 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108206|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108240&action=edit Bug 25261: (QA follow-up) Add handling to SCO Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via the SCO 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108207|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108241&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkin Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via a SIP unit 3/ Note that the return is blocked with an alert type of '99' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108208|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108242&action=edit Bug 25261: (QA follow-up) Add handling to SCI Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via the SCI 3/ Note that the return is blocked with the message '(The item cannot be returned at a self service terminal, please see library staff for assistance)' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #80 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #66)
What is the expected behavior on SIP, SCO and SCI? I think updating the commit messages for the last 3 patches could be really helpful.
As requested, I've added a test plan per follow-up patch to clarify behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #81 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could someone help me out here by at least testing the SIP bit? I can take care of the other parts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #82 from Nick Clemens <nick@bywatersolutions.com> --- SIP checkin fails - the message for needsconfirmation of 'additional_materials' is lowercased, but the test is UPPER CASED. Additionally the sub _can_we_issue deletes any lowercased keys - there is half an explanation in a comment One more thing: If i check in an item that needs confirmation the checkin list is cleared after confirmation To recreate: 0 - Enable ShowAllCheckins 1 - Check in several regular items 2 - Check in an item with parts 3 - Confirm the checkin in 4 - The list of checkins contains only last item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108230|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109478&action=edit Bug 25261: Add system preference Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108231|0 |1 is obsolete| | --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109479&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108232|0 |1 is obsolete| | --- Comment #85 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109480&action=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108233|0 |1 is obsolete| | --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109481&action=edit Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts This clarifies the preference name to make it clear we are talking about the 'parts' that make up an 'item'. 'Part' is a well known term in british english libraries and I think perhaps 'Materials' may be confused with other terms? Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108234|0 |1 is obsolete| | --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109482&action=edit Bug 25261: (follow-up) item.material may contain non-numerics Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field, and thus the item.materials field, may contain arbitrary notes about the material rather than just numeric values. As such we need to check for the field being defined as aposed to greater than '0'. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108235|0 |1 is obsolete| | --- Comment #88 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109483&action=edit Bug 25261: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108236|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109484&action=edit Bug 25261: (QA follow-up) Simplify tests and conditions Use build_sample_item in tests Simplify tests for the confirmation Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108237|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109485&action=edit Bug 25261: (QA follow-up) Non-confirm on return This patch updates the confirmation from an alert to a dismissable modal which allows for optionally not checking the item in Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108238|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109486&action=edit Bug 25261: (QA follow-up) Add confirmation to issues table The issues table allows for checkins and was not appropriately requireing confirmation for the multi-part confirmation added in this bug. Test plan 1/ Enable the feature as per previous patches 2/ Checkot an item with attached materials 3/ Navigate to a page that display your users issues table (the checkout page is a reasonable example) 4/ You should have the option to select items for return in the table (If not, use the column settings to enable the feature) 5/ Select at least the item with attached materials to return 6/ Upon clicking the return buttton you should find that items without additional materials are returned as expected, but rows with additional materials turn yellow and contain a message and additional checkbox for confirmation in the table. 7/ Ensure the checkbox is selected and click the return button again 8/ This item should have been returned. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108239|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109487&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkout Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via a SIP unit 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108240|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109488&action=edit Bug 25261: (QA follow-up) Add handling to SCO Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via the SCO 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108241|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109489&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkin Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via a SIP unit 3/ Note that the return is blocked with an alert type of '99' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108242|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109490&action=edit Bug 25261: (QA follow-up) Add handling to SCI Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via the SCI 3/ Note that the return is blocked with the message '(The item cannot be returned at a self service terminal, please see library staff for assistance)' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109478|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109491&action=edit Bug 25261: Add system preference Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109479|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109492&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109480|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109493&action=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109481|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109494&action=edit Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts This clarifies the preference name to make it clear we are talking about the 'parts' that make up an 'item'. 'Part' is a well known term in british english libraries and I think perhaps 'Materials' may be confused with other terms? Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109482|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109495&action=edit Bug 25261: (follow-up) item.material may contain non-numerics Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field, and thus the item.materials field, may contain arbitrary notes about the material rather than just numeric values. As such we need to check for the field being defined as aposed to greater than '0'. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109483|0 |1 is obsolete| | --- Comment #101 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109496&action=edit Bug 25261: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109484|0 |1 is obsolete| | --- Comment #102 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109497&action=edit Bug 25261: (QA follow-up) Simplify tests and conditions Use build_sample_item in tests Simplify tests for the confirmation Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109485|0 |1 is obsolete| | --- Comment #103 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109498&action=edit Bug 25261: (QA follow-up) Non-confirm on return This patch updates the confirmation from an alert to a dismissable modal which allows for optionally not checking the item in Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109486|0 |1 is obsolete| | --- Comment #104 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109499&action=edit Bug 25261: (QA follow-up) Add confirmation to issues table The issues table allows for checkins and was not appropriately requireing confirmation for the multi-part confirmation added in this bug. Test plan 1/ Enable the feature as per previous patches 2/ Checkot an item with attached materials 3/ Navigate to a page that display your users issues table (the checkout page is a reasonable example) 4/ You should have the option to select items for return in the table (If not, use the column settings to enable the feature) 5/ Select at least the item with attached materials to return 6/ Upon clicking the return buttton you should find that items without additional materials are returned as expected, but rows with additional materials turn yellow and contain a message and additional checkbox for confirmation in the table. 7/ Ensure the checkbox is selected and click the return button again 8/ This item should have been returned. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109487|0 |1 is obsolete| | --- Comment #105 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109500&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkout Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via a SIP unit 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109488|0 |1 is obsolete| | --- Comment #106 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109501&action=edit Bug 25261: (QA follow-up) Add handling to SCO Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via the SCO 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109489|0 |1 is obsolete| | --- Comment #107 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109502&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkin Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via a SIP unit 3/ Note that the return is blocked with an alert type of '99' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109490|0 |1 is obsolete| | --- Comment #108 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109503&action=edit Bug 25261: (QA follow-up) Add handling to SCI Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via the SCI 3/ Note that the return is blocked with the message '(The item cannot be returned at a self service terminal, please see library staff for assistance)' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #109 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109504&action=edit Bug 25261: (QA follow-up) Capitalize return of needsconfirm This patch capitalizes the 'ADDITIONAL_MATERIALS' key in the needsconfirm hash return value for CanBookBeIssued to restore consistency with previous code and ensure SIP Checkout works as expected. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #110 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Final patch should restore consistency in the return value for CanBookBeIssued such that SIP Checkout will perform as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #111 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109508&action=edit Bug 25261: (QA follow-up) Restore previously returned list Test plan 0 - Enable ShowAllCheckins 1 - Check in several regular items 2 - Check in an item with parts 3 - Confirm the checkin in 4 - The list of checkins contains all the previous checkins and the multi-part checkin too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #112 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All issues highlighted in QA should now be resolved :), Thanks for testing Nick :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #113 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #81)
Could someone help me out here by at least testing the SIP bit? I can take care of the other parts.
SIP bits are all good with latest patches - do you plan to test the rest? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #114 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 25261: Add system preference Using index info to reconstruct a base tree... M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/sysprefs.sql Applying: Bug 25261: Require confirmation of multiple parts items Applying: Bug 25261: Checkout confirmation depending on syspref Applying: Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts error: sha1 information is lacking or useless (circ/returns.pl). error: could not build fake ancestor Patch failed at 0001 Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-25261-follow-up-Rename-CircConfirmParts-to-Cir-9FLtrb.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109491|0 |1 is obsolete| | --- Comment #115 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110038&action=edit Bug 25261: Add system preference Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109492|0 |1 is obsolete| | --- Comment #116 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110039&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109493|0 |1 is obsolete| | --- Comment #117 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110040&action=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109494|0 |1 is obsolete| | --- Comment #118 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110041&action=edit Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts This clarifies the preference name to make it clear we are talking about the 'parts' that make up an 'item'. 'Part' is a well known term in british english libraries and I think perhaps 'Materials' may be confused with other terms? Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109495|0 |1 is obsolete| | --- Comment #119 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110042&action=edit Bug 25261: (follow-up) item.material may contain non-numerics Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field, and thus the item.materials field, may contain arbitrary notes about the material rather than just numeric values. As such we need to check for the field being defined as aposed to greater than '0'. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109496|0 |1 is obsolete| | --- Comment #120 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110043&action=edit Bug 25261: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109497|0 |1 is obsolete| | --- Comment #121 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110044&action=edit Bug 25261: (QA follow-up) Simplify tests and conditions Use build_sample_item in tests Simplify tests for the confirmation Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109498|0 |1 is obsolete| | --- Comment #122 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110045&action=edit Bug 25261: (QA follow-up) Non-confirm on return This patch updates the confirmation from an alert to a dismissable modal which allows for optionally not checking the item in Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109499|0 |1 is obsolete| | --- Comment #123 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110046&action=edit Bug 25261: (QA follow-up) Add confirmation to issues table The issues table allows for checkins and was not appropriately requireing confirmation for the multi-part confirmation added in this bug. Test plan 1/ Enable the feature as per previous patches 2/ Checkot an item with attached materials 3/ Navigate to a page that display your users issues table (the checkout page is a reasonable example) 4/ You should have the option to select items for return in the table (If not, use the column settings to enable the feature) 5/ Select at least the item with attached materials to return 6/ Upon clicking the return buttton you should find that items without additional materials are returned as expected, but rows with additional materials turn yellow and contain a message and additional checkbox for confirmation in the table. 7/ Ensure the checkbox is selected and click the return button again 8/ This item should have been returned. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109500|0 |1 is obsolete| | --- Comment #124 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110047&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkout Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via a SIP unit 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109501|0 |1 is obsolete| | --- Comment #125 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110048&action=edit Bug 25261: (QA follow-up) Add handling to SCO Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via the SCO 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109502|0 |1 is obsolete| | --- Comment #126 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110049&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkin Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via a SIP unit 3/ Note that the return is blocked with an alert type of '99' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109503|0 |1 is obsolete| | --- Comment #127 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110050&action=edit Bug 25261: (QA follow-up) Add handling to SCI Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via the SCI 3/ Note that the return is blocked with the message '(The item cannot be returned at a self service terminal, please see library staff for assistance)' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109504|0 |1 is obsolete| | --- Comment #128 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110051&action=edit Bug 25261: (QA follow-up) Capitalize return of needsconfirm This patch capitalizes the 'ADDITIONAL_MATERIALS' key in the needsconfirm hash return value for CanBookBeIssued to restore consistency with previous code and ensure SIP Checkout works as expected. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109508|0 |1 is obsolete| | --- Comment #129 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110052&action=edit Bug 25261: (QA follow-up) Restore previously returned list Test plan 0 - Enable ShowAllCheckins 1 - Check in several regular items 2 - Check in an item with parts 3 - Confirm the checkin in 4 - The list of checkins contains all the previous checkins and the multi-part checkin too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #130 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110133&action=edit Bug 25261: (QA follow-up) Terminology: checkin/checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #131 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- When checking out an item with $3 set and the syspref active, I see both the old blue 'information dialog' and the new yellow 'confirmation dialog'. The information shown is doubled up this way - I believe if we ask for confirmation the blue one should not appear? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #132 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110184&action=edit Bug 25261: (QA follow-up) Prevent double dialogue This patch removes the blue information message box if we are using multi-part confirmations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #133 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Corrected in followup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #134 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Check in via check in page With confirmation off: When returning an item with $3 the dialog is blue. With the patch, the dialog is yellow and has a list item. I believe that the previous formatting should be kept in this case, so that checkout and checkin match up. With confirmation on: There is a similar problem as before with the modal AND the normal message showing in the background. I think we should only show the modal in this case. Visually I would maybe make the $3 content in the message stand out a bit more, making it <strong> maybe? 2) Self check out (sco-main) On self check out with returns allowed (SCOAllowCheckin): When you click on "renew item", it asks if you want to renew or return it. You can then successfully return the item from this dialog. Note: There are some issues with the CSS there - the Renew item link is not obvious as a button - and I am not sure why the normal return option doesn't display :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #135 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
2) Self check out (sco-main)
I also had trouble with the 'renew' option from here - could you try that please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #136 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- sci-main is ok. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #137 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110258&action=edit Bug 25261: (QA follow-up) Make issue and returns messages consistent This patch makes the confirmation dialogue handing and visuality consistent between issues and returns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #138 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110259&action=edit Bug 25261: (QA follow-up) Catch attepts to return via SCO This patch adds a block to capture attempts to return items with attached materials when checking in via the self checkout when the relevant system preference is set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #139 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #135)
2) Self check out (sco-main)
I also had trouble with the 'renew' option from here - could you try that please?
This is a bit weird; but I don't think it's anything to do with this bug. The renewal goes through as expected if you look at the data, but I would expect the page to redirect back to the logged in SCO session rather than just leave you on the confirmation page. The behaviour pre-exists this bug though, so I'd prefer to fix it in it's own bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #140 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #134)
Note: There are some issues with the CSS there - the Renew item link is not obvious as a button - and I am not sure why the normal return option doesn't display :(
Not related to this bug; certainly one to raise on it's own bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #141 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #140)
(In reply to Katrin Fischer from comment #134)
Note: There are some issues with the CSS there - the Renew item link is not obvious as a button - and I am not sure why the normal return option doesn't display :(
Not related to this bug; certainly one to raise on it's own bug.
Forgot to update here, already filed 2 new bugs for this: Bug 26479 Bug 26478 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #142 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
I also had trouble with the 'renew' option from here - could you try that please?
This is a bit weird; but I don't think it's anything to do with this bug. The renewal goes through as expected if you look at the data, but I would expect the page to redirect back to the logged in SCO session rather than just leave you on the confirmation page. The behaviour pre-exists this bug though, so I'd prefer to fix it in it's own bug.
It worked for me without the patches - the page did then reload for me. Same item as with the confirmation. I can retest, but it might be related. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #143 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110268&action=edit Bug 25261: (QA follow-up) Prevent server error on bad barcode Prior to this patch if you had CircConfirmParts enabled and you attempted to checkin a deleted item then you would be met with a server error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #144 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I retested this: - Turn on multi part checking and edit 3999900000018 to have $3 - Check out 3999900000018 in staff - Go to sco/sco-main.pl - The checkout shows in the table of checkouts - The last column is "Renew item" - Click on it, click "Renew" - page refreshes, all is good - Apply patches, repeat - Renew doesn't direct back to the overview page anymore -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #145 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Right.. you were getting caught by bug 26301.. which got pushed to master last night! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110038|0 |1 is obsolete| | --- Comment #146 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110322&action=edit Bug 25261: Add system preference Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110039|0 |1 is obsolete| | --- Comment #147 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110323&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110040|0 |1 is obsolete| | --- Comment #148 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110324&action=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110041|0 |1 is obsolete| | --- Comment #149 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110325&action=edit Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts This clarifies the preference name to make it clear we are talking about the 'parts' that make up an 'item'. 'Part' is a well known term in british english libraries and I think perhaps 'Materials' may be confused with other terms? Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110042|0 |1 is obsolete| | --- Comment #150 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110326&action=edit Bug 25261: (follow-up) item.material may contain non-numerics Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field, and thus the item.materials field, may contain arbitrary notes about the material rather than just numeric values. As such we need to check for the field being defined as aposed to greater than '0'. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110043|0 |1 is obsolete| | --- Comment #151 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110327&action=edit Bug 25261: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110044|0 |1 is obsolete| | --- Comment #152 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110328&action=edit Bug 25261: (QA follow-up) Simplify tests and conditions Use build_sample_item in tests Simplify tests for the confirmation Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110045|0 |1 is obsolete| | --- Comment #153 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110329&action=edit Bug 25261: (QA follow-up) Non-confirm on return This patch updates the confirmation from an alert to a dismissable modal which allows for optionally not checking the item in Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110046|0 |1 is obsolete| | --- Comment #154 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110330&action=edit Bug 25261: (QA follow-up) Add confirmation to issues table The issues table allows for checkins and was not appropriately requireing confirmation for the multi-part confirmation added in this bug. Test plan 1/ Enable the feature as per previous patches 2/ Checkot an item with attached materials 3/ Navigate to a page that display your users issues table (the checkout page is a reasonable example) 4/ You should have the option to select items for return in the table (If not, use the column settings to enable the feature) 5/ Select at least the item with attached materials to return 6/ Upon clicking the return buttton you should find that items without additional materials are returned as expected, but rows with additional materials turn yellow and contain a message and additional checkbox for confirmation in the table. 7/ Ensure the checkbox is selected and click the return button again 8/ This item should have been returned. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110047|0 |1 is obsolete| | --- Comment #155 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110331&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkout Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via a SIP unit 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110048|0 |1 is obsolete| | --- Comment #156 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110332&action=edit Bug 25261: (QA follow-up) Add handling to SCO Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via the SCO 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110049|0 |1 is obsolete| | --- Comment #157 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110333&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkin Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via a SIP unit 3/ Note that the return is blocked with an alert type of '99' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110050|0 |1 is obsolete| | --- Comment #158 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110334&action=edit Bug 25261: (QA follow-up) Add handling to SCI Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via the SCI 3/ Note that the return is blocked with the message '(The item cannot be returned at a self service terminal, please see library staff for assistance)' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110051|0 |1 is obsolete| | --- Comment #159 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110335&action=edit Bug 25261: (QA follow-up) Capitalize return of needsconfirm This patch capitalizes the 'ADDITIONAL_MATERIALS' key in the needsconfirm hash return value for CanBookBeIssued to restore consistency with previous code and ensure SIP Checkout works as expected. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110052|0 |1 is obsolete| | --- Comment #160 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110336&action=edit Bug 25261: (QA follow-up) Restore previously returned list Test plan 0 - Enable ShowAllCheckins 1 - Check in several regular items 2 - Check in an item with parts 3 - Confirm the checkin in 4 - The list of checkins contains all the previous checkins and the multi-part checkin too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110133|0 |1 is obsolete| | --- Comment #161 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110337&action=edit Bug 25261: (QA follow-up) Terminology: checkin/checkout -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110184|0 |1 is obsolete| | --- Comment #162 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110338&action=edit Bug 25261: (QA follow-up) Prevent double dialogue This patch removes the blue information message box if we are using multi-part confirmations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110258|0 |1 is obsolete| | --- Comment #163 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110339&action=edit Bug 25261: (QA follow-up) Make issue and returns messages consistent This patch makes the confirmation dialogue handing and visuality consistent between issues and returns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110259|0 |1 is obsolete| | --- Comment #164 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110340&action=edit Bug 25261: (QA follow-up) Catch attepts to return via SCO This patch adds a block to capture attempts to return items with attached materials when checking in via the self checkout when the relevant system preference is set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110268|0 |1 is obsolete| | --- Comment #165 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110341&action=edit Bug 25261: (QA follow-up) Prevent server error on bad barcode Prior to this patch if you had CircConfirmParts enabled and you attempted to checkin a deleted item then you would be met with a server error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #166 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #144)
I retested this:
- Turn on multi part checking and edit 3999900000018 to have $3 - Check out 3999900000018 in staff - Go to sco/sco-main.pl - The checkout shows in the table of checkouts - The last column is "Renew item" - Click on it, click "Renew" - page refreshes, all is good - Apply patches, repeat - Renew doesn't direct back to the overview page anymore
Rebased on master should have fixed this.. you were seeing a manifestation of bug 26301 which was pushed to master over night. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110322|0 |1 is obsolete| | --- Comment #167 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110356&action=edit Bug 25261: Add system preference Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110323|0 |1 is obsolete| | --- Comment #168 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110357&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110324|0 |1 is obsolete| | --- Comment #169 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110358&action=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110325|0 |1 is obsolete| | --- Comment #170 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110359&action=edit Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts This clarifies the preference name to make it clear we are talking about the 'parts' that make up an 'item'. 'Part' is a well known term in british english libraries and I think perhaps 'Materials' may be confused with other terms? Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110326|0 |1 is obsolete| | --- Comment #171 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110360&action=edit Bug 25261: (follow-up) item.material may contain non-numerics Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field, and thus the item.materials field, may contain arbitrary notes about the material rather than just numeric values. As such we need to check for the field being defined as aposed to greater than '0'. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110327|0 |1 is obsolete| | --- Comment #172 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110361&action=edit Bug 25261: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110328|0 |1 is obsolete| | --- Comment #173 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110362&action=edit Bug 25261: (QA follow-up) Simplify tests and conditions Use build_sample_item in tests Simplify tests for the confirmation Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110329|0 |1 is obsolete| | --- Comment #174 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110363&action=edit Bug 25261: (QA follow-up) Non-confirm on return This patch updates the confirmation from an alert to a dismissable modal which allows for optionally not checking the item in Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110330|0 |1 is obsolete| | --- Comment #175 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110364&action=edit Bug 25261: (QA follow-up) Add confirmation to issues table The issues table allows for checkins and was not appropriately requireing confirmation for the multi-part confirmation added in this bug. Test plan 1/ Enable the feature as per previous patches 2/ Checkot an item with attached materials 3/ Navigate to a page that display your users issues table (the checkout page is a reasonable example) 4/ You should have the option to select items for return in the table (If not, use the column settings to enable the feature) 5/ Select at least the item with attached materials to return 6/ Upon clicking the return buttton you should find that items without additional materials are returned as expected, but rows with additional materials turn yellow and contain a message and additional checkbox for confirmation in the table. 7/ Ensure the checkbox is selected and click the return button again 8/ This item should have been returned. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110331|0 |1 is obsolete| | --- Comment #176 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110365&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkout Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via a SIP unit 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110332|0 |1 is obsolete| | --- Comment #177 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110366&action=edit Bug 25261: (QA follow-up) Add handling to SCO Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via the SCO 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110333|0 |1 is obsolete| | --- Comment #178 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110367&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkin Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via a SIP unit 3/ Note that the return is blocked with an alert type of '99' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110334|0 |1 is obsolete| | --- Comment #179 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110368&action=edit Bug 25261: (QA follow-up) Add handling to SCI Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via the SCI 3/ Note that the return is blocked with the message '(The item cannot be returned at a self service terminal, please see library staff for assistance)' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110335|0 |1 is obsolete| | --- Comment #180 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110369&action=edit Bug 25261: (QA follow-up) Capitalize return of needsconfirm This patch capitalizes the 'ADDITIONAL_MATERIALS' key in the needsconfirm hash return value for CanBookBeIssued to restore consistency with previous code and ensure SIP Checkout works as expected. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110336|0 |1 is obsolete| | --- Comment #181 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110370&action=edit Bug 25261: (QA follow-up) Restore previously returned list Test plan 0 - Enable ShowAllCheckins 1 - Check in several regular items 2 - Check in an item with parts 3 - Confirm the checkin in 4 - The list of checkins contains all the previous checkins and the multi-part checkin too. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110337|0 |1 is obsolete| | --- Comment #182 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110371&action=edit Bug 25261: (QA follow-up) Terminology: checkin/checkout Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110338|0 |1 is obsolete| | --- Comment #183 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110372&action=edit Bug 25261: (QA follow-up) Prevent double dialogue This patch removes the blue information message box if we are using multi-part confirmations. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110339|0 |1 is obsolete| | --- Comment #184 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110373&action=edit Bug 25261: (QA follow-up) Make issue and returns messages consistent This patch makes the confirmation dialogue handing and visuality consistent between issues and returns. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110340|0 |1 is obsolete| | --- Comment #185 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110374&action=edit Bug 25261: (QA follow-up) Catch attepts to return via SCO This patch adds a block to capture attempts to return items with attached materials when checking in via the self checkout when the relevant system preference is set. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110341|0 |1 is obsolete| | --- Comment #186 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110375&action=edit Bug 25261: (QA follow-up) Prevent server error on bad barcode Prior to this patch if you had CircConfirmParts enabled and you attempted to checkin a deleted item then you would be met with a server error. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110356|0 |1 is obsolete| | --- Comment #187 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110915&action=edit Bug 25261: Add system preference Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110357|0 |1 is obsolete| | --- Comment #188 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110916&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110358|0 |1 is obsolete| | --- Comment #189 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110917&action=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110359|0 |1 is obsolete| | --- Comment #190 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110918&action=edit Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts This clarifies the preference name to make it clear we are talking about the 'parts' that make up an 'item'. 'Part' is a well known term in british english libraries and I think perhaps 'Materials' may be confused with other terms? Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110360|0 |1 is obsolete| | --- Comment #191 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110919&action=edit Bug 25261: (follow-up) item.material may contain non-numerics Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field, and thus the item.materials field, may contain arbitrary notes about the material rather than just numeric values. As such we need to check for the field being defined as aposed to greater than '0'. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110361|0 |1 is obsolete| | --- Comment #192 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110920&action=edit Bug 25261: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110362|0 |1 is obsolete| | --- Comment #193 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110921&action=edit Bug 25261: (QA follow-up) Simplify tests and conditions Use build_sample_item in tests Simplify tests for the confirmation Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110363|0 |1 is obsolete| | --- Comment #194 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110922&action=edit Bug 25261: (QA follow-up) Non-confirm on return This patch updates the confirmation from an alert to a dismissable modal which allows for optionally not checking the item in Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110364|0 |1 is obsolete| | --- Comment #195 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110923&action=edit Bug 25261: (QA follow-up) Add confirmation to issues table The issues table allows for checkins and was not appropriately requireing confirmation for the multi-part confirmation added in this bug. Test plan 1/ Enable the feature as per previous patches 2/ Checkot an item with attached materials 3/ Navigate to a page that display your users issues table (the checkout page is a reasonable example) 4/ You should have the option to select items for return in the table (If not, use the column settings to enable the feature) 5/ Select at least the item with attached materials to return 6/ Upon clicking the return buttton you should find that items without additional materials are returned as expected, but rows with additional materials turn yellow and contain a message and additional checkbox for confirmation in the table. 7/ Ensure the checkbox is selected and click the return button again 8/ This item should have been returned. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110365|0 |1 is obsolete| | --- Comment #196 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110924&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkout Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via a SIP unit 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110366|0 |1 is obsolete| | --- Comment #197 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110925&action=edit Bug 25261: (QA follow-up) Add handling to SCO Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via the SCO 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110367|0 |1 is obsolete| | --- Comment #198 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110926&action=edit Bug 25261: (QA follow-up) Catch check in SIP Checkin Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via a SIP unit 3/ Note that the return is blocked with an alert type of '99' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110368|0 |1 is obsolete| | --- Comment #199 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110927&action=edit Bug 25261: (QA follow-up) Add handling to SCI Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via the SCI 3/ Note that the return is blocked with the message '(The item cannot be returned at a self service terminal, please see library staff for assistance)' 4/ Signoff Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110369|0 |1 is obsolete| | --- Comment #200 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110928&action=edit Bug 25261: (QA follow-up) Capitalize return of needsconfirm This patch capitalizes the 'ADDITIONAL_MATERIALS' key in the needsconfirm hash return value for CanBookBeIssued to restore consistency with previous code and ensure SIP Checkout works as expected. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110370|0 |1 is obsolete| | --- Comment #201 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110929&action=edit Bug 25261: (QA follow-up) Restore previously returned list Test plan 0 - Enable ShowAllCheckins 1 - Check in several regular items 2 - Check in an item with parts 3 - Confirm the checkin in 4 - The list of checkins contains all the previous checkins and the multi-part checkin too. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110371|0 |1 is obsolete| | --- Comment #202 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110930&action=edit Bug 25261: (QA follow-up) Terminology: checkin/checkout Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110372|0 |1 is obsolete| | --- Comment #203 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110931&action=edit Bug 25261: (QA follow-up) Prevent double dialogue This patch removes the blue information message box if we are using multi-part confirmations. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110373|0 |1 is obsolete| | --- Comment #204 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110932&action=edit Bug 25261: (QA follow-up) Make issue and returns messages consistent This patch makes the confirmation dialogue handing and visuality consistent between issues and returns. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110374|0 |1 is obsolete| | --- Comment #205 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110933&action=edit Bug 25261: (QA follow-up) Catch attepts to return via SCO This patch adds a block to capture attempts to return items with attached materials when checking in via the self checkout when the relevant system preference is set. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110375|0 |1 is obsolete| | --- Comment #206 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110934&action=edit Bug 25261: (QA follow-up) Prevent server error on bad barcode Prior to this patch if you had CircConfirmParts enabled and you attempted to checkin a deleted item then you would be met with a server error. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #207 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Minor rebase for conflict caused by bug 25321. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #208 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 111027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111027&action=edit Bug 25261: Prevent tests to fail if CircConfirmItemParts is on Setting items.materials to NULL at TestBuilder level will (certainly) prevent some tests to fail if the pref is on In t/db_dependent/selenium/basic_workflow.t we set 952$3 to an empty string. The tests will pass even if the pref is turned on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #209 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds the release notes| |option to require staff | |members to confirm that an | |item contains all it's | |listed parts at | |check-in/check-out time. | | | |New system preference: | |`CircConfirmItemParts` Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #210 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds the |This enhancement adds the release notes|option to require staff |option to require staff |members to confirm that an |members to confirm that an |item contains all it's |item contains all its |listed parts at |listed parts at |check-in/check-out time. |check-in/check-out time. | | |New system preference: |New system preference: |`CircConfirmItemParts` |`CircConfirmItemParts` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27976 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27976 [Bug 27976] Add Granular options to CircConfirmItemParts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29504 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 [Bug 29504] Confirm Item Parts requires Force Checkout permission -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual-updated CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 [Bug 30519] Regression: using sys pref CircConfirmItemParts prevents checkin from moremember.pl and circulation.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #211 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Bug 25261: (QA follow-up) Add confirmation to issues table I don't understand this patch. 1. The JS code is added in the "renew" function but we are talking about checkin 2. Why don't we simply don't remove the checkbox to prevent checkin (like we do for item on hold)? 3. The "Confirm" will no longer be displayed because of the table refresh, see bug 28653 and bug 36131. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org