[Bug 32908] New: Item type icons broken in the bibliographic record details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Bug ID: 32908 Summary: Item type icons broken in the bibliographic record details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: gveranis@dataly.gr QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 146386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146386&action=edit Staff_Interface-Bibliographic_record_details-Item_type_icon_BROKEN In the Staff interface, the details page of a bibliographic record should display the icon associated with the item type of an item ('Item type' column in the 'Holdings' tab). This feature broke in v22.11.00 and is still broken [*] in the current master (539efac9aa), as the <img> tag for the item type icon points to a path that begins with: /opac-tmpl/bootstrap/itemtypeimg instead of the correct path that begins with: /intranet-tmpl/prog/img/itemtypeimg So, instead of fetching the corresponding item type icon you get a 404 in your web server logs and the default 'broken image URL' image in your web browser. I will attach a couple of screenshots to demonstrate the problem. `git bisect` tells me that the relevant commit is b686bd65e19a6688ebda109a156ea31576559e4f from Bug 31321. [*] Please note: the bug outlined above occurs on Debian package installations. Koha instances created using koha-testing-docker or the Koha Sandboxes seem to be unaffected. I believe this has to do with the values of the <intrahtdocs> and <opachtdocs> settings in koha-conf.xml, and the fact that Gitified instances served by Apache use the same DocumentRoot path in their VirtualHost directives for both the OPAC and the Staff interface. However, when trying to reproduce this bug on Koha instances created with methods other than a Debian package install, you can still observe that the item type icon URL is wrong by right-clicking on the icon and selecting 'Inspect' to see its properties. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 --- Comment #1 from George Veranis <gveranis@dataly.gr> --- Created attachment 146387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146387&action=edit Staff_Interface-Bibliographic_record_details-Item_type_icon_OK -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 --- Comment #2 from George Veranis <gveranis@dataly.gr> --- Steps to reproduce: 1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show' 2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon 3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon Then, visit the bibliographic record's details page in the Staff interface. In the 'Item type' column of the 'Holdings' tab, notice that instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser. [If you try the above in a Dockerised Koha instance the icon will -most likely- be displayed just fine. However, you can still verify that it's being loaded from the wrong path by right-clicking on the icon and selecting 'Inspect'.] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |gveranis@dataly.gr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 --- Comment #3 from George Veranis <gveranis@dataly.gr> --- Created attachment 146388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146388&action=edit Bug 32908: Load item type icons from the correct path In the Staff interface, the details page of a bibliographic record should display the icon associated with the item type of an item ('Item type' column in the 'Holdings' tab). This feature broke in v22.11.00 (for Debian package installs): instead of the item type icon you get the default 'broken image URL' image of your web browser. This patch fixes that. Test plan: 1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show' 2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon 3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon 4) Visit the bibliographic record's details page in the Staff interface. Notice that in the 'Item type' column of the 'Holdings' tab instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser [*]. [*] In non-Debian package installs, the 'href' property of the item type icon's <img> tag should start with '/opac-tmpl/bootstrap/itemtypeimg' 5) Apply this patch, and refresh the page with CTRL-F5. The item type icon should now be displayed correctly. [*] KTD and Koha Sandboxes users: To verify the patch has worked, you should right-click on the item type icon and click 'Inspect: the 'href' property of the <img> tag should now start with: '/intranet-tmpl/prog/img/itemtypeimg' Mentored by : Andreas Roussos -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos@dataly.gr See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24121 URL| |catalogue/detail.pl Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Michael Kuhn <mik@adminkuhn.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik@adminkuhn.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32909 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146388|0 |1 is obsolete| | --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 146393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146393&action=edit Bug 32908: Load item type icons from the correct path In the Staff interface, the details page of a bibliographic record should display the icon associated with the item type of an item ('Item type' column in the 'Holdings' tab). This feature broke in v22.11.00 (for Debian package installs): instead of the item type icon you get the default 'broken image URL' image of your web browser. This patch fixes that. Test plan: 1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show' 2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon 3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon 4) Visit the bibliographic record's details page in the Staff interface. Notice that in the 'Item type' column of the 'Holdings' tab instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser [*]. [*] In non-Debian package installs, the 'href' property of the item type icon's <img> tag should start with '/opac-tmpl/bootstrap/itemtypeimg' 5) Apply this patch, and refresh the page with CTRL-F5. The item type icon should now be displayed correctly. [*] KTD and Koha Sandboxes users: To verify the patch has worked, you should right-click on the item type icon and click 'Inspect: the 'href' property of the <img> tag should now start with: '/intranet-tmpl/prog/img/itemtypeimg' Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146393|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146493&action=edit Bug 32908: Load item type icons from the correct path In the Staff interface, the details page of a bibliographic record should display the icon associated with the item type of an item ('Item type' column in the 'Holdings' tab). This feature broke in v22.11.00 (for Debian package installs): instead of the item type icon you get the default 'broken image URL' image of your web browser. This patch fixes that. Test plan: 1) (if needed) Configure the following System preferences: - item-level_itypes => 'specific item' - noItemTypeImages => 'Show' 2) (if needed) In Koha Administration > Item types, create an item type and associate it with an icon 3) (if needed) Create a test bibliographic record, and add an item to it that has an item type with an icon 4) Visit the bibliographic record's details page in the Staff interface. Notice that in the 'Item type' column of the 'Holdings' tab instead of seeing the icon associated with the item type of each item you get the default 'broken image URL' image of your web browser [*]. [*] In non-Debian package installs, the 'href' property of the item type icon's <img> tag should start with '/opac-tmpl/bootstrap/itemtypeimg' 5) Apply this patch, and refresh the page with CTRL-F5. The item type icon should now be displayed correctly. [*] KTD and Koha Sandboxes users: To verify the patch has worked, you should right-click on the item type icon and click 'Inspect: the 'href' property of the <img> tag should now start with: '/intranet-tmpl/prog/img/itemtypeimg' Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the fix, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31321 CC| |fridolin.somers@biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31321 [Bug 31321] Remove GetItemsInfo from catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 31321 if I understand well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Did you check reserve/request? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #8)
Did you check reserve/request?
forget that, just seen bug 32909 now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32908 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org